Re: [Nouveau] [RFC PATCH 08/29] clk: We should pass the pstate id around not the index in the list

2017-10-08 Thread Karol Herbst
On Sun, Oct 8, 2017 at 4:23 PM, Pierre Moreau wrote: > On 2017-09-15 — 17:11, Karol Herbst wrote: >> This makes the code easier, because we can compare the id with >> pstate->pstate and saves us from the trouble of iterating over the pstates >> to match the index. > > I don’t remember whether I ha

Re: [Nouveau] [RFC PATCH 08/29] clk: We should pass the pstate id around not the index in the list

2017-10-08 Thread Pierre Moreau
On 2017-09-15 — 17:11, Karol Herbst wrote: > This makes the code easier, because we can compare the id with > pstate->pstate and saves us from the trouble of iterating over the pstates > to match the index. I don’t remember whether I have already done this comment before, but I am not sure where

[Nouveau] [RFC PATCH 08/29] clk: We should pass the pstate id around not the index in the list

2017-09-15 Thread Karol Herbst
This makes the code easier, because we can compare the id with pstate->pstate and saves us from the trouble of iterating over the pstates to match the index. v2: reword commit message Signed-off-by: Karol Herbst Reviewed-by: Martin Peres --- drm/nouveau/nouveau_debugfs.c | 6 +-- drm/nou