Re: [Nouveau] [PATCH v2 2/4] drm/amdkfd: Use cursor start instead of ttm resource start

2023-01-25 Thread Christian König
Am 25.01.23 um 11:48 schrieb Somalapuram Amaranath: cleanup PAGE_SHIFT operation and replacing ttm_resource resource->start with cursor start using amdgpu_res_first API v1 -> v2: reorder patch sequence Signed-off-by: Somalapuram Amaranath ---

Re: [Nouveau] [PATCH v3 3/4] drm/amdgpu: Movie the amdgpu_gtt_mgr start and size from pages to bytes

2023-01-25 Thread Christian König
Am 25.01.23 um 15:24 schrieb Somalapuram Amaranath: To support GTT manager amdgpu_res_first, amdgpu_res_next from pages to bytes and clean up PAGE_SHIFT operation. v1 -> v2: reorder patch sequence Ok once more: You need to squash this patch here together with the other patches. Otherwise

Re: [Nouveau] [PATCH v2 1/4] drm/amdgpu: Use cursor start instead of ttm resource start

2023-01-25 Thread Christian König
Am 25.01.23 um 11:48 schrieb Somalapuram Amaranath: cleanup PAGE_SHIFT operation and replacing ttm_resource resource->start with cursor start using amdgpu_res_first API. v1 -> v2: reorder patch sequence Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 11

Re: [Nouveau] [PATCH v3 1/4] drm/amdgpu: Use cursor start instead of ttm resource start

2023-01-25 Thread Christian König
Am 25.01.23 um 15:24 schrieb Somalapuram Amaranath: cleanup PAGE_SHIFT operation and replacing ttm_resource resource->start with cursor start using amdgpu_res_first API. v1 -> v2: reorder patch sequence v2 -> v3: addressing review comment v2 Signed-off-by: Somalapuram Amaranath ---

Re: [Nouveau] [PATCH v3 00/10] Let iommufd charge IOPTE allocations to the memory cgroup

2023-01-25 Thread Joerg Roedel
On Mon, Jan 23, 2023 at 04:35:53PM -0400, Jason Gunthorpe wrote: > Jason Gunthorpe (10): > iommu: Add a gfp parameter to iommu_map() > iommu: Remove iommu_map_atomic() > iommu: Add a gfp parameter to iommu_map_sg() > iommu/dma: Use the gfp parameter in __iommu_dma_alloc_noncontiguous() >

Re: [Nouveau] [PATCH v3 2/4] drm/amdkfd: Use cursor start instead of ttm resource start

2023-01-25 Thread Christian König
Am 25.01.23 um 15:24 schrieb Somalapuram Amaranath: cleanup PAGE_SHIFT operation and replacing ttm_resource resource->start with cursor start using amdgpu_res_first API. v1 -> v2: reorder patch sequence v2 -> v3: addressing review comment v2 Signed-off-by: Somalapuram Amaranath Reviewed-by:

Re: [Nouveau] [PATCH] drm/nouveau/disp: Fix nvif_outp_acquire_dp() argument size

2023-01-25 Thread Kees Cook
Ping. I'll take this via my tree unless someone else wants to take it... On Sun, Nov 27, 2022 at 10:30:41AM -0800, Kees Cook wrote: > Both Coverity and GCC with -Wstringop-overflow noticed that > nvif_outp_acquire_dp() accidentally defined its second argument with 1 > additional element: > >

Re: [Nouveau] [PATCH] drm/nouveau/devinit: Convert function disable() to be void

2023-01-25 Thread Lyude Paul
Reviewed-by: Lyude Paul Will push upstream in a moment On Wed, 2023-01-25 at 20:37 +0530, Deepak R Varma wrote: > The current design of callback function disable() of struct > nvkm_devinit_func is defined to return a u64 value. In its implementation > in the driver modules, the function always

Re: [Nouveau] [PATCH] drm/nouveau/disp: Fix nvif_outp_acquire_dp() argument size

2023-01-25 Thread Lyude Paul
Sorry! I've been pretty busy until now, this is: Reviewed-by: Lyude Paul Let me know if you've pushed it already or if you want me to push it to drm- misc On Wed, 2023-01-25 at 12:15 -0800, Kees Cook wrote: > Ping. I'll take this via my tree unless someone else wants to take it... > > On Sun,

Re: [Nouveau] [PATCH 1/4] drm/amdgpu: Movie the amdgpu_gtt_mgr start and size from pages to bytes

2023-01-25 Thread Christian König
Am 25.01.23 um 11:00 schrieb Somalapuram Amaranath: To support GTT manager amdgpu_res_first, amdgpu_res_next from pages to bytes and clean up PAGE_SHIFT operation. You really need to think more about the order and integrity of your patches. Keep in mind that each patch on its own should be