Re: [Nouveau] [PATCH 07/10] drm: extract dp link train delay functions from radeon

2012-10-19 Thread Alex Deucher
nector, > dp_info->link_status)) { > DRM_ERROR("displayport link status failed\n"); > @@ -901,7 +895,6 @@ void radeon_dp_link_train(struct drm_encoder *encoder, > else > dp_info.enc_id |= ATOM_DP_CONFIG_LINK_A; > > -

Re: [Nouveau] [PATCH 00/10] extract dp helper functions

2012-10-19 Thread Alex Deucher
tried to put the new helpers a bit to use in nouveau, but due to > lack > of hw that part is untested. > > Comments and testing highly welcome. Looks good to me. Other than the minor change required in patch7, this series is: Reviewed-by: Alex Deucher > > Yours, Danie

Re: [Nouveau] [PATCH 00/10] extract dp helper functions

2012-10-19 Thread Alex Deucher
On Thu, Oct 18, 2012 at 4:15 AM, Daniel Vetter wrote: > Hi all, > > I've frustrated myself the last few days yelling at our link training code. > Comparing the i915 code to radeon and nouveau I've noticed the lack of a nice > set of dp helper functions. So I've started to extract a few. > > There'

Re: [Nouveau] [PATCH 1/3] drm/radeon: remove AGP support

2020-05-11 Thread Alex Deucher
e is no change on PowerPC." With that updated, patches 1, 3: Reviewed-by: Alex Deucher patch 2: Acked-by: Alex Deucher > > Signed-off-by: Christian König > --- > drivers/gpu/drm/radeon/Makefile| 4 +- > drivers/gpu/drm/radeon/evergreen.c | 7 - > driv

Re: [Nouveau] [RFC] Remove AGP support from Radeon/Nouveau/TTM

2020-05-11 Thread Alex Deucher
On Mon, May 11, 2020 at 4:22 PM Al Dunsmuir wrote: > > On Monday, May 11, 2020, 1:17:19 PM, "Christian König" wrote: > > Hi guys, > > > Well let's face it AGP is a total headache to maintain and dead for at > > least 10+ years. > > > We have a lot of x86 specific stuff in the architecture indepen

Re: [Nouveau] [PATCH 1/3] drm/radeon: remove AGP support

2020-05-12 Thread Alex Deucher
On Tue, May 12, 2020 at 4:16 AM Michel Dänzer wrote: > > On 2020-05-11 10:12 p.m., Alex Deucher wrote: > > On Mon, May 11, 2020 at 1:17 PM Christian König > > wrote: > >> > >> AGP is deprecated for 10+ years now and not used any more on modern > >

Re: [Nouveau] [PATCH 1/3] drm/radeon: remove AGP support

2020-05-12 Thread Alex Deucher
On Tue, May 12, 2020 at 2:20 PM Thomas Zimmermann wrote: > > Hi Christian > > Am 11.05.20 um 19:17 schrieb Christian König: > > AGP is deprecated for 10+ years now and not used any more on modern > > hardware. > > > > Old hardware should continue to work in PCI mode. > > > > Signed-off-by: Christ

Re: [Nouveau] [RFC] Remove AGP support from Radeon/Nouveau/TTM

2020-05-12 Thread Alex Deucher
On Tue, May 12, 2020 at 2:29 PM Thomas Zimmermann wrote: > > Hi > > Am 11.05.20 um 19:17 schrieb Christian König: > > Hi guys, > > > > Well let's face it AGP is a total headache to maintain and dead for at > > least 10+ years. > > > > We have a lot of x86 specific stuff in the architecture indepe

Re: [Nouveau] [RFC] Remove AGP support from Radeon/Nouveau/TTM

2020-05-12 Thread Alex Deucher
On Tue, May 12, 2020 at 3:10 PM Thomas Zimmermann wrote: > > Hi Alex > > Am 12.05.20 um 20:32 schrieb Alex Deucher: > > On Tue, May 12, 2020 at 2:29 PM Thomas Zimmermann > > wrote: > >> > >> Hi > >> > >> Am 11.05.20 um 19:17 schrieb Ch

Re: [Nouveau] [PATCH 1/3] drm/radeon: remove AGP support

2020-05-12 Thread Alex Deucher
On Tue, May 12, 2020 at 4:52 PM Roy Spliet wrote: > > Op 12-05-2020 om 14:36 schreef Alex Deucher: > > On Tue, May 12, 2020 at 4:16 AM Michel Dänzer wrote: > >> > >> On 2020-05-11 10:12 p.m., Alex Deucher wrote: > >>> On Mon, May 11, 20

Re: [Nouveau] [RFC] Deprecate AGP GART support for Radeon/Nouveau/TTM

2020-05-20 Thread Alex Deucher
On Wed, May 20, 2020 at 10:43 AM Christian König wrote: > > Am 13.05.20 um 13:03 schrieb Christian König: > > Unfortunately AGP is still to widely used as we could just drop support for > > using its GART. > > > > Not using the AGP GART also doesn't mean a loss in functionality since > > drivers

Re: [Nouveau] [RFC] Deprecate AGP GART support for Radeon/Nouveau/TTM

2020-05-22 Thread Alex Deucher
On Fri, May 22, 2020 at 6:41 AM Christian König wrote: > > Am 20.05.20 um 18:18 schrieb Alex Deucher: > > On Wed, May 20, 2020 at 10:43 AM Christian König > > wrote: > >> Am 13.05.20 um 13:03 schrieb Christian König: > >>> Unfortunately AGP is still to wi

Re: [Nouveau] [PATCH 1/4] drm: retrieve EDID via ACPI _DDC method

2020-08-12 Thread Alex Deucher
On Wed, Aug 12, 2020 at 10:31 PM Daniel Dadap wrote: > > Thanks, Lukas. I've incorporated your feedback into my local tree, but > will wait for additional feedback from the individual DRM driver > maintainers before sending out a series v2. > > On 8/8/20 5:11 PM, Lukas Wunner wrote: > > On Mon, Ju

Re: [Nouveau] [PATCH 5/5] drm/: Constify struct drm_driver

2020-10-30 Thread Alex Deucher
org > Cc: Dave Airlie > Cc: Gerd Hoffmann > Cc: virtualizat...@lists.linux-foundation.org > Cc: Harry Wentland > Cc: Leo Li > Cc: Alex Deucher > Cc: Christian König > Cc: Eric Anholt > Cc: Maxime Ripard > Cc: Ben Skeggs > Cc: nouveau@lists.freedesktop.org

Re: [Nouveau] [PATCH 01/15] drm/amdgpu: Remove references to struct drm_device.pdev

2020-11-25 Thread Alex Deucher
On Tue, Nov 24, 2020 at 6:38 AM Thomas Zimmermann wrote: > > Using struct drm_device.pdev is deprecated. Convert amdgpu to struct > drm_device.dev. No functional changes. > > Signed-off-by: Thomas Zimmermann > Cc: Alex Deucher > Cc: Christian König There are a few unrelat

Re: [Nouveau] [PATCH 11/15] drm/radeon: Remove references to struct drm_device.pdev

2020-11-25 Thread Alex Deucher
On Tue, Nov 24, 2020 at 6:39 AM Thomas Zimmermann wrote: > > Using struct drm_device.pdev is deprecated. Convert radeon to struct > drm_device.dev. No functional changes. > > Signed-off-by: Thomas Zimmermann > Cc: Alex Deucher > Cc: Christian König There are a few unrelat

Re: [Nouveau] [PATCH v2 01/20] drm/amdgpu: Fix trailing whitespaces

2020-12-02 Thread Alex Deucher
gt; Regards, > > Christian. > > > >> > >> Best regards > >> Thomas > >> > >>> > >>> Regards, > >>> Christian. > >>> > >>> Am 01.12.20 um 11:35 schrieb Thomas Zimmermann: > >>&

Re: [Nouveau] [PATCH 0/3] drm/ttm: constify static vm_operations_structs

2021-02-23 Thread Alex Deucher
On Wed, Feb 10, 2021 at 8:14 AM Daniel Vetter wrote: > > On Wed, Feb 10, 2021 at 08:45:56AM +0100, Christian König wrote: > > Reviewed-by: Christian König for the series. > > Smash it into -misc? @Christian Koenig did these ever land? I don't see them in drm-misc. Alex > -Daniel > > > > > Am

Re: [Nouveau] [PATCH 4/8] drm/radeon: Implement mmap as GEM object function

2021-04-06 Thread Alex Deucher
On Tue, Apr 6, 2021 at 5:09 AM Thomas Zimmermann wrote: > > Moving the driver-specific mmap code into a GEM object function allows > for using DRM helpers for various mmap callbacks. > > This change also allows to support prime-based mmap via DRM's helper > drm_gem_prime_mmap(). > > Permission che

Re: [Nouveau] [PATCH] drm/nouveau: fix dma_address check for CPU/GPU sync

2021-06-22 Thread Alex Deucher
On Tue, Jun 22, 2021 at 5:32 AM Christian König wrote: > > Ping? Does anybody wants to give me an rb or acked-by? > > AGP is basically broken on nouveu without this. Looks correct to me. Acked-by: Alex Deucher > > Christian. > > Am 14.06.21 um 13:05 schrieb Christian Kö

Re: [Nouveau] [PATCH] drm/nouveau/acr: Fix undefined behavior in nvkm_acr_hsfw_load_bl()

2022-01-28 Thread Alex Deucher
On Fri, Jan 28, 2022 at 2:20 PM Lyude Paul wrote: > > Sigh-thank you for catching this - I had totally forgot about the umn.edu ban. > I pushed this already but I will go ahead and send a revert for this patch. > Will cc you on it as well. This seems short-sighted. If the patch is valid I see no

Re: [Nouveau] [PATCH] drm/nouveau/acr: Fix undefined behavior in nvkm_acr_hsfw_load_bl()

2022-01-28 Thread Alex Deucher
On Fri, Jan 28, 2022 at 2:58 PM Karol Herbst wrote: > > On Fri, Jan 28, 2022 at 8:54 PM Alex Deucher wrote: > > > > On Fri, Jan 28, 2022 at 2:20 PM Lyude Paul wrote: > > > > > > Sigh-thank you for catching this - I had totally forgot about the umn.edu > &

Re: [Nouveau] [PATCH v4 00/10] Overhaul `is_thunderbolt`

2022-02-16 Thread Alex Deucher
On Wed, Feb 16, 2022 at 9:34 AM Mika Westerberg wrote: > > Hi all, > > On Tue, Feb 15, 2022 at 01:07:00PM -0600, Limonciello, Mario wrote: > > On 2/15/2022 01:29, Lukas Wunner wrote: > > > On Mon, Feb 14, 2022 at 06:01:50PM -0600, Mario Limonciello wrote: > > > > drivers/gpu/drm/amd/amdgpu/amdgp

Re: [Nouveau] [PATCH v5 3/7] PCI: Drop the `is_thunderbolt` attribute from PCI core

2022-02-25 Thread Alex Deucher
On Thu, Feb 24, 2022 at 8:23 PM Bjorn Helgaas wrote: > > On Thu, Feb 24, 2022 at 03:51:12PM -0600, Mario Limonciello wrote: > > The `is_thunderbolt` attribute originally had a well defined list of > > quirks that it existed for, but it has been overloaded with more > > meaning. > > > > Instead use

Re: [Nouveau] Per file OOM badness

2022-05-31 Thread Alex Deucher
+ dri-devel On Tue, May 31, 2022 at 6:00 AM Christian König wrote: > > Hello everyone, > > To summarize the issue I'm trying to address here: Processes can allocate > resources through a file descriptor without being held responsible for it. > > Especially for the DRM graphics driver subsystem th

Re: [Nouveau] [RESEND RFC 17/18] drm/radeon: Drop legacy MST support

2022-06-07 Thread Alex Deucher
without needing to maintain the legacy MST > helpers (trying to move them would probably be acceptable), I'm happy to > suggestions. But my hope is that we can just drop this code and forget > about it. I've already run this idea by Harry Wentland and Alex Deucher a > few ti

Re: [Nouveau] [PATCH v2 03/29] drm/amdgpu: Don't register backlight when another backlight should be used

2022-07-20 Thread Alex Deucher
> - To avoid linker errors when amdgpu is builtin and video_detect.c is in > a module, select ACPI_VIDEO and its deps if ACPI && X86 are enabled. > When these are not set, ACPI_VIDEO is disabled, ensuring the stubs > from acpi/video.h will be used. > > Signed-of

Re: [Nouveau] [PATCH v2 04/29] drm/radeon: Don't register backlight when another backlight should be used

2022-07-20 Thread Alex Deucher
> - To avoid linker errors when radeon is builtin and video_detect.c is in > a module, select ACPI_VIDEO and its deps if ACPI && X86 are enabled. > When these are not set, ACPI_VIDEO is disabled, ensuring the stubs > from acpi/video.h will be used. > > Signed-of

Re: [Nouveau] [PATCH v2 03/29] drm/amdgpu: Don't register backlight when another backlight should be used

2022-07-20 Thread Alex Deucher
On Wed, Jul 20, 2022 at 12:44 PM Alex Deucher wrote: > > On Tue, Jul 12, 2022 at 3:39 PM Hans de Goede wrote: > > > > Before this commit when we want userspace to use the acpi_video backlight > > device we register both the GPU's native backlight device and acpi_vi

Re: [Nouveau] [PATCH v2 09/29] ACPI: video: Make backlight class device registration a separate step

2022-07-20 Thread Alex Deucher
On Tue, Jul 12, 2022 at 3:40 PM Hans de Goede wrote: > > On x86/ACPI boards the acpi_video driver will usually initializing before initializing -> initialize > the kms driver (except i915). This causes /sys/class/backlight/acpi_video0 > to show up and then the kms driver registers its own native

Re: [Nouveau] [PATCH v2 13/29] drm/amdgpu: Register ACPI video backlight when skipping amdgpu backlight registration

2022-07-20 Thread Alex Deucher
ster_acpi_backlight: > + /* Try registering an ACPI video backlight device instead. */ > + acpi_video_register_backlight(); > + return; Can drop the return here. Either way, Acked-by: Alex Deucher > } > > void > diff --git a/drivers/gpu/drm/amd/display/amd

Re: [Nouveau] [PATCH v2 14/29] drm/radeon: Register ACPI video backlight when skipping radeon backlight registration

2022-07-20 Thread Alex Deucher
klight device should be used, it will be available > before the radeon drm_device gets registered with userspace. > > Signed-off-by: Hans de Goede Acked-by: Alex Deucher > --- > drivers/gpu/drm/radeon/radeon_encoders.c | 11 ++- > 1 file changed, 10 insertions(+), 1 delet

Re: [Nouveau] [PATCH] drm/nouveau: Remove file nouveau_fbcon.c

2023-01-09 Thread Alex Deucher
On Mon, Jan 9, 2023 at 9:06 AM Thomas Zimmermann wrote: > > Commit 4a16dd9d18a0 ("drm/nouveau/kms: switch to drm fbdev helpers") > converted nouveau to generic fbdev emulation. Also remove the internal > implementation from the driver. No functional changes. Looking at 4a16dd9d18a0, it appears to

Re: [Nouveau] [PATCH] drm/nouveau: Remove file nouveau_fbcon.c

2023-01-09 Thread Alex Deucher
On Mon, Jan 9, 2023 at 10:27 AM Thomas Zimmermann wrote: > > Hi > > Am 09.01.23 um 15:15 schrieb Alex Deucher: > > On Mon, Jan 9, 2023 at 9:06 AM Thomas Zimmermann > > wrote: > >> > >> Commit 4a16dd9d18a0 ("drm/nouveau/kms: switch to drm fbdev he

Re: [Nouveau] [PATCH 01/22] drm/amdgpu: Fix coding style

2023-01-16 Thread Alex Deucher
Applied. Thanks! On Mon, Jan 16, 2023 at 8:13 AM Thomas Zimmermann wrote: > > Align a closing brace and remove trailing whitespaces. No functional > changes. > > Signed-off-by: Thomas Zimmermann > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 de

Re: [Nouveau] [PATCH 00/22] drm: Remove includes for drm_crtc_helper.h

2023-01-16 Thread Alex Deucher
> fine, though that probably doesn't add much coverage. > > FWIW, > > Acked-by: Jani Nikula Agreed. I applied 1/22 since it was an unrelated cleanup, but the rest of the series is: Acked-by: Alex Deucher > > > -- > Jani Nikula, Intel Open Source Graphics Center

Re: [Nouveau] [PATCH v3 0/3] drm/{amdgpu, i915, nouveau, radeon}: Fix fbdev and vga-switcheroo

2023-01-16 Thread Alex Deucher
of drm_lastclose() and drivers do not > need their own lastclose helpers any longer. > > I kept the r-bs from v1, but patch 1 is entirely new and patch 3 has > significantly grown in size. Series is: Reviewed-by: Alex Deucher > > v3: > * include drm_fb_helper.h in

Re: [PATCH v2 01/12] drm/amdgpu, drm/radeon: Make I2C terminology more inclusive

2024-05-08 Thread Alex Deucher
On Tue, May 7, 2024 at 2:32 PM Easwar Hariharan wrote: > > On 5/3/2024 11:13 AM, Easwar Hariharan wrote: > > I2C v7, SMBus 3.2, and I3C 1.1.1 specifications have replaced "master/slave" > > with more appropriate terms. Inspired by and following on to Wolfram's > > series to fix drivers/i2c/[1], fi

Re: [PATCH v2 01/12] drm/amdgpu, drm/radeon: Make I2C terminology more inclusive

2024-05-08 Thread Alex Deucher
On Wed, May 8, 2024 at 4:12 PM Easwar Hariharan wrote: > > On 5/8/2024 7:53 AM, Alex Deucher wrote: > > On Tue, May 7, 2024 at 2:32 PM Easwar Hariharan > > wrote: > >> > >> On 5/3/2024 11:13 AM, Easwar Hariharan wrote: > >>> I2C v7, SMBus

Re: [RESEND 0/6] drm, nouveau/radeon/amdpgu: edid_blob_ptr cleanups

2024-05-10 Thread Alex Deucher
d has_audio from display info > drm/radeon: remove radeon_connector_edid() and stop using > edid_blob_ptr > drm/amdgpu: remove amdgpu_connector_edid() and stop using > edid_blob_ptr > drm/edid: add a helper for EDID sysfs property show > drm/connector: update

Re: [RESEND 0/6] drm, nouveau/radeon/amdpgu: edid_blob_ptr cleanups

2024-05-13 Thread Alex Deucher
On Mon, May 13, 2024 at 8:20 AM Jani Nikula wrote: > > On Fri, 10 May 2024, Alex Deucher wrote: > > On Fri, May 10, 2024 at 11:17 AM Jani Nikula wrote: > >> > >> I've sent this some moths ago, let's try again... > >> > >> BR, > >&

Re: [PATCH 1/4] drm/amdgpu: fix -Wformat-truncation warning in amdgpu_gfx_kiq_init_ring()

2024-05-23 Thread Alex Deucher
~ > 333 | xcc_id, ring->me, ring->pipe, ring->queue); > | ~~ > > Silence the warning by checking the snprintf() return value. > Already fixed with this patch: https://patchw

Re: [PATCH v2 1/9] drm: Do delayed switcheroo in drm_lastclose()

2024-08-12 Thread Alex Deucher
On Mon, Aug 12, 2024 at 10:40 AM Daniel Vetter wrote: > > On Mon, Aug 12, 2024 at 12:41:39PM +0200, Thomas Zimmermann wrote: > > Hi > > > > Am 12.08.24 um 12:18 schrieb Daniel Vetter: > > > On Mon, Aug 12, 2024 at 11:23:44AM +0200, Daniel Vetter wrote: > > > > On Mon, Aug 12, 2024 at 10:28:22AM +0

Re: [PATCH v2 1/9] drm: Do delayed switcheroo in drm_lastclose()

2024-08-12 Thread Alex Deucher
itcheroo do the delayed switching. The call has no effect on other > hardware. > > v2: > - move change to drm_lastclose() (Sima) > - update docs for vga_switcheroo_process_delayed_switch() > > Signed-off-by: Thomas Zimmermann Reviewed-by: Alex Deucher > --- > drivers/gp

Re: [PATCH v2 2/9] drm/amdgpu: Do not set struct drm_driver.lastclose

2024-08-12 Thread Alex Deucher
close(). > > v2: > - update commit message > > Signed-off-by: Thomas Zimmermann Reviewed-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 - > drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 2 -- > drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 17

Re: [PATCH v2 2/9] drm/amdgpu: Do not set struct drm_driver.lastclose

2024-08-12 Thread Alex Deucher
On Mon, Aug 12, 2024 at 3:05 PM Alex Deucher wrote: > > On Mon, Aug 12, 2024 at 4:30 AM Thomas Zimmermann wrote: > > > > Remove the implementation of struct drm_driver.lastclose. The hook > > was only necessary before in-kernel DRM clients existed, but is now &

Re: [PATCH v2 65/86] drm/amdgpu: Run DRM default client setup

2024-08-22 Thread Alex Deucher
a preferred color mode depending on > the available video memory, with a default of 32. Adapt this for > the new client interface. > > v2: > - style changes > > Signed-off-by: Thomas Zimmermann > Cc: Alex Deucher > Cc: "Christian König" > Cc: Xinhui Pan

Re: [PATCH v2 78/86] drm/radeon: Run DRM default client setup

2024-08-22 Thread Alex Deucher
ory, with a default of 32. Adapt this for > the new client interface. > > v2: > - style changes > > Signed-off-by: Thomas Zimmermann > Cc: Alex Deucher > Cc: "Christian König" > Cc: Xinhui Pan Acked-by: Alex Deucher > --- > drivers/gpu

Re: [PATCH -next 3/3] drm/amdgpu: use clamp() in nvkm_volt_map()

2024-08-30 Thread Alex Deucher
The patch title prefix should say drm/nouveau. Alex On Fri, Aug 30, 2024 at 3:15 AM Li Zetao wrote: > > When it needs to get a value within a certain interval, using clamp() > makes the code easier to understand than min(max()). > > Signed-off-by: Li Zetao > --- > drivers/gpu/drm/nouveau/nvkm/

Re: [PATCH -next 2/3] drm/amdgpu: use clamp() in amdgpu_vm_adjust_size()

2024-09-02 Thread Alex Deucher
Applied amdgpu patches. Thanks! On Fri, Aug 30, 2024 at 10:19 AM Christian König wrote: > > Am 30.08.24 um 03:22 schrieb Li Zetao: > > When it needs to get a value within a certain interval, using clamp() > > makes the code easier to understand than min(max()). > > > > Signed-off-by: Li Zetao >

Re: [Nouveau] [PATCH] drm: remove redundant 'default n' from Kconfig

2019-04-13 Thread Alex Deucher
lied). > That might make it clearer to people that a bare 'default n' is > redundant. > ... > > Signed-off-by: Bartlomiej Zolnierkiewicz Acked-by: Alex Deucher for amdgpu and drm. > --- > drivers/gpu/drm/Kconfig |5 - > drivers/

Re: [PATCH 15/15] amdgpu: remove CONFIG_DRM_AMDGPU_USERPTR

2019-08-06 Thread Alex Deucher
On Tue, Aug 6, 2019 at 1:51 PM Kuehling, Felix wrote: > > On 2019-08-06 13:44, Jason Gunthorpe wrote: > > On Tue, Aug 06, 2019 at 07:05:53PM +0300, Christoph Hellwig wrote: > >> The option is just used to select HMM mirror support and has a very > >> confusing help text. Just pull in the HMM mirr

Re: [Nouveau] [PATCH 1/7] Revert "ACPI / OSI: Add OEM _OSI string to enable dGPU direct output"

2019-08-15 Thread Alex Deucher
On Thu, Aug 15, 2019 at 10:04 AM Karol Herbst wrote: > > On Thu, Aug 15, 2019 at 3:56 PM wrote: > > > > > -Original Message- > > > From: linux-acpi-ow...@vger.kernel.org > > > On > > > Behalf Of Dave Airlie > > > Sent: Wednesday, August 14, 2019 5:48 PM > > > To: Karol Herbst > > > Cc:

Re: [Nouveau] [PATCH 1/7] Revert "ACPI / OSI: Add OEM _OSI string to enable dGPU direct output"

2019-08-15 Thread Alex Deucher
On Thu, Aug 15, 2019 at 10:15 AM Karol Herbst wrote: > > On Thu, Aug 15, 2019 at 4:13 PM Alex Deucher wrote: > > > > On Thu, Aug 15, 2019 at 10:04 AM Karol Herbst wrote: > > > > > > On Thu, Aug 15, 2019 at 3:56 PM wrote: > > > > > > >

Re: [Nouveau] [PATCH 1/7] Revert "ACPI / OSI: Add OEM _OSI string to enable dGPU direct output"

2019-08-15 Thread Alex Deucher
On Thu, Aug 15, 2019 at 10:25 AM Karol Herbst wrote: > > On Thu, Aug 15, 2019 at 4:20 PM wrote: > > > > > > There are definitely going to be regressions on machines in the field > > > > with the > > > > in tree drivers by reverting this. I think we should have an answer > > > > for all of > >

Re: [Nouveau] [PATCH 1/7] Revert "ACPI / OSI: Add OEM _OSI string to enable dGPU direct output"

2019-08-15 Thread Alex Deucher
On Thu, Aug 15, 2019 at 10:30 AM wrote: > > > On Thu, Aug 15, 2019 at 10:15 AM Karol Herbst wrote: > > > > > > On Thu, Aug 15, 2019 at 4:13 PM Alex Deucher > > wrote: > > > > > > > > On Thu, Aug 15, 2019 at 10:04 AM Karol Herbst > &

Re: [Nouveau] [PATCH 1/7] Revert "ACPI / OSI: Add OEM _OSI string to enable dGPU direct output"

2019-08-15 Thread Alex Deucher
On Thu, Aug 15, 2019 at 10:37 AM Alex Deucher wrote: > > On Thu, Aug 15, 2019 at 10:25 AM Karol Herbst wrote: > > > > On Thu, Aug 15, 2019 at 4:20 PM wrote: > > > > > > > > There are definitely going to be regressions on machines in the field >

Re: [Nouveau] [PATCH 1/7] Revert "ACPI / OSI: Add OEM _OSI string to enable dGPU direct output"

2019-08-15 Thread Alex Deucher
On Thu, Aug 15, 2019 at 12:19 PM wrote: > > > -Original Message- > > From: Takashi Iwai > > Sent: Thursday, August 15, 2019 9:57 AM > > To: Alex Deucher > > Cc: Karol Herbst; Limonciello, Mario; nouveau; Rafael J . Wysocki; LKML; > > dri-devel;

Re: [Nouveau] [PATCH 1/7] Revert "ACPI / OSI: Add OEM _OSI string to enable dGPU direct output"

2019-09-05 Thread Alex Deucher
On Thu, Sep 5, 2019 at 11:51 AM Karol Herbst wrote: > > is there any update on the testing with my patches? On the hardware I > had access to those patches helped, but I can't know if it also helped > on the hardware for which those workarounds where actually added. > > On Mon, Aug 19, 2019 at 11:

Re: [Nouveau] [PATCH v2 24/27] drm/amdgpu/dm: Resume short HPD IRQs before resuming MST topology

2019-09-13 Thread Alex Deucher
So, do that. > > Cc: Juston Li > Cc: Imre Deak > Cc: Ville Syrjälä > Cc: Harry Wentland > Cc: Daniel Vetter > Signed-off-by: Lyude Paul Acked-by: Alex Deucher > --- > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 6 +++--- > 1 file changed, 3 insertions(+

Re: [Nouveau] [PATCH v2 23/27] drm/amdgpu: Iterate through DRM connectors correctly

2019-09-14 Thread Alex Deucher
esh. > > So, do that. In fairness, I think the origin of this code predated the iterators. Reviewed-by: Alex Deucher > > Cc: Juston Li > Cc: Imre Deak > Cc: Ville Syrjälä > Cc: Harry Wentland > Cc: Daniel Vetter > Signed-off-by: Lyude Paul > --- >

Re: [Nouveau] [PATCH TRIVIAL v2] gpu: Fix Kconfig indentation

2019-10-07 Thread Alex Deucher
On Mon, Oct 7, 2019 at 7:39 AM Jani Nikula wrote: > > On Fri, 04 Oct 2019, Krzysztof Kozlowski wrote: > > drivers/gpu/drm/i915/Kconfig | 12 +- > > drivers/gpu/drm/i915/Kconfig.debug | 144 +++ > > Please split these out to a separate patch. Can't speak for

Re: [Nouveau] [PATCH v2 23/27] drm/amdgpu: Iterate through DRM connectors correctly

2019-12-27 Thread Alex Deucher
On Fri, Sep 13, 2019 at 4:45 PM Alex Deucher wrote: > > On Tue, Sep 3, 2019 at 4:49 PM Lyude Paul wrote: > > > > Currently, every single piece of code in amdgpu that loops through > > connectors does it incorrectly and doesn't use the prop

Re: [Nouveau] [PATCH 05/23] drm/radeon: Convert to struct drm_crtc_helper_funcs.get_scanout_position()

2020-01-17 Thread Alex Deucher
On Fri, Jan 10, 2020 at 4:22 AM Thomas Zimmermann wrote: > > The callback struct drm_driver.get_scanout_position() is deprecated in > favor of struct drm_crtc_helper_funcs.get_scanout_position(). Convert > radeon over. > I'd prefer to just change the signature of radeon_get_crtc_scanoutpos() to m

Re: [Nouveau] [PATCH 12/23] drm/amdgpu: Convert to CRTC VBLANK callbacks

2020-01-17 Thread Alex Deucher
On Fri, Jan 10, 2020 at 4:22 AM Thomas Zimmermann wrote: > > VBLANK callbacks in struct drm_driver are deprecated in favor of > their equivalents in struct drm_crtc_funcs. Convert amdgpu over. I think I'd prefer to just update the signatures of the relevant functions rather than wrapping them. A

Re: [Nouveau] [PATCH 17/23] drm/radeon: Convert to CRTC VBLANK callbacks

2020-01-17 Thread Alex Deucher
On Fri, Jan 10, 2020 at 4:22 AM Thomas Zimmermann wrote: > > VBLANK callbacks in struct drm_driver are deprecated in favor of > their equivalents in struct drm_crtc_funcs. Convert radeon over. > > Signed-off-by: Thomas Zimmermann Reviewed-by: Alex Deucher > --- > d

Re: [Nouveau] [PATCH 02/23] drm/amdgpu: Convert to struct drm_crtc_helper_funcs.get_scanout_position()

2020-01-17 Thread Alex Deucher
On Fri, Jan 10, 2020 at 4:21 AM Thomas Zimmermann wrote: > > The callback struct drm_driver.get_scanout_position() is deprecated in > favor of struct drm_crtc_helper_funcs.get_scanout_position(). Convert > amdgpu over. > I would prefer to just change the signature of amdgpu_display_get_crtc_scano

Re: [Nouveau] [PATCH 02/23] drm/amdgpu: Convert to struct drm_crtc_helper_funcs.get_scanout_position()

2020-01-17 Thread Alex Deucher
On Wed, Jan 15, 2020 at 4:41 AM Thomas Zimmermann wrote: > > Hi > > Am 13.01.20 um 19:52 schrieb Alex Deucher: > > On Fri, Jan 10, 2020 at 4:21 AM Thomas Zimmermann > > wrote: > >> > >> The callback struct drm_driver.get_scanout_positi

Re: [Nouveau] [PATCH v4 10/22] drm/radeon: Convert to struct drm_crtc_helper_funcs.get_scanout_position()

2020-02-03 Thread Alex Deucher
> Signed-off-by: Thomas Zimmermann Reviewed-by: Alex Deucher > --- > drivers/gpu/drm/radeon/atombios_crtc.c | 1 + > drivers/gpu/drm/radeon/radeon_display.c | 13 + > drivers/gpu/drm/radeon/radeon_drv.c | 11 --- > drivers/gpu/drm/radeon/radeon

Re: [Nouveau] [PATCH v4 04/22] drm/amdgpu: Convert to struct drm_crtc_helper_funcs.get_scanout_position()

2020-02-03 Thread Alex Deucher
On Thu, Jan 23, 2020 at 9:00 AM Thomas Zimmermann wrote: > > The callback struct drm_driver.get_scanout_position() is deprecated in > favor of struct drm_crtc_helper_funcs.get_scanout_position(). Convert > amdgpu over. > > Signed-off-by: Thomas Zimmermann Reviewe

Re: [Nouveau] [PATCH v4 05/22] drm/amdgpu: Convert to CRTC VBLANK callbacks

2020-02-03 Thread Alex Deucher
t; > Signed-off-by: Thomas Zimmermann Reviewed-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/amdgpu.h | 6 +++--- > drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 4 ++-- > drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 4 > driver

Re: [Nouveau] swiotlb buffer is full

2018-01-31 Thread Alex Deucher
On Wed, Jan 31, 2018 at 9:20 PM, Ilia Mirkin wrote: > Yeah, a lot of people were getting that, as a result of some drm/ttm > hugepage usage. > > Christian, did a fix ever end up going out? If so, what kernel was it > included in? https://lkml.org/lkml/2018/1/16/106 Alex > > -ilia > > On Wed,

Re: [Nouveau] [PATCH 0/5] Fix deadlock on runtime suspend in DRM drivers

2018-02-12 Thread Alex Deucher
On Mon, Feb 12, 2018 at 4:45 AM, Lukas Wunner wrote: > On Mon, Feb 12, 2018 at 09:03:26AM +, Mike Lothian wrote: >> On 12 February 2018 at 03:39, Lukas Wunner wrote: >> > On Mon, Feb 12, 2018 at 12:35:51AM +, Mike Lothian wrote: >> > > I've not been able to reproduce the original problem

Re: [Nouveau] [PATCH 0/5] Fix deadlock on runtime suspend in DRM drivers

2018-02-13 Thread Alex Deucher
On Tue, Feb 13, 2018 at 3:17 AM, Lukas Wunner wrote: > On Mon, Feb 12, 2018 at 01:58:32PM -0500, Alex Deucher wrote: >> On Mon, Feb 12, 2018 at 4:45 AM, Lukas Wunner wrote: >> > On Mon, Feb 12, 2018 at 09:03:26AM +, Mike Lothian wrote: >> >> On 12 February 2018

Re: [Nouveau] [Intel-gfx] [PATCH 0/5] Fix deadlock on runtime suspend in DRM drivers

2018-02-19 Thread Alex Deucher
On Mon, Feb 19, 2018 at 9:54 AM, Daniel Vetter wrote: > On Mon, Feb 19, 2018 at 03:47:42PM +0100, Lukas Wunner wrote: >> On Mon, Feb 19, 2018 at 03:05:53PM +0100, Daniel Vetter wrote: >> > On Mon, Feb 19, 2018 at 12:58:17PM +0100, Lukas Wunner wrote: >> > > On Mon, Feb 19, 2018 at 12:34:43PM +0100

Re: [Nouveau] [PATCH v3 3/8] drm/fb_helper: Introduce hotplug_suspend/resume()

2018-08-06 Thread Alex Deucher
On Mon, Aug 6, 2018 at 3:34 PM, Lukas Wunner wrote: > On Mon, Aug 06, 2018 at 03:15:31PM -0400, Lyude Paul wrote: >> You did mention in the review of one of my other patches that we should avoid >> disabling polling during runtime suspend, and you're definitely right. I feel >> a bit silly for not

Re: [Nouveau] [PATCH 0/5] drm/nouveau+amdgpu: add DP CEC-Tunneling-over-AUX

2018-08-16 Thread Alex Deucher
s of modesetting code, an older less featured version (amd/amdgpu/dce*.c) and the newer more featured code (amd/display/*). Newer asics (vega and raven) are only supported by DC. Older asics are supported by both. Eventually we'd like to remove the older modesetting code. I'm not rea

Re: [Nouveau] [PATCH (repost) 5/5] drm/amdgpu: add DisplayPort CEC-Tunneling-over-AUX support

2018-08-24 Thread Alex Deucher
> >> Signed-off-by: Hans Verkuil > >> Acked-by: Alex Deucher > >> --- > >> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 13 +++-- > >> .../drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 2 ++ > >> 2 files changed, 13

Re: [Nouveau] [PATCH 4/7] drm: Move the legacy kms disable_all helper to crtc helpers

2018-12-12 Thread Alex Deucher
On Tue, Dec 11, 2018 at 10:53 AM Sean Paul wrote: > > On Mon, Dec 10, 2018 at 10:58:20AM -0500, Alex Deucher wrote: > > On Mon, Dec 10, 2018 at 5:04 AM Daniel Vetter > > wrote: > > > > > > It's not a core function, and the matching atomic functions

Re: [Nouveau] [PATCH 4/7] drm: Move the legacy kms disable_all helper to crtc helpers

2018-12-12 Thread Alex Deucher
> > Cc: Sam Bobroff > Signed-off-by: Daniel Vetter > Cc: Maarten Lankhorst > Cc: Maxime Ripard > Cc: Sean Paul > Cc: David Airlie > Cc: Ben Skeggs > Cc: Alex Deucher > Cc: "Christian König" > Cc: "David (ChunMing) Zhou" > Cc: Rex Zhu

Re: [Nouveau] [PATCH] drm: Split out drm_probe_helper.h

2019-01-15 Thread Alex Deucher
> > I hope there's no other driver who'll blow up accidentally because > someone else is doing a drmP.h cleanup. Laurent maybe? > > Jani, ack on this? > -Daniel amdgpu and radeon: Acked-by: Alex Deucher ___ Nouveau mailing list Nouveau@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/nouveau

Re: [Nouveau] [PATCH] drm: Mark expected switch fall-throughs

2019-02-15 Thread Alex Deucher
On Fri, Feb 15, 2019 at 11:08 AM Gustavo A. R. Silva wrote: > > In preparation to enabling -Wimplicit-fallthrough, mark switch > cases where we are expecting to fall through. > > Warning level 3 was used: -Wimplicit-fallthrough=3 > > Notice that, in some cases, the code comment is modified > in ac

Re: [Nouveau] [PATCH] drm/nouveau/agp: add a quirk list to limit agp modes

2013-10-29 Thread Alex Deucher
On Sun, Oct 27, 2013 at 11:01 PM, Robert Hancock wrote: > On 10/27/2013 09:54 AM, Ilia Mirkin wrote: >> >> Certain combinations of hardware can't actually support the maximum >> detected speed. Add a quirk list that lists pairs of hostbridge/chip pci >> ids and the mode that they should work with.

Re: [Nouveau] [Mesa-dev] gallium state tracker calls calloc for 0 sizes arrays ?

2015-08-27 Thread Alex Deucher
On Thu, Aug 27, 2015 at 1:55 PM, Hans de Goede wrote: > Hi, > > On 27-08-15 15:46, Marek Olšák wrote: >> >> On Thu, Aug 27, 2015 at 3:09 PM, Hans de Goede >> wrote: >>> >>> Hi All, >>> >>> While debugging: https://bugzilla.redhat.com/show_bug.cgi?id=1008089 >>> >>> I made a apitrace recording of

Re: [Nouveau] AGP cards in PCI mode (fake slots like AGPro, AGP Express, AGI, AGX, XGP)

2015-09-13 Thread Alex Deucher
On Sun, Sep 13, 2015 at 2:57 PM, Ondrej Zary wrote: > Hello, > I have a PC Chips A31G board with AGPro slot and found that nouveau does not > work properly with it. Console works but reverts to software mode, X11 hangs > with mouse cursor only. > > The slot is physically AGP 1.5V but is wired to P

Re: [Nouveau] [PATCH v2 00/15] Runtime pm ref leak bonanza

2016-06-14 Thread Alex Deucher
h I think this makes much more sense. Please poke amd/nouveau folks for > reviews/acks, then I can merge. The amdgpu, radeon, and drm patches are: Acked-by: Alex Deucher > -Daniel > >> >> To ease reviewing, I've pushed this series to GitHub: >> https://github.com/l1k

Re: [Nouveau] [PATCH v3 0/4] nouveau RPM fixes for Optimus (final)

2016-07-15 Thread Alex Deucher
On Fri, Jul 15, 2016 at 12:10 PM, Ilia Mirkin wrote: > On Fri, Jul 15, 2016 at 9:12 AM, Peter Wu wrote: >> Hi, >> >> Here are two patches to fix an issue reported on kernel bugzilla (infinite >> loop >> due to unchecked function) and a more important fix to fix hanging Optimus >> machines when r

Re: [Nouveau] [PATCH v3 0/4] nouveau RPM fixes for Optimus (final)

2016-07-15 Thread Alex Deucher
On Fri, Jul 15, 2016 at 12:31 PM, Ilia Mirkin wrote: > On Fri, Jul 15, 2016 at 12:27 PM, Alex Deucher wrote: >> On Fri, Jul 15, 2016 at 12:10 PM, Ilia Mirkin wrote: >>> On Fri, Jul 15, 2016 at 9:12 AM, Peter Wu wrote: >>>> Hi, >>>> >>>> H

Re: [Nouveau] [PATCH v2] drm/nouveau/acpi: fix check for power resources support

2016-11-01 Thread Alex Deucher
On Tue, Nov 1, 2016 at 12:55 AM, Dave Airlie wrote: > On 1 November 2016 at 08:48, Peter Wu wrote: >> Check whether the kernel really supports power resources for a device, >> otherwise the power might not be removed when the device is runtime >> suspended (DSM should still work in these cases wh

Re: [Nouveau] [PATCH v2] drm/nouveau/acpi: fix check for power resources support

2016-11-01 Thread Alex Deucher
On Tue, Nov 1, 2016 at 3:00 PM, Peter Wu wrote: > On Tue, Nov 01, 2016 at 09:24:23AM -0400, Alex Deucher wrote: >> On Tue, Nov 1, 2016 at 12:55 AM, Dave Airlie wrote: >> > On 1 November 2016 at 08:48, Peter Wu wrote: >> >> Check whether the kernel really support

Re: [Nouveau] [PATCH v2 2/2] drm: Get atomic property value even if DRIVER_ATOMIC is not set

2017-01-03 Thread Alex Deucher
On Wed, Dec 21, 2016 at 3:12 PM, Dhinakaran Pandiyan wrote: > i915 does not set DRIVER_ATOMIC by default yet but uses atomic_check and > atomic_commit. drm_object_property_get_value() does not read the correct > value of atomic properties if DRIVER_ATOMIC is not set. Checking whether > the driver

Re: [Nouveau] [PATCH v4 1/3] drm/atomic: Save flip flags in drm_crtct_state

2017-02-02 Thread Alex Deucher
On Wed, Feb 1, 2017 at 12:03 PM, Andrey Grodzovsky wrote: > Allows using atomic flip helpers for drivers > using ASYNC flip. > Remove ASYNC_FLIP restriction in helpers and > caches the page flip flags in drm_crtc_state > to be used in the low level drivers. > > v2: > Resending the patch since the

Re: [Nouveau] [PATCH v4 0/3] Allow ASYNC flip with atomic helpers.

2017-02-02 Thread Alex Deucher
> drm/atomic: Save flip flags in drm_crtct_state > drm/nouveau/kms/nv50: Switch to using atomic helper for flip. > drm/amd/display: Switch to using atomic_helper for flip. A few comments on patch 1. WIth those addressed the series is: Reviewed-by: Alex Deucher >

Re: [Nouveau] [PATCH v5 0/3] Allow ASYNC flip with atomic helpers.

2017-02-03 Thread Alex Deucher
break compilation. > > v3: > Following Daniel's comments, save flip flags in crtc_state instead of > plane_state. > > v4: > Lauren's comment, reset flp flags before using again. > Harry's comment, fix identation in amd/display. > > v5: > Rename the f

Re: [Nouveau] [PATCH v2 09/17] drm/radeon: use common fence implementation for fences

2014-07-10 Thread Alex Deucher
On Wed, Jul 9, 2014 at 9:23 AM, Maarten Lankhorst wrote: > op 09-07-14 14:57, Deucher, Alexander schreef: >>> >>> +static const char *radeon_fence_get_timeline_name(struct fence *f) >>> +{ >>> +struct radeon_fence *fence = to_radeon_fence(f); >>> +switch (fence->ring) { >>> +case RADE

Re: [Nouveau] [PATCH 09/17] drm/radeon: use common fence implementation for fences

2014-07-22 Thread Alex Deucher
On Tue, Jul 22, 2014 at 11:19 AM, Daniel Vetter wrote: > On Tue, Jul 22, 2014 at 4:39 PM, Christian König > wrote: >> Am 22.07.2014 16:27, schrieb Maarten Lankhorst: >> >>> op 22-07-14 16:24, Christian König schreef: > > No, you really shouldn't be doing much in the check anyway, it's mea

Re: [Nouveau] [PATCH drm-next 00/14] [RFC] DRM GPUVA Manager & Nouveau VM_BIND UAPI

2023-01-18 Thread Alex Deucher
On Wed, Jan 18, 2023 at 11:19 AM Danilo Krummrich wrote: > > On 1/18/23 16:37, Christian König wrote: > > Am 18.01.23 um 16:34 schrieb Danilo Krummrich: > >> Hi Christian, > >> > >> On 1/18/23 09:53, Christian König wrote: > >>> Am 18.01.23 um 07:12 schrieb Danilo Krummrich: > This patch seri

Re: [Nouveau] [PATCH drm-next 00/14] [RFC] DRM GPUVA Manager & Nouveau VM_BIND UAPI

2023-01-18 Thread Alex Deucher
On Wed, Jan 18, 2023 at 11:50 AM Danilo Krummrich wrote: > > > > On 1/18/23 17:30, Alex Deucher wrote: > > On Wed, Jan 18, 2023 at 11:19 AM Danilo Krummrich wrote: > >> > >> On 1/18/23 16:37, Christian König wrote: > >>> Am 18.01.23 um 16:

Re: [Nouveau] [PATCH v7 2/8] PCI/VGA: Deal only with VGA class devices

2023-06-15 Thread Alex Deucher
On Wed, Jun 14, 2023 at 6:50 AM Sui Jingfeng wrote: > > Hi, > > On 2023/6/13 11:01, Sui Jingfeng wrote: > > From: Sui Jingfeng > > > > Deal only with the VGA devcie(pdev->class == 0x0300), so replace the > > pci_get_subsys() function with pci_get_class(). Filter the non-PCI display > > device(pde

Re: [Nouveau] [PATCH v7 2/8] PCI/VGA: Deal only with VGA class devices

2023-06-16 Thread Alex Deucher
On Fri, Jun 16, 2023 at 3:11 AM Sui Jingfeng wrote: > > Hi, > > On 2023/6/16 05:11, Alex Deucher wrote: > > On Wed, Jun 14, 2023 at 6:50 AM Sui Jingfeng > > wrote: > >> Hi, > >> > >> On 2023/6/13 11:01, Sui Jingfeng wrote: > >>> Fro

  1   2   >