Re: [Nouveau] [RFC PATCH 00/13] SVM (share virtual memory) with HMM in nouveau

2018-03-23 Thread Felix Kuehling
On 2018-03-13 10:28 AM, Jerome Glisse wrote: > On Mon, Mar 12, 2018 at 02:28:42PM -0400, Felix Kuehling wrote: >> On 2018-03-10 10:01 AM, Christian König wrote: >>>> To accomodate those we need to >>>> create a "hole" inside the process address space. Thi

Re: [Nouveau] [RFC PATCH 00/13] SVM (share virtual memory) with HMM in nouveau

2018-03-23 Thread Felix Kuehling
On 2018-03-10 10:01 AM, Christian König wrote: >> To accomodate those we need to >> create a "hole" inside the process address space. This patchset have >> a hack for that (patch 13 HACK FOR HMM AREA), it reserves a range of >> device file offset so that process can mmap this range with PROT_NONE

Re: [Nouveau] [PATCH hmm 5/5] mm/hmm: remove the customizable pfn format from hmm_range_fault

2020-04-22 Thread Felix Kuehling
t sweeps over its pfns array a couple of times anyhow. > > Signed-off-by: Jason Gunthorpe > Signed-off-by: Christoph Hellwig Hi Jason, I pointed out a typo in the documentation inline. Other than that, the series is Acked-by: Felix Kuehling I'll try to build it and run so

Re: [Nouveau] [PATCH 3/8] drm/amdgpu: Implement mmap as GEM object function

2021-04-06 Thread Felix Kuehling
Am 2021-04-06 um 9:04 a.m. schrieb Christian König: > Am 06.04.21 um 14:52 schrieb Thomas Zimmermann: >> Hi >> >> Am 06.04.21 um 14:42 schrieb Christian König: >>> Hi Thomas, >>> >>> Am 06.04.21 um 13:55 schrieb Thomas Zimmermann: Hi Am 06.04.21 um 12:56 schrieb Christian König:

Re: [Nouveau] [PATCH 3/8] drm/amdgpu: Implement mmap as GEM object function

2021-04-06 Thread Felix Kuehling
Am 2021-04-06 um 6:38 a.m. schrieb Thomas Zimmermann: > Hi > > Am 06.04.21 um 11:35 schrieb Christian König: >> Am 06.04.21 um 11:08 schrieb Thomas Zimmermann: >>> Moving the driver-specific mmap code into a GEM object function allows >>> for using DRM helpers for various mmap callbacks. >>> >>>

Re: [Nouveau] [PATCH 3/8] drm/amdgpu: Implement mmap as GEM object function

2021-04-07 Thread Felix Kuehling
On 2021-04-07 7:25 a.m., Christian König wrote: +    /* + * Don't verify access for KFD BOs. They don't have a GEM + * object associated with them. + */ +    if (bo->kfd_bo) +    goto out; Who does the access verification now? This is somewhat confusing. I took this check

Re: [Nouveau] [PATCH 3/8] drm/amdgpu: Implement mmap as GEM object function

2021-04-07 Thread Felix Kuehling
On 2021-04-07 3:34 p.m., Felix Kuehling wrote: On 2021-04-07 7:25 a.m., Christian König wrote: +    /* + * Don't verify access for KFD BOs. They don't have a GEM + * object associated with them. + */ +    if (bo->kfd_bo) +    goto out; Who does the access verification

Re: [Nouveau] [PATCH v3 5/7] drm/vmwgfx: Inline ttm_bo_mmap() into vmwgfx driver

2021-04-20 Thread Felix Kuehling
Am 2021-04-20 um 4:51 a.m. schrieb Daniel Vetter: >>> Whole series is Reviewed-by: Christian König >> Thanks a lot. If I'm not mistaken, the patches at [1] need to go in first. >> So it could take a a bit until this lands. >> >> Otherwise, this series could go through the same tree as [1] if

Re: [Nouveau] [PATCH 3/8] drm/amdgpu: Implement mmap as GEM object function

2021-04-14 Thread Felix Kuehling
Am 2021-04-14 um 3:44 a.m. schrieb Thomas Zimmermann: > Hi > > Am 07.04.21 um 21:49 schrieb Felix Kuehling: >> On 2021-04-07 3:34 p.m., Felix Kuehling wrote: >>> On 2021-04-07 7:25 a.m., Christian König wrote: >>>>>>>> +    /* >>>>>

Re: [Nouveau] [PATCH] mm/migrate.c: Remove MIGRATE_PFN_LOCKED

2021-10-26 Thread Felix Kuehling
t; Signed-off-by: Alistair Popple It makes sense to me. Do you have any empirical data on how much more likely migrations are going to fail with this change due to contested page locks? Either way, the patch is Acked-by: Felix Kuehling > --- > Documentation/vm/hmm.rst | 2 +

Re: [Nouveau] [PATCH 6/7] nouveau/dmem: Evict device private memory during release

2022-09-26 Thread Felix Kuehling
Signed-off-by: Philip Yang Reviewed-by: Felix Kuehling Signed-off-by: Alex Deucher Furthermore, I guess we are assuming that nobody is using the GPU when the module is unloaded. As long as any processes have /dev/kfd open, you won't be able to unload the module (except by force-unload).

Re: [Nouveau] [PATCH v2 1/8] mm/memory.c: Fix race when faulting a device private page

2022-09-29 Thread Felix Kuehling
cks, so we won't have to deal with it in all the migration code. Regards,   Felix Signed-off-by: Alistair Popple Cc: Jason Gunthorpe Cc: John Hubbard Cc: Ralph Campbell Cc: Michael Ellerman Cc: Felix Kuehling Cc: Lyude Paul --- arch/powerpc/kvm/book3s_hv_uvmem.c |

Re: [Nouveau] [PATCH v2 2/8] mm: Free device private pages have zero refcount

2022-09-29 Thread Felix Kuehling
l code can then safely use kernel functions such as get_page_unless_zero(). Signed-off-by: Alistair Popple Acked-by: Felix Kuehling Cc: Jason Gunthorpe Cc: Michael Ellerman Cc: Felix Kuehling Cc: Alex Deucher Cc: Christian König Cc: Ben Skeggs Cc: Lyude Paul Cc: Ralph Campbell Cc: Alex Sierra

Re: [Nouveau] [PATCH v2 1/8] mm/memory.c: Fix race when faulting a device private page

2022-10-03 Thread Felix Kuehling
Am 2022-10-02 um 20:53 schrieb Alistair Popple: Felix Kuehling writes: On 2022-09-28 08:01, Alistair Popple wrote: When the CPU tries to access a device private page the migrate_to_ram() callback associated with the pgmap for the page is called. However no reference is taken on the faulting