Re: [Nouveau] [PATCH 2/2] g3dvl: disable iDCT for now

2011-07-28 Thread Maarten Lankhorst
Also nacking nouveau almost has xvmc acceleration Op 28 jul. 2011 00:55 schreef "Ben Skeggs" het volgende: > On Wed, 2011-07-27 at 14:08 -0500, Bryan Cain wrote: >> On 07/27/2011 02:42 AM, Ben Skeggs wrote: >> > On Wed, 2011-07-20 at 13:48 -0500, Bryan Cain wrote: >> >> --- >> >> src/vl_hwmc.c |

[Nouveau] [PATCH] nouveau: Add driver entry for vdpau

2011-08-16 Thread Maarten Lankhorst
Signed-off-by: Maarten Lankhorst --- diff --git a/src/nouveau_dri2.c b/src/nouveau_dri2.c index 1a68ed3..e5dfce0 100644 --- a/src/nouveau_dri2.c +++ b/src/nouveau_dri2.c @@ -429,12 +429,18 @@ nouveau_dri2_init(ScreenPtr pScreen) ScrnInfoPtr pScrn = xf86Screens[pScreen->my

[Nouveau] [PATCH v2] dri2: Add vdpau driver name entry

2011-10-08 Thread Maarten Lankhorst
libvdpau has a driver loading mechanism that looks for a dri2 driver first before falling back to nvidia, so lets use that. --- v2: Keep compatibility entry for driverName for older versions of Xorg, and add vdpau for nouveau_vieux. I doubt it will ever happen, but it's harmless to add. There is

[Nouveau] [PATCH to drm/nouveau] nouveau: Mark nouveau subchannel unbound nouveau_grobj_free

2011-11-24 Thread Maarten Lankhorst
Valgrind throws warns about a user-after-free if you try to bind a new subchannel after the old one in that slot was freed, so remove it from the channel list. Signed-off-by: Maarten Lankhorst --- a/nouveau/nouveau_grobj.c +++ b/nouveau/nouveau_grobj.c @@ -100,12 +99,13 @@ nouveau_grobj_free

Re: [Nouveau] [PATCH] drm/nvd0/disp: mask off high 16 bit of negative cursor x-coordinate

2012-07-26 Thread Maarten Lankhorst
;index); > > - evo_piow(crtc->dev, ch, 0x0084, (y << 16) | x); > + evo_piow(crtc->dev, ch, 0x0084, (y << 16) | (x & 0x)); > evo_piow(crtc->dev, ch, 0x0080, 0x); > return 0; > } Signed-off-by: Ma

[Nouveau] [PATCH] nouveau: add voltage workaround for buggy bioses

2012-07-27 Thread Maarten Lankhorst
This makes all performance modes on c0 be detected properly, since all voltages were aligned to step_uv, but the reported voltages were offset relative to it, so no voltage was ever found. Signed-off-by: Maarten Lankhorst --- --- drivers/gpu/drm/nouveau/nouveau_drv.h |1 + drivers/gpu/drm

[Nouveau] [PATCH] nouveau: apply storage type to gart objects

2012-07-27 Thread Maarten Lankhorst
If you want to access gart as linear, don't specify a non-zero storage type. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/nouveau/nouveau_mem.c |9 + 1 file changed, 9 insertions(+) diff --git a/drivers/gpu/drm/nouveau/nouveau_mem.c b/drivers/gpu/drm/nouveau/nouveau_

[Nouveau] [PATCH 1/3] nouveau: add software methods to c0

2012-07-27 Thread Maarten Lankhorst
Handle the INVALID_CLASS error that happens when you try to execute software commands. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/nouveau/nouveau_software.h |1 + drivers/gpu/drm/nouveau/nvc0_graph.c |9 ++--- drivers/gpu/drm/nouveau/nvc0_software.c| 21

[Nouveau] [PATCH 2/3] nouveau: add software methods to e0

2012-07-27 Thread Maarten Lankhorst
In this case, no class is available but the bind methods is sent too, so use it to keep track of what channel is 'bound' and find the software class id from it. Signed-off-by: Maarten Lankhorst --- calim can I get a tested-by? drivers/gpu/drm/nouveau/nouveau_software.h |1 + d

[Nouveau] [PATCH 3/3] nouveau: add vblank methods on newer cards

2012-07-27 Thread Maarten Lankhorst
Allow the software channel to be created now, since methods for vblanking have been implemented. The instmem flush seems to be needed on fermi to prevent a race, but I enabled it on earlier cards too since they seem to be susceptible to the same race. Signed-off-by: Maarten Lankhorst

[Nouveau] [PATCH] nvc0: Add and enable vblank support

2012-07-27 Thread Maarten Lankhorst
Based on the original patch by Christoph Bumiller, but since it depends on kernel support patched I cannot push it yet. The changes are that I enable vblank by default, and offset takes OFFSET_HIGH/LOW instead of something relative to notifier_bo. Signed-off-by: Maarten Lankhorst --- diff

[Nouveau] [PATCH] nouveau: fixup scanout enable in nvc0_pm

2012-07-30 Thread Maarten Lankhorst
Fixes screen being black after changing performance level. Signed-off-by: Maarten Lankhorst Cc: sta...@vger.kernel.org [3.5+] --- diff --git a/drivers/gpu/drm/nouveau/nvc0_pm.c b/drivers/gpu/drm/nouveau/nvc0_pm.c index 7c95c44..4e712b1 100644 --- a/drivers/gpu/drm/nouveau/nvc0_pm.c +++ b

[Nouveau] [ANNOUNCE] xf86-video-nouveau 1.0.2

2012-09-12 Thread Maarten Lankhorst
add platform bus support nouveau/exa: add support for shared pixmaps. nouveau: add pixmap tracking/updating support. nouveau/dri2: add support for DRI2 offload nouveau: enable provider/capabilities Maarten Lankhorst (1): bump version to 1.0.2 h

Re: [Nouveau] [PATCH] drm/nouveau: add default debug level override

2012-09-13 Thread Maarten Lankhorst
Hey, Op 13-09-12 00:50, Marcin Slusarz schreef: > Useful when we don't know which subsystem is failing. > > Signed-off-by: Marcin Slusarz > --- > drivers/gpu/drm/nouveau/core/core/option.c | 9 - > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/nouveau/co

[Nouveau] [PATCH 1/3] drm/nouveau: add reservation to nouveau_gem_ioctl_cpu_prep

2012-10-12 Thread Maarten Lankhorst
Apart from some code inside ttm itself and nouveau_bo_vma_del, this is the only place where ttm_bo_wait is used without a reservation. Fix this so we can remove the fence_lock later on. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/nouveau/nouveau_gem.c | 22 ++ 1

[Nouveau] [PATCH 2/3] drm/nouveau: add reservation to nouveau_bo_vma_del

2012-10-12 Thread Maarten Lankhorst
Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/nouveau/nouveau_bo.c | 16 drivers/gpu/drm/nouveau/nouveau_bo.h |1 + drivers/gpu/drm/nouveau/nouveau_gem.c |2 +- 3 files changed, 18 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_bo.c

[Nouveau] [PATCH 3/3, resend with fixed to field] drm/nouveau: unpin buffers before releasing to prevent lockdep warnings

2012-10-12 Thread Maarten Lankhorst
This will otherwise cause a lockdep splat, so warn when nouveau forgets to unpin a buffer, and fix up the ones I've hit. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/nouveau/nouveau_abi16.c |1 + drivers/gpu/drm/nouveau/nouveau_fbcon.c |1 + drivers/gpu/drm/nouveau/nouveau_

Re: [Nouveau] [PATCH] dri2: Fix potential race and crash for swap at next vblank.

2012-10-22 Thread Maarten Lankhorst
Op 09-10-12 09:06, Mario Kleiner schreef: > This fixes a potential race + crash that wasn't properly > handled by commit 248de8cdbd6d0bc062633b49896fa4791148cd3b > and happened at least on one users machine. > > That commit wrongly assumed no special action would be needed > for swaps at next vblan

[Nouveau] [ANNOUNCE] xf86-video-nouveau 1.0.3

2012-10-24 Thread Maarten Lankhorst
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Adam Jackson (1): Remove mibstore.h Ben Skeggs (1): shadowfb: fix segfault due to reading outside of shadow buffer Dave Airlie (1): nouveau/dri2: fix pixmap/window offset calcs. Maarten Lankhorst (6): nvc0/exa: make solid

Re: [Nouveau] Fix for vblank on nvc0

2012-11-06 Thread Maarten Lankhorst
Op 06-11-12 15:48, Kelly Doran schreef: > The vblank on nvc0 was not working correctly and would freeze X, I managed > to track it down and fix it with some help from m.b.lankhorst, see > https://bugs.freedesktop.org/show_bug.cgi?id=56692 for details. > Reviewed-by: Maarten L

[Nouveau] [PATCH] nouveau: fix acpi edid retrieval

2012-11-08 Thread Maarten Lankhorst
Commit c0077061e7ea accidentally inverted the logic for nouveau_acpi_edid, causing it to only show a connector as connected when the edid could not be retrieved with acpi. Signed-off-by: Maarten Lankhorst --- diff --git a/drivers/gpu/drm/nouveau/nouveau_connector.c b/drivers/gpu/drm/nouveau

Re: [Nouveau] [PATCH] nouveau: fix acpi edid retrieval

2012-11-08 Thread Maarten Lankhorst
Op 08-11-12 21:53, Paul Menzel schreef: > Dear Maarten, > > > thanks for the patch. > > > Am Donnerstag, den 08.11.2012, 17:19 +0100 schrieb Maarten Lankhorst: >> Commit c0077061e7ea > Please paste the commit summary for people not having a Git tree at > hand.

Re: [Nouveau] Fix for vblank on nvc0

2012-11-11 Thread Maarten Lankhorst
Op 11-11-12 19:35, Marcin Slusarz schreef: > On Sun, Nov 11, 2012 at 07:26:17PM +0100, Marcin Slusarz wrote: >> On Tue, Nov 06, 2012 at 07:30:00PM +0100, Maarten Lankhorst wrote: >>> >>> Op 06-11-12 15:48, Kelly Doran schreef: >>>> The vblank on nvc0 was not

Re: [Nouveau] Fix for vblank on nvc0

2012-11-12 Thread Maarten Lankhorst
Op 12-11-12 22:30, Kelly Doran schreef: > I had Sven test this patch... he said it works. I think chipset > number test was executing code that we thought was only either 0x50 or > 0xc0, but was actually more specific with things like 0x92. > Oh right vblank is busted anyway... needs to be nv_devi

[Nouveau] [PATCH] drm/nouveau: add voltage workaround for buggy vbioses

2012-11-16 Thread Maarten Lankhorst
Required to find all performance levels on my nvc0. Signed-off-by: Maarten Lankhorst --- diff --git a/drivers/gpu/drm/nouveau/nouveau_perf.c b/drivers/gpu/drm/nouveau/nouveau_perf.c index 4fe883c..624cbd1 100644 --- a/drivers/gpu/drm/nouveau/nouveau_perf.c +++ b/drivers/gpu/drm/nouveau

[Nouveau] [PATCH] drm/nouveau: add missing pll_calc calls

2012-11-16 Thread Maarten Lankhorst
Fixes a null pointer dereference when reclocking on my fermi. Signed-off-by: Maarten Lankhorst --- diff --git a/drivers/gpu/drm/nouveau/core/include/subdev/clock.h b/drivers/gpu/drm/nouveau/core/include/subdev/clock.h index 39e73b9..41b7a6a 100644 --- a/drivers/gpu/drm/nouveau/core/include

[Nouveau] [PATCH] drm/nouveau: use the correct fence implementation for nv50

2012-11-21 Thread Maarten Lankhorst
Only compile time tested, noticed nv50_fence_create was never used, so fix this. This will probably fix vblank on nv50 cards. Hopefully this is still in time for 3.7 final release. Signed-off-by: Maarten Lankhorst --- diff --git a/drivers/gpu/drm/nouveau/nouveau_drm.c b/drivers/gpu/drm

[Nouveau] [PATCH] drm/nouveau: fix takedown in move_notify

2012-11-21 Thread Maarten Lankhorst
big issue however. If we choose to do so does allow us to use ttm's delayed destruction mechanism to unmap vm after object is idle, resulting in ioread32 no longer taking up 30% of cpu in Team Fortress 2 if I don't do the vma unmap in nouveau_gem_object_close. Signed-off-by: Maarten Lankho

Re: [Nouveau] [PATCH] drm/nouveau: fix takedown in move_notify

2012-11-21 Thread Maarten Lankhorst
Op 21-11-12 14:15, Maarten Lankhorst schreef: > With this fix, nouveau_gem_object_close can be safely changed to a noop, > forcing the vm bindings to be removed when the original object is. This > is not done in this patch since it may lead to the object staying mapped > in the vm spa

[Nouveau] [resend PATCH] drm/nouveau: unpin buffers before releasing to prevent lockdep warnings

2012-11-21 Thread Maarten Lankhorst
This will otherwise cause a lockdep splat if reservations were a real lock type, so warn when nouveau forgets to unpin a buffer, and fix up the ones I've hit. Signed-off-by: Maarten Lankhorst --- diff --git a/drivers/gpu/drm/nouveau/nouveau_abi16.c b/drivers/gpu/drm/nouveau/nouveau_ab

Re: [Nouveau] [RFC PATCH] drm/nouveau: report channel owner in error messages

2012-12-06 Thread Maarten Lankhorst
Op 05-12-12 23:56, Marcin Slusarz schreef: > Full piglit run with this patch: > http://people.freedesktop.org/~mslusarz/chan_owners.txt > > This patch covers only a small subset of all error messages, so: > Not-yet-signed-off-by: Marcin Slusarz > > Comments? Ideas? > > (This commit depends on this

Re: [Nouveau] [PATCH] drm/nouveau: fix takedown in move_notify

2012-12-10 Thread Maarten Lankhorst
Op 10-12-12 17:39, Emil Velikov schreef: > On 21/11/12 13:15, Maarten Lankhorst wrote: >> move_notify is called by ttm after the the object is idle and about >> to be destroyed. Clean up the vm list properly in that case. >> >> This is not a problem right now, since

[Nouveau] nouveau lockdep splat on init

2013-01-15 Thread Maarten Lankhorst
Testing airlied's current drm-fixes branch gives me this, with lockdep enabled: [ 40.864179] = [ 40.864179] [ INFO: possible recursive locking detected ] [ 40.864179] 3.8.0-rc3-patser+ #915 Tainted: GW [ 40.864179]

[Nouveau] [PATCH] drm/nouveau/mc: complain loudly if we can't call a interrupt handler

2013-01-17 Thread Maarten Lankhorst
I noticed that bsp, vp and ppp had no interrupt handler after investigating why 15% of my cpu time went to interrupts. nouveau was silent about it, but it should be an error since we have no way of acking in that case. Signed-off-by: Maarten Lankhorst --- fwiw, the interrupt was 10, the

Re: [Nouveau] [PATCH] drm/nouveau: add lockdep annotations

2013-02-04 Thread Maarten Lankhorst
p to put DRM > client lock in a separate class. Can you copy paste a typical lockdep splat for this? Also this should be a separate patch. :-) > Reported-by: Arend van Spriel > Reported-by: Peter Hurley > Reported-by: Maarten Lankhorst > Reported-by: Daniel J Blueman > Signe

[Nouveau] [PATCH] drm/nouveau: fix lockdep splat in display

2013-02-05 Thread Maarten Lankhorst
0 [nouveau] [] do_one_initcall+0x11a/0x170 [] load_module+0xe84/0x1470 [] ? in_lock_functions+0x20/0x20 [] ? trace_hardirqs_on_thunk+0x3a/0x3f [] sys_init_module+0xb7/0xe0 [] system_call_fastpath+0x1a/0x1f Reported-by: Arend van Spriel Reported-by: Peter Hurley Reported-by: Daniel J Blueman Sig

Re: [Nouveau] [PATCH] drm/nouveau: add lockdep annotations

2013-02-07 Thread Maarten Lankhorst
Hey, Op 05-02-13 21:52, Ben Skeggs schreef: > On Mon, Feb 04, 2013 at 10:59:28PM +0100, Maarten Lankhorst wrote: >> Op 04-02-13 22:30, Marcin Slusarz schreef: >>> 1) Lockdep thinks all nouveau subdevs belong to the same class and can be >>> locked in arbitrary order,

[Nouveau] [PATCH] drm/nouveau: fix suspend bug in nvc0 fence implementation

2013-02-19 Thread Maarten Lankhorst
Everywhere else the constant is multiplied by 16/4, so it looks like nvc0_fence_suspend/resume is buggy here. Signed-off-by: Maarten Lankhorst Cc: sta...@vger.kernel.org [3.7+] --- diff --git a/drivers/gpu/drm/nouveau/nvc0_fence.c b/drivers/gpu/drm/nouveau/nvc0_fence.c index 85a0e78..4f46d8b

[Nouveau] [PATCH] drm/nouveau: fix null pointer deref on init

2013-03-05 Thread Maarten Lankhorst
4] RIP [] nv50_crtc_destroy+0x29/0x110 [nouveau] [ 30.134434] RSP [ 30.134436] CR2: [ 30.134692] ---[ end trace 4678de513b8e8da0 ]--- Signed-off-by: Maarten Lankhorst --- diff --git a/drivers/gpu/drm/nouveau/nv50_display.c b/drivers/gpu/drm/nouveau/nv50_display.c index a4d2d3a..b

[Nouveau] [PATCH] drm/nouveau: fix regression in vblanking

2013-03-05 Thread Maarten Lankhorst
nv50_vblank_enable/disable got switched from NV50_PDISPLAY_INTR_EN_1_VBLANK_CRTC_0 (4) << head to 1 << head, which is wrong. 4 << head is the correct value. Fixes regression with vblanking since 1d7c71a3e2f77 "drm/nouveau/disp: port vblank handling to event interface&q

Re: [Nouveau] vdpau problems and logging

2013-03-12 Thread Maarten Lankhorst
Hey, \ Op 12-03-13 20:18, Steven Ward schreef: > Dear all, > I'm writing about setup vdpau firmware with the nouveau > driver according to this page: > > http://nouveau.freedesktop.org/wiki/NVC0_Firmware I have installed the > nvidia-313 binary drver to attempt to extract the f

Re: [Nouveau] [PATCH] drm/nouveau: Drop mutex_lock_nested for atomic

2020-08-03 Thread Maarten Lankhorst
s in page flipping paths > > due to > > commit b580c9e2b7ba5030a795aa2fb73b796523d65a78 > Author: Maarten Lankhorst > Date: Thu Jun 27 13:48:18 2013 +0200 > > drm/nouveau: make flipping lockdep safe > > Signed-off-by: Daniel Vetter > Cc: Maarten Lankhorst > Cc: Ben Skeggs > Cc: Dave

Re: [Nouveau] [PATCH 2/3] drm/nouveau: slowpath for pushbuf ioctl

2019-11-05 Thread Maarten Lankhorst
ma_resv. >> >> Fix this by adding a slowpath for when we need relocations, and by >> pushing the writeback of the new presumed offsets to the very end. >> >> Aside from "it compiles" entirely untested unfortunately. >> >> Signed-off-by: Daniel

Re: [Nouveau] [PATCH 0/5] Fix deadlock on runtime suspend in DRM drivers

2018-02-14 Thread Maarten Lankhorst
Op 14-02-18 om 09:46 schreef Lukas Wunner: > Dear drm-misc maintainers, > > On Sun, Feb 11, 2018 at 10:38:28AM +0100, Lukas Wunner wrote: >> Fix a deadlock on hybrid graphics laptops that's been present since 2013: > This series has been reviewed, consent has been expressed by the most > interested

Re: [Nouveau] [PATCH 2/2] drm/atomic: Create and use __drm_atomic_helper_crtc_reset() everywhere

2018-11-15 Thread Maarten Lankhorst
Op 12-11-18 om 17:11 schreef Sean Paul: > On Mon, Nov 12, 2018 at 04:01:14PM +0100, Maarten Lankhorst wrote: >> We already have __drm_atomic_helper_connector_reset() and >> __drm_atomic_helper_plane_reset(), extend this to crtc as well. >> >> Most drivers already have a

[Nouveau] [PATCH 2/2] drm/atomic: Create and use __drm_atomic_helper_crtc_reset() everywhere

2018-11-15 Thread Maarten Lankhorst
: Maarten Lankhorst Cc: Harry Wentland Cc: Leo Li Cc: Alex Deucher Cc: "Christian König" Cc: "David (ChunMing) Zhou" Cc: David Airlie Cc: Liviu Dudau Cc: Brian Starkey Cc: Mali DP Maintainers Cc: Boris Brezillon Cc: Nicolas Ferre Cc: Alexandre Belloni Cc: Ludovic De

Re: [Nouveau] [PATCH] drm/fbdev: Make skip_vt_switch the default

2018-12-03 Thread Maarten Lankhorst
> > Thanks to Michel Dänzer for pointing this one out. Maybe just reload the gamma lut on resume for radeon, instead of relying on fbcon? Otherwise patch looks sane, would be nice if radeon was fixed instead of worked around. Reviewed-by: Maarten Lankhorst __

Re: [Nouveau] vdpau problems and logging

2013-03-14 Thread Maarten Lankhorst
Op 14-03-13 10:47, Steven Ward schreef: > Hi Maarten, > I'm sure I have downloaded and installed the latest > libvdpau firmware from git.. I will check the git repository for Mesa and > re-compile it again. I will invoke the git version of Mesa with "nvgl" when > I start the vid

[Nouveau] [PATCH] drm/nouveau: fix NULL ptr dereference from nv50_disp_intr()

2013-03-24 Thread Maarten Lankhorst
P value. RIP [<0001>] 0x0 RSP CR2: 0001 ---[ end trace 907323cb8ce6f301 ]--- Signed-off-by: Maarten Lankhorst diff --git a/drivers/gpu/drm/nouveau/nouveau_drm.c b/drivers/gpu/drm/nouveau/nouveau_drm.c index d109936..c95decf 100644 --- a/drivers/gpu/drm/nouveau/no

[Nouveau] [PATCH] drm/nouveau: fix handling empty channel list in ioctl's

2013-03-24 Thread Maarten Lankhorst
evice. Signed-off-by: Maarten Lankhorst Cc: sta...@vger.kernel.org [3.7+] --- diff --git a/drivers/gpu/drm/nouveau/nouveau_abi16.c b/drivers/gpu/drm/nouveau/nouveau_abi16.c index 3b6dc88..5eb3e0d 100644 --- a/drivers/gpu/drm/nouveau/nouveau_abi16.c +++ b/drivers/gpu/drm/nouveau/nouveau_abi16.c @@ -

[Nouveau] [PATCH] drm/nouveau: Ack interrupts for some fuc engines

2013-03-25 Thread Maarten Lankhorst
Fixes 100% cpu usage when the exit interrupt never got acked. Signed-off-by: Maarten Lankhorst --- diff --git a/drivers/gpu/drm/nouveau/core/core/falcon.c b/drivers/gpu/drm/nouveau/core/core/falcon.c index e05c157..b11c5f3 100644 --- a/drivers/gpu/drm/nouveau/core/core/falcon.c +++ b/drivers

Re: [Nouveau] [PATCH] drm/nouveau: Ack interrupts for some fuc engines

2013-03-25 Thread Maarten Lankhorst
Op 25-03-13 19:14, Marcin Slusarz schreef: > On Mon, Mar 25, 2013 at 10:22:37AM +0100, Maarten Lankhorst wrote: >> Fixes 100% cpu usage when the exit interrupt never got acked. >> >> Signed-off-by: Maarten Lankhorst >> --- >> diff --git a/drivers/gpu/drm/nouveau

Re: [Nouveau] [PATCH] drm/nouveau: Ack interrupts for some fuc engines

2013-03-26 Thread Maarten Lankhorst
Op 26-03-13 21:29, Marcin Slusarz schreef: > On Tue, Mar 26, 2013 at 07:29:24AM +0100, Maarten Lankhorst wrote: >> Op 25-03-13 19:14, Marcin Slusarz schreef: >>> On Mon, Mar 25, 2013 at 10:22:37AM +0100, Maarten Lankhorst wrote: >>>> Fixes 100% cpu usage when the

[Nouveau] [ANNOUNCE] xf86-video-nouveau 1.0.7

2013-03-27 Thread Maarten Lankhorst
58284cf32778d54cde139423450bc33360784503 nouveau: align shared buffers to 256 nouveau: make prime regression fix more robust. nouveau: fix build on older X servers nouveau: fix build against old servers (part 2) Maarten Lankhorst (2): Clean up some errors on closing. bump

[Nouveau] mesa vdpau regression with "dri2: Fix potential race and crash for swap at next vblank."

2013-03-28 Thread Maarten Lankhorst
Hey Mario, It seems that your ddx commit b4231dd715a8 is causing a regression when I use mplayer -vo vdpau rendering with mesa 9.1. It fails to start drawing here, leaving the mplayer screen black, I can make it recover usually by seeking or moving another window in front. When I revert the comm

Re: [Nouveau] mesa vdpau regression with "dri2: Fix potential race and crash for swap at next vblank."

2013-03-28 Thread Maarten Lankhorst
Op 28-03-13 12:00, Maarten Lankhorst schreef: > Hey Mario, > > It seems that your ddx commit b4231dd715a8 is causing a regression when I use > mplayer -vo vdpau rendering with mesa 9.1. > It fails to start drawing here, leaving the mplayer screen black, I can make > it

[Nouveau] [PATCH] drm/nouveau: wait for vblank on page flipping

2013-03-28 Thread Maarten Lankhorst
AGHHhhh! Signed-off-by: Maarten Lankhorst --- diff --git a/drivers/gpu/drm/nouveau/core/core/event.c b/drivers/gpu/drm/nouveau/core/core/event.c index 6d01e0f..f56bd56 100644 --- a/drivers/gpu/drm/nouveau/core/core

[Nouveau] [PATCH v2] drm/nouveau: wait for vblank on page flipping

2013-03-28 Thread Maarten Lankhorst
Signed-off-by: Maarten Lankhorst --- Oops, fixed to apply this time.. diff --git a/drivers/gpu/drm/nouveau/nouveau_display.c b/drivers/gpu/drm/nouveau/nouveau_display.c index 4610c3a..020542e 100644 --- a/drivers/gpu/drm/nouveau/nouveau_display.c +++ b/drivers/gpu/drm/nouveau/nouveau_display.c

[Nouveau] [PATCH] drm/nouveau: idle all channels before suspending

2013-04-08 Thread Maarten Lankhorst
Seems to make suspend slightly more reliable on my system. Cc: sta...@vger.kernel.org [3.7+] Signed-off-by: Maarten Lankhorst --- diff --git a/drivers/gpu/drm/nouveau/nouveau_drm.c b/drivers/gpu/drm/nouveau/nouveau_drm.c index b6bdc9f..5032c31 100644 --- a/drivers/gpu/drm/nouveau/nouveau_drm.c

Re: [Nouveau] [PATCH] drm/nouveau: idle all channels before suspending

2013-04-08 Thread Maarten Lankhorst
Op 09-04-13 01:14, Ben Skeggs schreef: > On Mon, Apr 8, 2013 at 10:04 PM, Maarten Lankhorst < > maarten.lankho...@canonical.com> wrote: > >> Seems to make suspend slightly more reliable on my system. >> > NACK. > > "Seems to", and "slightly"

Re: [Nouveau] [PATCH] drm/nouveau: fix vblank deadlock

2013-08-19 Thread Maarten Lankhorst
Hey, Op 19-08-13 20:12, Peter Hurley schreef: > On 08/12/2013 07:50 AM, Maarten Lankhorst wrote: >> This fixes a deadlock inversion when vblank is enabled/disabled by drm. >> &dev->vblank_time_lock is always taken when the vblank state is toggled, >> which caused a de

Re: [Nouveau] [PATCH] drm/nouveau: avoid null deref on bad arguments to nouveau_vma_getmap

2013-08-22 Thread Maarten Lankhorst
Op 22-08-13 02:10, Ilia Mirkin schreef: > The code expects non-VRAM mem nodes to have a pages list. If that's not > set, it will do a null deref down the line. Warn on that condition and > return an error. > > See https://bugs.freedesktop.org/show_bug.cgi?id=64774 > > Reported-by: Pasi Kärkkäinen

Re: [Nouveau] [PATCH] drm/nouveau: avoid null deref on bad arguments to nouveau_vma_getmap

2013-08-28 Thread Maarten Lankhorst
Op 28-08-13 08:29, Pasi Kärkkäinen schreef: > On Fri, Aug 23, 2013 at 11:20:42PM +0300, Pasi Kärkkäinen wrote: >> On Thu, Aug 22, 2013 at 09:12:40AM +0200, Maarten Lankhorst wrote: >>> Op 22-08-13 02:10, Ilia Mirkin schreef: >>>> The code expects non-VRAM mem nodes t

[Nouveau] [PATCH] drm/nv84-: write fence value on exit, and restore value on init.

2013-09-02 Thread Maarten Lankhorst
This increases the chance slightly that recovery from lockup can happen succesfully. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/nouveau/nv84_fence.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nv84_fence.c b/drivers/gpu/drm/nouveau

[Nouveau] [PATCH] drm/nouveau: fix command submission to use vmalloc for big allocations

2013-09-02 Thread Maarten Lankhorst
I was getting a order 4 allocation failure from kmalloc when testing some game after a few days uptime with some suspend/resumes. For big allocations vmalloc should be used instead. Also limit size more aggressively to 256 KiB. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/nouveau

[Nouveau] [PATCH] drm/nouveau: force alignment to 0x1000 for gpu objects

2013-09-02 Thread Maarten Lankhorst
There are a lot of places that allocate multiples of 1000, but do not set alignment correctly and still require this alignment implicitly or explicitly. --- drivers/gpu/drm/nouveau/core/core/gpuobj.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/nouveau/core/core/gpuo

[Nouveau] [PATCH] drm/nv50-: fix tiled memory layout checks

2013-09-02 Thread Maarten Lankhorst
nv50_bo_move_m2mf might copy to tiled gart, in which case linear copy is not appropriate. --- drivers/gpu/drm/nouveau/nouveau_bo.c | 42 1 file changed, 24 insertions(+), 18 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_bo.c b/drivers/gpu/drm/nou

[Nouveau] [PATCH] drm/nv50-: make dma-objects read-only where appropriate

2013-09-02 Thread Maarten Lankhorst
I don't see why the display engine would need write access to the entirety of vram, when read-only access is enough. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/nouveau/nv50_display.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/gp

Re: [Nouveau] [PATCH] drm/nouveau: avoid null deref on bad arguments to nouveau_vma_getmap

2013-09-03 Thread Maarten Lankhorst
Op 03-09-13 16:20, Pasi Kärkkäinen schreef: > On Wed, Aug 28, 2013 at 09:44:15AM +0200, Maarten Lankhorst wrote: >> Op 28-08-13 08:29, Pasi Kärkkäinen schreef: >>> On Fri, Aug 23, 2013 at 11:20:42PM +0300, Pasi Kärkkäinen wrote: >>>> On Thu, Aug 22, 2013 at 09:12

Re: [Nouveau] [PATCH] drm/nouveau: avoid null deref on bad arguments to nouveau_vma_getmap

2013-09-04 Thread Maarten Lankhorst
Op 04-09-13 05:41, Ben Skeggs schreef: > On Thu, Aug 22, 2013 at 5:12 PM, Maarten Lankhorst > wrote: >> Op 22-08-13 02:10, Ilia Mirkin schreef: >>> The code expects non-VRAM mem nodes to have a pages list. If that's not >>> set, it will do a null deref down t

Re: [Nouveau] [PATCH] drm/nouveau: force alignment to 0x1000 for gpu objects

2013-09-04 Thread Maarten Lankhorst
Op 04-09-13 05:34, Ben Skeggs schreef: > On Tue, Sep 3, 2013 at 12:31 AM, Maarten Lankhorst > wrote: >> There are a lot of places that allocate multiples of 1000, >> but do not set alignment correctly and still require this >> alignment implicitly or explicitly. > Th

Re: [Nouveau] [PATCH] drm/nouveau: fix command submission to use vmalloc for big allocations

2013-09-04 Thread Maarten Lankhorst
Op 04-09-13 05:31, Ben Skeggs schreef: > On Tue, Sep 3, 2013 at 12:31 AM, Maarten Lankhorst > wrote: >> I was getting a order 4 allocation failure from kmalloc when testing some >> game >> after a few days uptime with some suspend/resumes. For big allocations >

Re: [Nouveau] [PATCH] drm/nv84-: write fence value on exit, and restore value on init.

2013-09-04 Thread Maarten Lankhorst
Op 04-09-13 05:21, Ben Skeggs schreef: > On Tue, Sep 3, 2013 at 12:31 AM, Maarten Lankhorst > wrote: >> This increases the chance slightly that recovery from lockup can happen >> succesfully. > I'd *really* love to see proof of this. When channels die, all > out

Re: [Nouveau] [PATCH] drm/nouveau: do not move buffers when not needed

2013-09-04 Thread Maarten Lankhorst
Op 04-09-13 03:24, Ben Skeggs schreef: > On Mon, Jul 15, 2013 at 6:39 PM, Maarten Lankhorst > wrote: >> Op 15-07-13 08:05, Ben Skeggs schreef: >>> On Fri, Jul 12, 2013 at 10:45 PM, Maarten Lankhorst >>> wrote: >>>> I have no idea what this bogus

Re: [Nouveau] offer to help, DCB

2013-09-24 Thread Maarten Lankhorst
Hey, Op 24-09-13 06:44, Andy Ritger schreef: > Hi Nouveau developers, > > NVIDIA is releasing public documentation on certain aspects of our GPUs, > with the intent to address areas that impact the out-of-the-box usability > of NVIDIA GPUs with Nouveau. We intend to provide more documentation > o

[Nouveau] [PATCH] drm/nouveau: suspend to D3hot, not to D3cold

2013-10-08 Thread Maarten Lankhorst
only up to D3hot is allowed. Signed-off-by: Maarten Lankhorst --- diff --git a/drivers/gpu/drm/nouveau/nouveau_drm.c b/drivers/gpu/drm/nouveau/nouveau_drm.c index 89efeff..566e544 100644 --- a/drivers/gpu/drm/nouveau/nouveau_drm.c +++ b/drivers/gpu/drm/nouveau/nouveau_drm.c @@ -945,7 +945,7 @@ s

[Nouveau] [PATCH] drm/nouveau: do not map evicted bo's in nouveau_bo_vma_add

2013-10-10 Thread Maarten Lankhorst
Signed-off-by: Maarten Lankhorst Cc: # v3.7+ --- diff --git a/drivers/gpu/drm/nouveau/nouveau_bo.c b/drivers/gpu/drm/nouveau/nouveau_bo.c --- a/drivers/gpu/drm/nouveau/nouveau_bo.c +++ b/drivers/gpu/drm/nouveau/nouveau_bo.c @@ -1551,7 +1579,8 @@ nouveau_bo_vma_add(struct nouveau_bo *nvbo

Re: [Nouveau] drm/nouveau contiguous bo check produces lots of output

2013-11-11 Thread Maarten Lankhorst
op 11-11-13 16:31, Jerry Cooperstein schreef: > Hi: > > commit bd9c5a2016307164c419c5e24a46921c10e620a0 > > (drm/nouveau: require contiguous bo for framebuffer) > produces about 2000 lines of > > nouveau E[ DRM] framebuffer requires contiguous bo > > on system boot and more on shutdown, but I d

Re: [Nouveau] drm/nouveau contiguous bo check produces lots of output

2013-11-11 Thread Maarten Lankhorst
op 11-11-13 17:05, Jerry Cooperstein schreef: > On 11/11/2013 09:57 AM, Maarten Lankhorst wrote: >> op 11-11-13 16:31, Jerry Cooperstein schreef: >>> Hi: >>> >>> commit bd9c5a2016307164c419c5e24a46921c10e620a0 >>> >>> (drm/nouveau: require

[Nouveau] [PATCH 3/7] drm/nouveau: fixup locking inversion between mmap_sem and reservations

2013-11-12 Thread maarten . lankhorst
From: Maarten Lankhorst Allocate and copy all kernel memory before doing reservations. This prevents a locking inversion between mmap_sem and reservation_class, and allows us to drop the trylocking in ttm_bo_vm_fault without upsetting lockdep. Relocations are handled by trying with

[Nouveau] [PATCH 5/7] drm/nouveau: do not map evicted vram buffers in nouveau_bo_vma_add

2013-11-12 Thread maarten . lankhorst
From: Maarten Lankhorst Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/nouveau/nouveau_bo.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_bo.c b/drivers/gpu/drm/nouveau/nouveau_bo.c index 9ecb874..bb3734d 100644 --- a/drivers/gpu

[Nouveau] [PATCH 6/7] drm/nouveau: more paranoia in nouveau_bo_fixup_align

2013-11-12 Thread maarten . lankhorst
From: Maarten Lankhorst Make sure that buffers are always aligned. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/nouveau/nouveau_bo.c | 40 +++- 1 file changed, 21 insertions(+), 19 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_bo.c b

[Nouveau] [PATCH 7/7] drm/nouveau: use a single vma for display

2013-11-12 Thread maarten . lankhorst
From: Maarten Lankhorst No need to map the same vma multiple times. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/nouveau/nouveau_fence.h | 4 ++-- drivers/gpu/drm/nouveau/nv50_display.c | 13 ++--- drivers/gpu/drm/nouveau/nv50_display.h | 2 +- drivers/gpu/drm/nouveau

[Nouveau] [PATCH 2/7] drm/nv50-: untile mmap'd bo's

2013-11-12 Thread maarten . lankhorst
From: Maarten Lankhorst Map the GART to the bar and use that mapping, to hide all the tiling details from users. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/nouveau/core/subdev/bar/nv50.c | 5 - drivers/gpu/drm/nouveau/core/subdev/bar/nvc0.c | 5 - drivers/gpu/drm/nouveau

[Nouveau] [PATCH 4/7] drm/nvc0-/gr: shift wrapping bug in nvc0_grctx_generate_r406800

2013-11-12 Thread maarten . lankhorst
From: Dan Carpenter We care about the upper 32 bits here so we have to use 1ULL instead of 1 to avoid a shift wrapping bug. Signed-off-by: Dan Carpenter Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/nouveau/core/engine/graph/ctxnvc0.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[Nouveau] [PATCH 1/7] drm/nouveau: fix m2mf copy to tiled gart

2013-11-12 Thread maarten . lankhorst
From: Maarten Lankhorst Commit de7b7d59d54852c introduced tiled GART, but a linear copy is still performed. This may result in errors on eviction, fix it by checking tiling from memtype. Signed-off-by: Maarten Lankhorst Cc: sta...@vger.kernel.org #3.10+ --- drivers/gpu/drm/nouveau

[Nouveau] [PATCH] drm/nvc0-: Fix voltage obtained from vbios.

2014-01-02 Thread Maarten Lankhorst
Coefficients are based on the formula: uV = 0.1 * arg[0] + 150.5 * arg[1] + 22.65025 * arg[2] It seems to be rounded downwards. I have no idea why the voltage isn't specified in the bios directly. Signed-off-by: Maarten Lankhorst diff --git a/drivers/gpu/drm/nouveau/core/subdev

[Nouveau] [PATCH 1/2] drm/nouveau: hold mutex while syncing to kernel channel

2014-01-14 Thread Maarten Lankhorst
Not holding the mutex potentially causes corruption of the kernel channel when page flipping. Cc: sta...@vger.kernel.org #3.13 Signed-off-by: Maarten Lankhorst --- diff --git a/drivers/gpu/drm/nouveau/nouveau_display.c b/drivers/gpu/drm/nouveau/nouveau_display.c index 29c3efdfc7dd

[Nouveau] [PATCH 2/2] drm/nouveau: require cli->mutex in RING_SPACE

2014-01-14 Thread Maarten Lankhorst
Signed-off-by: Maarten Lankhorst --- diff --git a/drivers/gpu/drm/nouveau/nouveau_abi16.c b/drivers/gpu/drm/nouveau/nouveau_abi16.c index 900fae01793e..20959e445d05 100644 --- a/drivers/gpu/drm/nouveau/nouveau_abi16.c +++ b/drivers/gpu/drm/nouveau/nouveau_abi16.c @@ -153,10 +153,12 @@ nouveau_abi16_

[Nouveau] [PATCH] drm/nouveau: fix lock unbalance in nouveau_crtc_page_flip

2014-01-29 Thread Maarten Lankhorst
Fixes a regression introduced by d5c1e84b3a130f0 "drm/nouveau: hold mutex while syncing to kernel channel". Cc: sta...@vger.kernel.org #3.13 Reported-by: Fengguang Wu Signed-off-by: Maarten Lankhorst --- diff --git a/drivers/gpu/drm/nouveau/nouveau_display.c b/drivers/gpu/d

Re: [Nouveau] [PATCH] drm/nouveau: fix TTM_PL_TT memtype on pre-nv50

2014-02-16 Thread Maarten Lankhorst
t;device)->card_type < NV_50 || !node->memtype) /* untiled */ break; /* fallthrough, tiled memory */ Acked-by: Maarten Lankhorst ___ Nouveau mailing list Nouveau@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/nouveau

[Nouveau] [REGRESSION] ACPI / nouveau: replace open-coded _DSM code with helper functions

2014-02-17 Thread Maarten Lankhorst
This commit breaks loading nouveau on my optimus laptop. I get the following spam in dmesg: [ 24.102587] MXM: GUID detected in BIOS [ 24.103167] ACPI Exception: AE_AML_PACKAGE_LIMIT, Index (0x3) is beyond end of object (length 0x0) (20131218/exoparg2-420) [ 24.103242] ACPI Error:

[Nouveau] [PATCH] libdrm/nouveau: safen up nouveau libdrm against concurrent access

2014-04-08 Thread Maarten Lankhorst
: Maarten Lankhorst --- --- nouveau/nouveau.c | 108 +++--- nouveau/private.h | 3 +- 2 files changed, 89 insertions(+), 22 deletions(-) diff --git a/nouveau/nouveau.c b/nouveau/nouveau.c index ee7893b..75dfb0e 100644 --- a/nouveau/nouveau.c +++ b

[Nouveau] [RFC PATCH v1 06/16] drm/ttm: kill fence_lock

2014-05-14 Thread Maarten Lankhorst
No users are left, kill it off! :D Conversion to the reservation api is next on the list, after that the functionality can be restored with rcu. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/nouveau/nouveau_bo.c | 25 +++--- drivers/gpu/drm/nouveau/nouveau_display.c |6

[Nouveau] [RFC PATCH v1 08/16] drm/radeon: use common fence implementation for fences

2014-05-14 Thread Maarten Lankhorst
Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/radeon/radeon.h| 15 +-- drivers/gpu/drm/radeon/radeon_device.c |1 drivers/gpu/drm/radeon/radeon_fence.c | 189 +--- 3 files changed, 153 insertions(+), 52 deletions(-) diff --git a/drivers/gpu

[Nouveau] [RFC PATCH v1 07/16] drm/nouveau: rework to new fence interface

2014-05-14 Thread Maarten Lankhorst
From: Maarten Lankhorst Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/nouveau/core/core/event.c |4 drivers/gpu/drm/nouveau/nouveau_bo.c |6 drivers/gpu/drm/nouveau/nouveau_display.c |4 drivers/gpu/drm/nouveau/nouveau_fence.c | 434

[Nouveau] [RFC PATCH v1 02/16] drm/ttm: kill off some members to ttm_validate_buffer

2014-05-14 Thread Maarten Lankhorst
This reorders the list to keep track of what buffers are reserved, so previous members are always unreserved. This gets rid of some bookkeeping that's no longer needed, while simplifying the code some. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/qxl/qxl_release.c |

[Nouveau] [RFC PATCH v1 16/16] drm/ttm: use rcu in core ttm

2014-05-14 Thread Maarten Lankhorst
Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/ttm/ttm_bo.c | 76 +++--- 1 file changed, 13 insertions(+), 63 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c index 31c4a6dd722d..6fe1f4bf37ed 100644 --- a/drivers

[Nouveau] [RFC PATCH v1 12/16] drm/ttm: flip the switch, and convert to dma_fence

2014-05-14 Thread Maarten Lankhorst
--- drivers/gpu/drm/nouveau/nouveau_bo.c | 48 +--- drivers/gpu/drm/nouveau/nouveau_fence.c | 24 +--- drivers/gpu/drm/nouveau/nouveau_fence.h |2 drivers/gpu/drm/nouveau/nouveau_gem.c| 16 ++- drivers/gpu/drm/qxl/qxl_debugfs.c|6 + drivers/gpu/drm/qxl/qxl_drv

[Nouveau] [RFC PATCH v1 00/16] Convert all ttm drivers to use the new reservation interface

2014-05-14 Thread Maarten Lankhorst
are converted to the fence api, fence_lock is removed and rcu is used in its place. qxl is the first driver to use shared fence slots, but when these patches are applied it's easy to convert nouveau too. I've done it as part of the cross-device gpu synchronization patch series. --

  1   2   3   >