Re: [Nouveau] [PATCH 3/5] GPU-DRM-nouveau: Delete unnecessary braces

[Dan Carpenter]

The original style was correct, the new style is wrong. Multi-line
indents get curly braces for readability.

regards,
dan carpenter

___
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau

Re: [Nouveau] [PATCH 3/5] GPU-DRM-nouveau: Delete unnecessary braces

[Roy Spliet]

Comments in-line. Thanks.

Roy

Op 21-09-16 om 08:26 schreef SF Markus Elfring:

From: Markus Elfring 
Date: Wed, 21 Sep 2016 08:28:08 +0200

Do not use curly brackets at four source code places
where a single statement should be sufficient.

Signed-off-by: Markus Elfring 
---
  drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgt215.c | 14 +-
  1 file changed, 5 insertions(+), 9 deletions(-)

diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgt215.c 
b/drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgt215.c
index dbaf577..cb50539 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgt215.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgt215.c
@@ -127,12 +127,11 @@ gt215_link_train_calc(u32 *vals, struct gt215_ltrain 
*train)
}
  
  	/* Find the best value for 0xe0 */

-   for (i = 0; i < 4; i++) {
+   for (i = 0; i < 4; i++)
if (bins[i] > qty) {
bin = i + 3;
qty = bins[i];
}
-   }
I'm not a fan of removing the braces around a multi-line statement, 
despite being functionally correct. It obscures the program structure on 
displays with a low effective vertical resolution.
  
  	train->r_100720 = 0;

for (i = 0; i < 8; i++) {
@@ -729,9 +728,8 @@ gt215_ram_calc(struct nvkm_ram *base, u32 freq)
ram_mask(fuc, 0x1007e0, 0x, r100760);
}
  
-	if (device->chipset == 0xa3 && freq > 50) {

+   if (device->chipset == 0xa3 && freq > 50)
ram_mask(fuc, 0x100700, 0x0006, 0x);
-   }
  
  	/* Final switch */

if (mclk.pll) {
@@ -745,12 +743,11 @@ gt215_ram_calc(struct nvkm_ram *base, u32 freq)
ram_nsec(fuc, 2000);
  
  	/* Set RAM MR parameters and timings */

-   for (i = 2; i >= 0; i--) {
+   for (i = 2; i >= 0; i--)
if (ram_rd32(fuc, mr[i]) != ram->base.mr[i]) {
ram_wr32(fuc, mr[i], ram->base.mr[i]);
ram_nsec(fuc, 1000);
}
-   }

Idem.
  
  	ram_wr32(fuc, 0x100220[3], timing[3]);

ram_wr32(fuc, 0x100220[1], timing[1]);
@@ -838,11 +835,10 @@ gt215_ram_calc(struct nvkm_ram *base, u32 freq)
if (!next->bios.ramcfg_DLLoff)
nvkm_sddr2_dll_reset(fuc);
  
-	if (ram->base.type == NVKM_RAM_TYPE_GDDR3) {

+   if (ram->base.type == NVKM_RAM_TYPE_GDDR3)
ram_nsec(fuc, 31000);
-   } else {
+   else
ram_nsec(fuc, 14000);
-   }
  
  	if (ram->base.type == NVKM_RAM_TYPE_DDR3) {

ram_wr32(fuc, 0x100264, 0x1);


___
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau