[ 
https://issues.apache.org/jira/browse/NPANDAY-617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13994942#comment-13994942
 ] 

Lars Corneliussen commented on NPANDAY-617:
-------------------------------------------

Agreed. .NETs Nuget also starts aligning to semver (Semantic Versioning) with 
only 3 numbers. It is still possible to append a fourth with a dash, and if it 
needs to be a number, prepend it such that it is sortable as string.

Since I use Maven to resolve dependencies and package what I deploy, I don't 
care about .NETs version resolving. Also though about generating assembly 
binding xml for cases where the version rules not match.

Then using the first 3 numbers from the maven version + ".0" (for 
AssemblyVersion) is a good fit. AssemblyInformationalVersion can be an 
arbitrary string - i just ignore the warning. (could put CS1607) in the default 
ignores, if so.

> compile:generate-assembly-info Allow for filtering/customization of properties
> ------------------------------------------------------------------------------
>
>                 Key: NPANDAY-617
>                 URL: https://issues.apache.org/jira/browse/NPANDAY-617
>             Project: NPanday
>          Issue Type: Improvement
>          Components: Maven Plugins
>    Affects Versions: 1.4-incubating
>            Reporter: Greg Domjan
>              Labels: configuration, documentation, filters, versioning
>
> The generation of assembly info from the maven pom is desirable, especially 
> in reguard to filling in version and copyright year, so having a static 
> AssemblyInfo.cs to customize the value doesn't seem to be a good work around 
> (unless I've missed an alternate way to apply filtering?)
> It is unclear where these might be sourced from
> [assembly: AssemblyCopyright("")]
> [assembly: AssemblyTrademark("")]
> [assembly: AssemblyCulture("")]
> The [assembly: AssemblyProduct("")]  appears to be a combination of 
> Company-Title and it would be good to be able to customize it.
> In regard to version, it appears maven2 version format isn't supported?
> If an alternate source for version could be provided so that the version 
> formatted to .net/npanday standard could be used it would be helpful.
> For example Using the maven 2 standard format version of 
> major.minor.revision-build  reports issues due to generation requiring the 
> 'string' version of major.minor.revision.build which can cause issues with 
> version comparison.
> ie. <version>8.1.0-0-SNAPSHOT</version>
> generates
> [assembly: AssemblyVersion("8.1.0")]
> [assembly: AssemblyInformationalVersion("8.1.0-0-SNAPSHOT")]
> warning CS1607: Assembly generation -- The version '8.1.0-0-SNAPSHOT' 
> specified for the 'product version' is not in the normal 'major.minor.
> build.revision' format
> Best ref I found is 
> http://mojo.codehaus.org/versions-maven-plugin/version-rules.html
> For example, Maven arranges the version list in the following manner:
> 1.0.1.0
> 1.0.10.1
> 1.0.10.2
> 1.0.9.3
> Version 1.0.9.3 should come before 1.0.10.1 and 1.0.10.2, but the unexpected 
> fourth field (.3) forced Maven to evaluate the version as a string.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to