[Nrtb-core] [Bug 725107] Re: Todo: (style) exception usage seems overly complex.
** Branch unlinked: lp:~gsjordanc/nrtb/data-broker-dont_use
** Branch linked: lp:~gsjordanc/nrtb/databroker-alpha
--
You received this bug notification because you are a member of NRTB
Core, which is subscribed to New Real Time Battle.
https://bugs.launchpad.net/bugs/725107
Title:
Todo: (style) exception usage seems overly complex.
Status in The New Real Time Battle Project:
Fix Committed
Bug description:
In dbAccess.cpp, line 81 of revision 36 we find the following:
default:
throw bad_type(dbAccess::sqlExecute -
Invalid query type used,);
break;
}
Assuming the dbAccess::bad_type is only thrown in this context (a bad
query type passed to dbAccess::sqlExecute()) it would be better if the
exception name is changed to dbAccess::unknown_query_type. This would
allow you construct and throw without loading a string (faster) and
makes picking the exception off by type name in catch statements more
clear. The new code would be something like this:
default:
{
throw unknown_query_type();
};
};
To manage notifications about this bug go to:
https://bugs.launchpad.net/nrtb/+bug/725107/+subscriptions
___
Mailing list: https://launchpad.net/~nrtb-core
Post to : nrtb-core@lists.launchpad.net
Unsubscribe : https://launchpad.net/~nrtb-core
More help : https://help.launchpad.net/ListHelp
[Nrtb-core] [Bug 722598] Re: Todo: Copyright banners need to be added to dbAccess_test.cpp
** Branch unlinked: lp:~gsjordanc/nrtb/data-broker-dont_use ** Branch linked: lp:~gsjordanc/nrtb/databroker-alpha -- You received this bug notification because you are a member of NRTB Core, which is subscribed to New Real Time Battle. https://bugs.launchpad.net/bugs/722598 Title: Todo: Copyright banners need to be added to dbAccess_test.cpp Status in The New Real Time Battle Project: Fix Committed Bug description: The Makefile version of the banner will work in the configuration file... To manage notifications about this bug go to: https://bugs.launchpad.net/nrtb/+bug/722598/+subscriptions ___ Mailing list: https://launchpad.net/~nrtb-core Post to : nrtb-core@lists.launchpad.net Unsubscribe : https://launchpad.net/~nrtb-core More help : https://help.launchpad.net/ListHelp
[Nrtb-core] [Bug 720884] Re: Todo: Code data-broker::dbAccess for config file reader use
** Branch unlinked: lp:~gsjordanc/nrtb/data-broker-dont_use ** Branch linked: lp:~gsjordanc/nrtb/databroker-alpha -- You received this bug notification because you are a member of NRTB Core, which is subscribed to New Real Time Battle. https://bugs.launchpad.net/bugs/720884 Title: Todo: Code data-broker::dbAccess for config file reader use Status in The New Real Time Battle Project: Fix Committed Status in New Real Time Battle alpha series: Fix Committed Bug description: Incorporate use of confreader library/object into Data Broker dbAccess class. To manage notifications about this bug go to: https://bugs.launchpad.net/nrtb/+bug/720884/+subscriptions ___ Mailing list: https://launchpad.net/~nrtb-core Post to : nrtb-core@lists.launchpad.net Unsubscribe : https://launchpad.net/~nrtb-core More help : https://help.launchpad.net/ListHelp
[Nrtb-core] [Bug 722717] Re: Todo: dbAccess.h has a using namespace statement in it.
** Branch unlinked: lp:~gsjordanc/nrtb/data-broker-dont_use ** Branch linked: lp:~gsjordanc/nrtb/databroker-alpha -- You received this bug notification because you are a member of NRTB Core, which is subscribed to New Real Time Battle. https://bugs.launchpad.net/bugs/722717 Title: Todo: dbAccess.h has a using namespace statement in it. Status in The New Real Time Battle Project: Fix Committed Bug description: Best practices indicate that no header file should have a using namespace statement. Such a statement in a header file affects not only the header, but any file which may include that header later, leading to unintended bugs. Please remove the using namespace std; statement fully qualify any reference to an identifier from the std:: namespace in the header. To manage notifications about this bug go to: https://bugs.launchpad.net/nrtb/+bug/722717/+subscriptions ___ Mailing list: https://launchpad.net/~nrtb-core Post to : nrtb-core@lists.launchpad.net Unsubscribe : https://launchpad.net/~nrtb-core More help : https://help.launchpad.net/ListHelp
[Nrtb-core] [Bug 722705] Re: Todo: Several dbAccess:: methods improperly return a error flag
** Branch unlinked: lp:~gsjordanc/nrtb/data-broker-dont_use ** Branch linked: lp:~gsjordanc/nrtb/databroker-alpha -- You received this bug notification because you are a member of NRTB Core, which is subscribed to New Real Time Battle. https://bugs.launchpad.net/bugs/722705 Title: Todo: Several dbAccess:: methods improperly return a error flag Status in The New Real Time Battle Project: Fix Committed Bug description: Method int dbAccess::runSql (string scrpt) returns an int indicating success or failure and carrying no other significance. Best practices indicate that the method should succeed cleanly or throw an exception, therefore the return of a status flag is redundant; a failure would never return the error code in any case. Given the above, the method should be altered to not return any type of status code and to throw an exception (may I suggest dbAccess::runSql_failure as a name) should the query fail. A nice enhancement would be to store the error code and text in the exception so the actual event and problem can be resolved by the caller if needed. One other question while we are here, was the mis-spelling of script in the argument list intentional? To manage notifications about this bug go to: https://bugs.launchpad.net/nrtb/+bug/722705/+subscriptions ___ Mailing list: https://launchpad.net/~nrtb-core Post to : nrtb-core@lists.launchpad.net Unsubscribe : https://launchpad.net/~nrtb-core More help : https://help.launchpad.net/ListHelp
[Nrtb-core] [Bug 723651] Re: Todo: dbAccess.config needs a copyright banner.
** Branch unlinked: lp:~gsjordanc/nrtb/data-broker-dont_use ** Branch linked: lp:~gsjordanc/nrtb/databroker-alpha -- You received this bug notification because you are a member of NRTB Core, which is subscribed to New Real Time Battle. https://bugs.launchpad.net/bugs/723651 Title: Todo: dbAccess.config needs a copyright banner. Status in The New Real Time Battle Project: Fix Committed Bug description: The banner we us in makefiles willl work in the config file. To manage notifications about this bug go to: https://bugs.launchpad.net/nrtb/+bug/723651/+subscriptions ___ Mailing list: https://launchpad.net/~nrtb-core Post to : nrtb-core@lists.launchpad.net Unsubscribe : https://launchpad.net/~nrtb-core More help : https://help.launchpad.net/ListHelp
[Nrtb-core] [Bug 837090] Re: nrtb::tcp_server_socket_factory randomly crashes on shutdown.
This has become a critical bug; I'll fix it immediately. ** Changed in: nrtb Assignee: (unassigned) = Rick Stovall (fpstovall) ** Changed in: nrtb Status: Triaged = Confirmed ** Tags removed: beta ** Changed in: nrtb Importance: Medium = Critical -- You received this bug notification because you are a member of NRTB Core, which is subscribed to New Real Time Battle. https://bugs.launchpad.net/bugs/837090 Title: nrtb::tcp_server_socket_factory randomly crashes on shutdown. Status in The New Real Time Battle Project: In Progress Bug description: nrtb::tcp_server_socket_factory has some type of resource conflict which arises about 20% of the time when destructing or shutting down the listener. No other negative issues have been observed. That said, this does not affect run time stability as a general rule.. most applications using the class start it and then leave it running for the entire duration of the program run. Therefore this bug is not as critical as it might appear at first glance. This is very old code and I'm sure a cleanup could do wonders towards removing this issue. I'm recommending the fix be deferred until beta phase, as it will have little or no effect on our ability to work during alpha. To manage notifications about this bug go to: https://bugs.launchpad.net/nrtb/+bug/837090/+subscriptions ___ Mailing list: https://launchpad.net/~nrtb-core Post to : nrtb-core@lists.launchpad.net Unsubscribe : https://launchpad.net/~nrtb-core More help : https://help.launchpad.net/ListHelp
[Nrtb-core] [Bug 837090] Re: nrtb::tcp_server_socket_factory randomly crashes on shutdown.
** Branch linked: lp:~fpstovall/nrtb/listener-fix ** Changed in: nrtb Status: Confirmed = In Progress -- You received this bug notification because you are a member of NRTB Core, which is subscribed to New Real Time Battle. https://bugs.launchpad.net/bugs/837090 Title: nrtb::tcp_server_socket_factory randomly crashes on shutdown. Status in The New Real Time Battle Project: In Progress Bug description: nrtb::tcp_server_socket_factory has some type of resource conflict which arises about 20% of the time when destructing or shutting down the listener. No other negative issues have been observed. That said, this does not affect run time stability as a general rule.. most applications using the class start it and then leave it running for the entire duration of the program run. Therefore this bug is not as critical as it might appear at first glance. This is very old code and I'm sure a cleanup could do wonders towards removing this issue. I'm recommending the fix be deferred until beta phase, as it will have little or no effect on our ability to work during alpha. To manage notifications about this bug go to: https://bugs.launchpad.net/nrtb/+bug/837090/+subscriptions ___ Mailing list: https://launchpad.net/~nrtb-core Post to : nrtb-core@lists.launchpad.net Unsubscribe : https://launchpad.net/~nrtb-core More help : https://help.launchpad.net/ListHelp
