[Nrtb-core] [Merge] lp:~fpstovall/nrtb/circular_queue into lp:nrtb

2011-10-07 Thread noreply
The proposal to merge lp:~fpstovall/nrtb/circular_queue into lp:nrtb has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~fpstovall/nrtb/circular_queue/+merge/78527 -- https://code.launchpad.net/~fpstovall/nrtb/circular_queue/+merge/78527 Your team

Re: [Nrtb-core] [Merge] lp:~fpstovall/nrtb/circular_queue into lp:nrtb

2011-10-07 Thread Rick Stovall
Aron asked about situations with multiple consumes where all attached consumer threads may not be used. First, let's let's have a little background. When a thread enters pop(), one of two things happen. In case 1, there is data in the queue and it pops the top one off and returns immediately.

Re: [Nrtb-core] [Merge] lp:~fpstovall/nrtb/circular_queue into lp:nrtb

2011-10-07 Thread Aron Boyette
Review: Approve code Looks good to me. I see no changes that need to be made before proceeding. I think there may be some room to abstract queue out from linear_queue and circular_queue, but for now this works well. -- https://code.launchpad.net/~fpstovall/nrtb/circular_queue/+merge/78527 You

[Nrtb-core] [Merge] lp:~fpstovall/nrtb/circular_queue into lp:nrtb

2011-10-07 Thread George Jordan
The proposal to merge lp:~fpstovall/nrtb/circular_queue into lp:nrtb has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~fpstovall/nrtb/circular_queue/+merge/78527 -- https://code.launchpad.net/~fpstovall/nrtb/circular_queue/+merge/78527 You

Re: [Nrtb-core] [Merge] lp:~fpstovall/nrtb/circular_queue into lp:nrtb

2011-10-07 Thread George Jordan
Review: Approve code Downloaded branch to my machine for low end machine (P4 1.6G single core processor) build. Built with no errors or warnings and unit tests ran successfully with no problems. Approved for merge -- https://code.launchpad.net/~fpstovall/nrtb/circular_queue/+merge/78527 Your

Re: [Nrtb-core] [Merge] lp:~fpstovall/nrtb/circular_queue into lp:nrtb

2011-10-06 Thread Rick Stovall
Review: Approve merge test Test merge to the alpha branch has been completed. A test build of common was completed and all unit tests were reviewed and verified to have completed correctly. There were no issues found. -- https://code.launchpad.net/~fpstovall/nrtb/circular_queue/+merge/78527 You

[Nrtb-core] [Merge] lp:~fpstovall/nrtb/circular_queue into lp:nrtb

2011-10-06 Thread Rick Stovall
Rick Stovall has proposed merging lp:~fpstovall/nrtb/circular_queue into lp:nrtb. Requested reviews: NRTB Core (nrtb-core): code For more details, see: https://code.launchpad.net/~fpstovall/nrtb/circular_queue/+merge/78527 Added the following to the nrtb c++ common library: Circlar_queue; a