Re: [ntfs-3g-devel] [PATCH] acls.c: fix validation of SID subauthority count

2015-07-14 Thread Jean-Pierre André
Sounds good, thanks, merged now. Regards Jean-Pierre Eric Biggers wrote: ntfs_valid_sid() required that the subauthority count be between 1 and 8 inclusively. However, Windows permits more than 8 subauthorities as well as 0 subauthorities: - The install.wim file for the latest Windows

Re: [ntfs-3g-devel] [PATCH] acls.c: fix validation of SID subauthority count

2015-07-14 Thread Ulf Zibis
Hi Eric and André, this sounds sounds interesting. Currently NTFS-3G allways adds an ACE with full access for World SID, if no other permissions apply. Is this because of a ACE count = 1 ? I more would like, there would be added zero ACE if no inheritance is possible. Otherwise there would be

Re: [ntfs-3g-devel] [PATCH] acls.c: fix validation of SID subauthority count

2015-07-14 Thread Jean-Pierre André
Hi Ulf, Ulf Zibis wrote: Hi Eric and André, this sounds sounds interesting. Currently NTFS-3G allways adds an ACE with full access for World SID, if no other permissions apply. When an ACL is bad (or when the validity check is too strict, as in the case found by Eric), ntfs-3g is made to

[ntfs-3g-devel] [PATCH] acls.c: fix validation of SID subauthority count

2015-07-12 Thread Eric Biggers
ntfs_valid_sid() required that the subauthority count be between 1 and 8 inclusively. However, Windows permits more than 8 subauthorities as well as 0 subauthorities: - The install.wim file for the latest Windows 10 build contains a file whose DACL contains a SID with 10 subauthorities.