Re: [ntfs-3g-devel] [PATCH] unistr.c: make utf16_to_utf8_size() always honor @outs_len

2016-10-29 Thread Eric Biggers
On Sat, Oct 29, 2016 at 12:07:17PM +0200, Jean-Pierre André wrote: > Eric Biggers wrote: > > On Sat, Oct 29, 2016 at 09:45:57AM +0200, Jean-Pierre André wrote: > > > > > > I am waiting for a green light from Tuxera for merging them > > > into the git. > > > > Is there any particular reason you

Re: [ntfs-3g-devel] [PATCH] unistr.c: make utf16_to_utf8_size() always honor @outs_len

2016-10-29 Thread Jean-Pierre André
Eric Biggers wrote: > On Sat, Oct 29, 2016 at 09:45:57AM +0200, Jean-Pierre André wrote: >> >> I am waiting for a green light from Tuxera for merging them >> into the git. > > Is there any particular reason you need their permission to do so? Well, they are the owner of the project...

Re: [ntfs-3g-devel] [PATCH] unistr.c: make utf16_to_utf8_size() always honor @outs_len

2016-10-29 Thread Jean-Pierre André
Hi Eric, Eric Biggers wrote: > Hi Jean-Pierre, > > Are you going to be reviewing/applying any of these other patches? (Excluding > the "ACE validation fixes" one which will need to be reworked once the desired > behavior is agreed on.) I considered as valid all your proposed patches which I did

Re: [ntfs-3g-devel] [PATCH] unistr.c: make utf16_to_utf8_size() always honor @outs_len

2016-10-28 Thread Eric Biggers
Hi Jean-Pierre, Are you going to be reviewing/applying any of these other patches? (Excluding the "ACE validation fixes" one which will need to be reworked once the desired behavior is agreed on.) I've also found a bug in lowntfs-3g regarding the reparse plugin support, so I'll send a patch for

[ntfs-3g-devel] [PATCH] unistr.c: make utf16_to_utf8_size() always honor @outs_len

2016-09-15 Thread Eric Biggers
utf16_to_utf8_size() was not guaranteed to fail with ENAMETOOLONG if the computed length was greater than @outs_len. This could cause a buffer overrun in ntfs_utf16_to_utf8(). This was a bug introduced by the patches to allow broken Unicode. Fix it. Signed-off-by: Eric Biggers