Re: [ntfs-3g-devel] [PATCH 2/2] ACE validation fixes

2016-09-21 Thread Jean-Pierre André
Hi again, Eric Biggers wrote: > Hmm, I think I messed up the "object" ACEs slightly (assuming they ever > actually > exist). According to > https://msdn.microsoft.com/en-us/library/windows/desktop/aa374857(v=vs.85).aspx, > the SID is actually at a variable offset. > > Another problem is that

Re: [ntfs-3g-devel] [PATCH 2/2] Remove unused argument from ntfs_make_symlink()

2016-09-21 Thread Eric Biggers
On Wed, Sep 21, 2016 at 10:47:57AM +0200, Jean-Pierre André wrote: > Hi Eric, > > There has been a recent request for ntfs-3g to return > the st_size for symlinks as the size of the target > path (as described in the stat manual), so the target > is now useful > > Regards > Well, the

[ntfs-3g-devel] [PATCH 2/2] Remove unused argument from ntfs_make_symlink()

2016-09-21 Thread Eric Biggers
Now that the size of the reparse point attribute is no longer used by the FUSE drivers to populate st_size for symlinks and junctions, it no longer needs to be returned by ntfs_make_symlink(). Signed-off-by: Eric Biggers --- include/ntfs-3g/reparse.h | 4 ++--

[ntfs-3g-devel] [PATCH 1/2] ntfs-3g, lowntfs-3g: set correct st_size for symlinks

2016-09-21 Thread Eric Biggers
NTFS-3G used several different conventions for setting st_size of symlinks. Make it use the standard POSIX convention of setting st_size to the length of the link target without a terminating null. Signed-off-by: Eric Biggers --- src/lowntfs-3g.c | 35

[ntfs-3g-devel] [PATCH 2/2] ACE validation fixes

2016-09-21 Thread Eric Biggers
- Allow extra data after the SID. Recent Windows 10 images have been reported to contain DACLs with an ACCESS_ALLOWED_CALLBACK_ACE with extra data after the SID. The ACE is not necessarily at the end of the DACL, so the recent fix to allow extra data for the last ACE only was

[ntfs-3g-devel] [PATCH 1/2] Add definitions of ACE types up to Windows 10

2016-09-21 Thread Eric Biggers
The ACE types defined in layout.h were significantly out of date, as Microsoft has defined a number of new ACE types over the years. None of the new ACEs uses a new base structure, though it seems that some can have (or usually have) additional data after the SID. More information about the new