Re: [Numpy-discussion] Question about optimizing random_standard_normal

2021-02-08 Thread Robert Kern
On Mon, Feb 8, 2021 at 12:10 PM Sebastian Berg wrote: > > This type of change should be in the release notes undoubtedly and > likely a `.. versionchanged::` directive in the docstring. > > Maybe the best thing would be to create a single, prominent but brief, > changelog listing all (or almost

Re: [Numpy-discussion] Question about optimizing random_standard_normal

2021-02-08 Thread Charles R Harris
On Sat, Feb 6, 2021 at 2:32 AM wrote: > I tried to implement a different implementation of the ziggurat method for > generating standard normal distributions that is about twice as fast and > uses 2/3 of the memory than the old one. > I tested the implementation separately and am very confident

Re: [Numpy-discussion] Question about optimizing random_standard_normal

2021-02-08 Thread Sebastian Berg
On Mon, 2021-02-08 at 16:36 +, Kevin Sheppard wrote: > That is good news indeed.  Seems like a good upgrade, especially > given the breadth of application of normals and the multiple > appearances within distributions.c (e.g., Cauchy). Is there a > deprecation for a change like this? Or is it

Re: [Numpy-discussion] Question about optimizing random_standard_normal

2021-02-08 Thread Robert Kern
On Mon, Feb 8, 2021 at 11:38 AM Kevin Sheppard wrote: > That is good news indeed. Seems like a good upgrade, especially given the > breadth of application of normals and the multiple appearances within > distributions.c (e.g., Cauchy). Is there a deprecation for a change like > this? Or is it

Re: [Numpy-discussion] Question about optimizing random_standard_normal

2021-02-08 Thread Kevin Sheppard
That is good news indeed.  Seems like a good upgrade, especially given the breadth of application of normals and the multiple appearances within distributions.c (e.g., Cauchy). Is there a deprecation for a change like this? Or is it just a note and new random numbers in the next major?  I think

Re: [Numpy-discussion] Question about optimizing random_standard_normal

2021-02-08 Thread Robert Kern
On Mon, Feb 8, 2021 at 10:53 AM Kevin Sheppard wrote: > My reading is that the first 4 are pure C, presumably using the standard > practice of inclining so as to make the tightest loop possible, and to > allow the compiler to make other optimizations. The final line is what > happens when you

Re: [Numpy-discussion] Question about optimizing random_standard_normal

2021-02-08 Thread Kevin Sheppard
My reading is that the first 4 are pure C, presumably using the standard practice of inclining so as to make the tightest loop possible, and to allow the compiler to make other optimizations.  The final line is what happens when you replace the existing ziggurat in NumPy with the new one. I read

Re: [Numpy-discussion] Question about optimizing random_standard_normal

2021-02-08 Thread Robert Kern
On Mon, Feb 8, 2021 at 3:05 AM Kevin Sheppard wrote: > If I understand correctly, there is no gain when applying this patch to > Generator. I'm not that surprised that this is the case since the compiler > is much more limited in when it can do in Generator than what it can when > filling a

Re: [Numpy-discussion] Pearu Peterson has joined the NumPy developers team.

2021-02-08 Thread Ilhan Polat
This is very comforting news :) Welcome back On Sun, Feb 7, 2021 at 9:10 PM Stefan van der Walt wrote: > On Sun, Feb 7, 2021, at 10:12, Charles R Harris wrote: > > Pearu Peterson has joined the NumPy developers team. Pearu was responsible > for contributing f2py and much of distutils in the

Re: [Numpy-discussion] Question about optimizing random_standard_normal

2021-02-08 Thread Kevin Sheppard
If I understand correctly, there is no gain when applying this patch to Generator. I'm not that surprised that this is the case since the compiler is much more limited in when it can do in Generator than what it can when filling a large array directly with functions available for inlining and