Re: [Numpy-discussion] asanyarray vs. asarray

2018-10-29 Thread Eric Wieser
The latter - changing the behavior of multiplication breaks the principle. But this is not the main reason for deprecating matrix - almost all of the problems I’ve seen have been caused by the way that matrices behave when sliced. The way that m[i][j] and m[i,j] are different is just one example

Re: [Numpy-discussion] asanyarray vs. asarray

2018-10-29 Thread Ralf Gommers
On Mon, Oct 29, 2018 at 4:31 PM Chris Barker wrote: > On Fri, Oct 26, 2018 at 7:12 PM, Travis Oliphant > wrote: > > >> agree that we can stop bashing subclasses in general. The problem with >> numpy subclasses is that they were made without adherence to SOLID: >>

Re: [Numpy-discussion] asanyarray vs. asarray

2018-10-29 Thread Chris Barker
On Fri, Oct 26, 2018 at 7:12 PM, Travis Oliphant wrote: > agree that we can stop bashing subclasses in general. The problem with > numpy subclasses is that they were made without adherence to SOLID: > https://en.wikipedia.org/wiki/SOLID. In particular the Liskov > substitution principle: