Re: [Numpy-discussion] Possible Deprecation of np.ediff1d

2018-08-28 Thread Stephan Hoyer
On Tue, Aug 28, 2018 at 12:27 PM Ralf Gommers wrote: > On Tue, Aug 28, 2018 at 12:21 PM Marten van Kerkwijk < > m.h.vankerkw...@gmail.com> wrote: > >> >> >> On Mon, Aug 27, 2018 at 10:05 PM Stephan Hoyer wrote: >> >> - It appears in astropy, dask, pandas, pint, scipy and TensorFlow. >>> >> >>

Re: [Numpy-discussion] Possible Deprecation of np.ediff1d

2018-08-28 Thread Ralf Gommers
On Tue, Aug 28, 2018 at 12:21 PM Marten van Kerkwijk < m.h.vankerkw...@gmail.com> wrote: > > > On Mon, Aug 27, 2018 at 10:05 PM Stephan Hoyer wrote: > > - It appears in astropy, dask, pandas, pint, scipy and TensorFlow. >> > > The only reason it appears in astropy is because of tests that

Re: [Numpy-discussion] Possible Deprecation of np.ediff1d

2018-08-28 Thread Marten van Kerkwijk
On Mon, Aug 27, 2018 at 10:05 PM Stephan Hoyer wrote: - It appears in astropy, dask, pandas, pint, scipy and TensorFlow. > The only reason it appears in astropy is because of tests that Quantity works correctly with it; we do not actually use it... So that's at least a few hits that do not

Re: [Numpy-discussion] Possible Deprecation of np.ediff1d

2018-08-28 Thread Ilhan Polat
In the meantime I'll make a PR to get rid of it from SciPy. We can also signal other libraries to do so. Anything frees up the already-very-crowded namespace of NumPy dot is worth it in my opinion. On Tue, Aug 28, 2018 at 7:40 PM Stephan Hoyer wrote: > > > On Tue, Aug 28, 2018 at 9:03 AM Ralf

Re: [Numpy-discussion] Possible Deprecation of np.ediff1d

2018-08-28 Thread Stephan Hoyer
On Tue, Aug 28, 2018 at 9:03 AM Ralf Gommers wrote: > Maybe we need a "NumpyObsoleteWarning" :) At the least, we should probably >> have a list of obsolete functions in the documentation somewhere. My main >> concern is that as we go forward we might end up supporting a bunch of >> functions

Re: [Numpy-discussion] Possible Deprecation of np.ediff1d

2018-08-28 Thread Ralf Gommers
On Tue, Aug 28, 2018 at 8:04 AM Charles R Harris wrote: > > > On Mon, Aug 27, 2018 at 8:05 PM Stephan Hoyer wrote: > >> On Mon, Aug 27, 2018 at 10:30 AM Tyler Reddy >> wrote: >> >>> Chuck suggested ( >>> https://github.com/numpy/numpy/pull/11805#issuecomment-416069436 ) that >>> we may want to

Re: [Numpy-discussion] Possible Deprecation of np.ediff1d

2018-08-28 Thread Charles R Harris
On Mon, Aug 27, 2018 at 8:05 PM Stephan Hoyer wrote: > On Mon, Aug 27, 2018 at 10:30 AM Tyler Reddy > wrote: > >> Chuck suggested ( >> https://github.com/numpy/numpy/pull/11805#issuecomment-416069436 ) that >> we may want to consider deprecating np.ediff1d, which is perhaps not much >> more

Re: [Numpy-discussion] Possible Deprecation of np.ediff1d

2018-08-27 Thread Stephan Hoyer
On Mon, Aug 27, 2018 at 10:30 AM Tyler Reddy wrote: > Chuck suggested ( > https://github.com/numpy/numpy/pull/11805#issuecomment-416069436 ) that > we may want to consider deprecating np.ediff1d, which is perhaps not much > more useful than np.diff, apart from having some arguably strange

Re: [Numpy-discussion] Possible Deprecation of np.ediff1d

2018-08-27 Thread Eric Wieser
There is already a patch to add such a feature to np.diff at https://github.com/numpy/numpy/pull/8206 ​ On Mon, 27 Aug 2018 at 10:47 Charles R Harris wrote: > On Mon, Aug 27, 2018 at 11:37 AM Robert Kern > wrote: > >> On Mon, Aug 27, 2018 at 10:30 AM Tyler Reddy >> wrote: >> >>> Chuck

Re: [Numpy-discussion] Possible Deprecation of np.ediff1d

2018-08-27 Thread Robert Cimrman
Hi, it was originally used in other functions of arraysetops (culprit yours truly) which used to use the padding functionality. Nowadays the only use I can see git-grepping the numpy sources is in the tests, so +1 for deprecating. Cheers, r. On 08/27/2018 07:28 PM, Tyler Reddy wrote: Chuck

Re: [Numpy-discussion] Possible Deprecation of np.ediff1d

2018-08-27 Thread Robert Kern
On Mon, Aug 27, 2018 at 10:30 AM Tyler Reddy wrote: > Chuck suggested ( > https://github.com/numpy/numpy/pull/11805#issuecomment-416069436 ) that > we may want to consider deprecating np.ediff1d, which is perhaps not much > more useful than np.diff, apart from having some arguably strange

[Numpy-discussion] Possible Deprecation of np.ediff1d

2018-08-27 Thread Tyler Reddy
Chuck suggested ( https://github.com/numpy/numpy/pull/11805#issuecomment-416069436 ) that we may want to consider deprecating np.ediff1d, which is perhaps not much more useful than np.diff, apart from having some arguably strange prepend / append behavior added in. Related discussion on SO: