Re: [Numpy-discussion] [REVIEW] Update NumPy API format to support updates that don't break binary compatibility

2008-08-16 Thread Stéfan van der Walt
2008/8/16 Andrew Straw <[EMAIL PROTECTED]>: > Looking at the code, but not testing it -- this looks fine to me. (I > wrote the original NPY_VERSION stuff and sent it to Travis, who modified > and included it.) > > I have added a couple of extremely minor points to the code review tool > -- as much

Re: [Numpy-discussion] [REVIEW] Update NumPy API format to support updates that don't break binary compatibility

2008-08-16 Thread Andrew Straw
Looking at the code, but not testing it -- this looks fine to me. (I wrote the original NPY_VERSION stuff and sent it to Travis, who modified and included it.) I have added a couple of extremely minor points to the code review tool -- as much as a chance to play with the tool as to comment on t

[Numpy-discussion] [REVIEW] Update NumPy API format to support updates that don't break binary compatibility

2008-08-15 Thread Stéfan van der Walt
The current NumPy API number, stored as NPY_VERSION in the header files, needs to be incremented every time the NumPy C-API changes. The counter tells developers with exactly which revision of the API they are dealing. NumPy does some checking to make sure that it does not run against an old vers