Re: [Numpy-discussion] assert_allclose equal_nan default value.

Good, that means I can revert some changes to astropy, which made the tests less readable. -- Marten ___ NumPy-Discussion mailing list NumPy-Discussion@scipy.org https://mail.scipy.org/mailman/listinfo/numpy-discussion

Re: [Numpy-discussion] assert_allclose equal_nan default value.

+1. I was almost always setting it to True anyway. On Thu, Oct 20, 2016 at 1:18 PM, Nathan Goldbaum wrote: > Agreed, especially given the prevalence of using this function in > downstream test suites: > > https://github.com/search?utf8=%E2%9C%93=numpy+assert_ >

Re: [Numpy-discussion] assert_allclose equal_nan default value.

Agreed, especially given the prevalence of using this function in downstream test suites: https://github.com/search?utf8=%E2%9C%93=numpy+assert_allclose=Code=searchresults On Thu, Oct 20, 2016 at 12:16 PM, Charles R Harris < charlesr.har...@gmail.com> wrote: > Hi All, > > Just a heads up that

[Numpy-discussion] assert_allclose equal_nan default value.

Hi All, Just a heads up that there is a PR changing the default value of `equal_nan` to `True` in the `assert_allclose` test function. The `equal_nan` argument was previously ineffective due to a bug that has recently been fixed. The current default value of `False` is not backward compatible and