Re: [Numpy-discussion] not expected output of fill_diagonal

2012-06-11 Thread Frédéric Bastien
Thanks, I made a PR to fix it. I changed the current behavior to don't "wrap", but there is an option to change it. If someone think that we should not change the current default behavior. tell me. https://github.com/numpy/numpy/pull/306 Fred On Sat, Jun 9, 2012 at 8:44 AM, Warren Weckesser wr

Re: [Numpy-discussion] not expected output of fill_diagonal

2012-06-09 Thread Warren Weckesser
On Fri, Jun 8, 2012 at 7:45 PM, Frédéric Bastien wrote: > Hi, > > While reviewing the Theano op that wrap numpy.fill_diagonal, we found > an unexpected behavior of it: > > # as expected for square matrix > >>> a=numpy.zeros((5,5)) > >>> numpy.fill_diagonal(a, 10) > >>> print a > > # as expected l

[Numpy-discussion] not expected output of fill_diagonal

2012-06-08 Thread Frédéric Bastien
Hi, While reviewing the Theano op that wrap numpy.fill_diagonal, we found an unexpected behavior of it: # as expected for square matrix >>> a=numpy.zeros((5,5)) >>> numpy.fill_diagonal(a, 10) >>> print a # as expected long rectangular matrix >>> a=numpy.zeros((3,5)) >>> numpy.fill_diagonal(a, 10