Re: [Numpy-discussion] review of #6247

2015-09-11 Thread Nathaniel Smith
Please submit this to a pull request as well :-) On Sep 11, 2015 21:56, wrote: > On Sun, 6 Sep 2015 10:03:16 PM pi...@netspace.net.au wrote: > > On Sat, 5 Sep 2015 10:28:26 PM pi...@netspace.net.au wrote: > > > Hi all, first attempt at this: > > > small doco patch to > > > address https://github.

Re: [Numpy-discussion] review of #6191

2015-09-11 Thread Nathaniel Smith
Can you submit this as a pull request? That's how we normally review patches. On Sep 11, 2015 21:59, "jason" wrote: > doco patch to address https://github.com/numpy/numpy/issues/6191 > > https://github.com/numpy/numpy/compare/master...pizzathief:issue6191 > > _

[Numpy-discussion] review of #6191

2015-09-11 Thread jason
doco patch to address https://github.com/numpy/numpy/issues/6191 https://github.com/numpy/numpy/compare/master...pizzathief:issue6191 ___ NumPy-Discussion mailing list NumPy-Discussion@scipy.org http://mail.scipy.org/mailman/listinfo/numpy-discussion

Re: [Numpy-discussion] review of #6247

2015-09-11 Thread pizza
On Sun, 6 Sep 2015 10:03:16 PM pi...@netspace.net.au wrote: > On Sat, 5 Sep 2015 10:28:26 PM pi...@netspace.net.au wrote: > > Hi all, first attempt at this: > > small doco patch to > > address https://github.com/numpy/numpy/issues/6247 > > https://github.com/numpy/numpy/compare/master...pizzathief:

Re: [Numpy-discussion] feature request - increment counter on write check

2015-09-11 Thread Daniel
Nathaniel Smith wrote > Actually, now that I think about it there is a much worse general version > of this problem, which probably kills the idea dead. Via the buffer > interface (among others), it is totally legal and encouraged to create > non-numpy views of numpy arrays. They'll check the flags

[Numpy-discussion] ANN: pandas v0.17.0rc1 - RELEASE CANDIDATE

2015-09-11 Thread Jeff Reback
Hi, I'm pleased to announce the availability of the first release candidate of Pandas 0.17.0. Please try this RC and report any issues here: Pandas Issues We will be releasing officially in 1-2 weeks or so. **RELEASE CANDIDATE 1** This is a major r

Re: [Numpy-discussion] feature request - increment counter on write check

2015-09-11 Thread Nathaniel Smith
On Sep 11, 2015 6:35 AM, "Anne Archibald" wrote: > > > > On Fri, Sep 11, 2015 at 3:20 PM Sebastian Berg wrote: >> >> On Fr, 2015-09-11 at 13:10 +, Daniel Manson wrote: >> > Originally posted as issue 6301 on github. >> > >> > >> > Presumably any block of code that modifies an ndarray's buffer

Re: [Numpy-discussion] feature request - increment counter on write check

2015-09-11 Thread Daniel
Anne Archibald-3 wrote > ... You'd also have to make sure that all code that tries to write to an > array really checks the writable flag. If there is code out there which modifies arrays without checking the write flag then it's already on buggy-territory. In terms of value vs functions, surely

Re: [Numpy-discussion] feature request - increment counter on write check

2015-09-11 Thread Sebastian Berg
On Fr, 2015-09-11 at 06:00 -0700, Daniel wrote: > >...you would have to "notify" the array itself that it has changed.. > > I don't get what you mean..or maybe I do...? Do you mean that if there are > two arrays with non-overlapping views of the same data then modifying one > will change the mutab

Re: [Numpy-discussion] feature request - increment counter on write check

2015-09-11 Thread Daniel
>...you would have to "notify" the array itself that it has changed.. I don't get what you mean..or maybe I do...? Do you mean that if there are two arrays with non-overlapping views of the same data then modifying one will change the mutablehash of both? That's true I guess, and I hadn't conside

Re: [Numpy-discussion] feature request - increment counter on write check

2015-09-11 Thread Anne Archibald
On Fri, Sep 11, 2015 at 3:20 PM Sebastian Berg wrote: > On Fr, 2015-09-11 at 13:10 +, Daniel Manson wrote: > > Originally posted as issue 6301 on github. > > > > > > Presumably any block of code that modifies an ndarray's buffer is > > wrapped in a (thread safe?) check of the writable flag. W

Re: [Numpy-discussion] feature request - increment counter on write check

2015-09-11 Thread Sebastian Berg
On Fr, 2015-09-11 at 13:10 +, Daniel Manson wrote: > Originally posted as issue 6301 on github. > > > Presumably any block of code that modifies an ndarray's buffer is > wrapped in a (thread safe?) check of the writable flag. Would it be > possible to hold a counter rather than a simple bool

[Numpy-discussion] feature request - increment counter on write check

2015-09-11 Thread Daniel Manson
Originally posted as issue 6301 on github. Presumably any block of code that modifies an ndarray's buffer is wrapped in a (thread safe?) check of the writable flag. Would it be possible to hold a counter rather than a simple bool flag and then increment