Re: [Numpy-discussion] Deprecating `numpy.iterable`

2016-02-11 Thread Nathaniel Smith
Oh wow, yeah, there are tons of uses: https://github.com/search?q=%22np.iterable%22=simplesearch=Code=%E2%9C%93 Meh, I dunno, maybe we're stuck with it. It's not a major maintenance burden at least. -n On Thu, Feb 11, 2016 at 10:25 AM, Stephan Hoyer wrote: > We certainly

Re: [Numpy-discussion] Deprecating `numpy.iterable`

2016-02-11 Thread Benjamin Root
Huh... matplotlib could use that! We have been using our own internal function left over from the numerix days, I think. Ben Root On Thu, Feb 11, 2016 at 2:12 PM, Nathaniel Smith wrote: > Oh wow, yeah, there are tons of uses: > >

Re: [Numpy-discussion] Deprecating `numpy.iterable`

2016-02-11 Thread Joseph Fox-Rabinovitz
It appears that deprecating `numpy.iterable` would be counterproductive. I have reverted my PR to just making the return value an actual `bool` instead of an `int`. On Thu, Feb 11, 2016 at 2:54 PM, Benjamin Root wrote: > Huh... matplotlib could use that! We have been using

Re: [Numpy-discussion] Deprecating `numpy.iterable`

2016-02-11 Thread Stephan Hoyer
We certainly can (and probably should) deprecate this, but we can't remove it for a very long time. np.iterable is used in a lot of third party code. On Wed, Feb 10, 2016 at 7:09 PM, Joseph Fox-Rabinovitz < jfoxrabinov...@gmail.com> wrote: > I have created a PR to deprecate `np.iterable` >

[Numpy-discussion] Deprecating `numpy.iterable`

2016-02-10 Thread Joseph Fox-Rabinovitz
I have created a PR to deprecate `np.iterable` (https://github.com/numpy/numpy/pull/7202). It is a very old function, introduced as a utility in 2005 (https://github.com/numpy/numpy/commit/052a7b2e3276a303be1083022fc24d43084d2e14), and there is no good reason for it to be part of the public API.