Re: [Numpy-discussion] PR #7083: ENH: Added 'doane' and 'sqrt' estimators to np.histogram

[Joseph Fox-Rabinovitz]

Where can I find the output of the tests on GitHub? I seem to be having 
trouble locating them.
-Joe
Sent from my LG Optimus L70™


-- Original message--From: Jaime Fernández del RíoDate: Thu, Jan 21, 
2016 02:17To: Discussion of Numerical Python;Subject:Re: [Numpy-discussion] PR 
#7083: ENH: Added 'doane' and 'sqrt' estimators to np.histogramThe tests are 
not passing, seems like you are taking the sqrt of a negative number, may want 
to check the inputs and raise a more informative error (and add a test for it).
Jaime
On Thu, Jan 21, 2016 at 7:51 AM, Joseph Fox-Rabinovitz 
 wrote:
Please let me know if there is anything wrong or missing. I have added
a couple of estimators that I find useful sometimes.

    -Joe
___
NumPy-Discussion mailing list
NumPy-Discussion@scipy.org
https://mail.scipy.org/mailman/listinfo/numpy-discussion



-- 
(__/)
( O.o)
( > <) Este es Conejo. Copia a Conejo en tu firma y ayúdale en sus planes de 
dominación mundial.___
NumPy-Discussion mailing list
NumPy-Discussion@scipy.org
https://mail.scipy.org/mailman/listinfo/numpy-discussion

Re: [Numpy-discussion] PR #7083: ENH: Added 'doane' and 'sqrt' estimators to np.histogram

[Joseph Fox-Rabinovitz]

I fixed the issue by checking if x.size > 2 before the calculation. An
error should never need to be raised at that point. The build passes
now and the results appear to be correct.

On Thu, Jan 21, 2016 at 2:17 AM, Jaime Fernández del Río
 wrote:
> The tests are not passing, seems like you are taking the sqrt of a negative
> number, may want to check the inputs and raise a more informative error (and
> add a test for it).
>
> Jaime
>
> On Thu, Jan 21, 2016 at 7:51 AM, Joseph Fox-Rabinovitz
>  wrote:
>>
>> Please let me know if there is anything wrong or missing. I have added
>> a couple of estimators that I find useful sometimes.
>>
>> -Joe
>> ___
>> NumPy-Discussion mailing list
>> NumPy-Discussion@scipy.org
>> https://mail.scipy.org/mailman/listinfo/numpy-discussion
>
>
>
>
> --
> (\__/)
> ( O.o)
> ( > <) Este es Conejo. Copia a Conejo en tu firma y ayúdale en sus planes de
> dominación mundial.
>
> ___
> NumPy-Discussion mailing list
> NumPy-Discussion@scipy.org
> https://mail.scipy.org/mailman/listinfo/numpy-discussion
>
___
NumPy-Discussion mailing list
NumPy-Discussion@scipy.org
https://mail.scipy.org/mailman/listinfo/numpy-discussion

Re: [Numpy-discussion] PR #7083: ENH: Added 'doane' and 'sqrt' estimators to np.histogram

[Joseph Fox-Rabinovitz]

Due to a mistake I made in my branch structure, I have replaced this
PR with #7090: https://github.com/numpy/numpy/pull/7090. All of the
changes and fixes so far are squashed into the new request.

-Joe

On Thu, Jan 21, 2016 at 1:51 AM, Joseph Fox-Rabinovitz
 wrote:
> Please let me know if there is anything wrong or missing. I have added
> a couple of estimators that I find useful sometimes.
>
> -Joe
___
NumPy-Discussion mailing list
NumPy-Discussion@scipy.org
https://mail.scipy.org/mailman/listinfo/numpy-discussion

[Numpy-discussion] PR #7083: ENH: Added 'doane' and 'sqrt' estimators to np.histogram

[Joseph Fox-Rabinovitz]

Please let me know if there is anything wrong or missing. I have added
a couple of estimators that I find useful sometimes.

-Joe
___
NumPy-Discussion mailing list
NumPy-Discussion@scipy.org
https://mail.scipy.org/mailman/listinfo/numpy-discussion

Re: [Numpy-discussion] PR #7083: ENH: Added 'doane' and 'sqrt' estimators to np.histogram

[Jaime Fernández del Río]

The tests are not passing, seems like you are taking the sqrt of a negative
number, may want to check the inputs and raise a more informative error
(and add a test for it).

Jaime

On Thu, Jan 21, 2016 at 7:51 AM, Joseph Fox-Rabinovitz <
jfoxrabinov...@gmail.com> wrote:

> Please let me know if there is anything wrong or missing. I have added
> a couple of estimators that I find useful sometimes.
>
> -Joe
> ___
> NumPy-Discussion mailing list
> NumPy-Discussion@scipy.org
> https://mail.scipy.org/mailman/listinfo/numpy-discussion
>



-- 
(\__/)
( O.o)
( > <) Este es Conejo. Copia a Conejo en tu firma y ayúdale en sus planes
de dominación mundial.
___
NumPy-Discussion mailing list
NumPy-Discussion@scipy.org
https://mail.scipy.org/mailman/listinfo/numpy-discussion