Re: [Numpy-discussion] PR 8053 np.random.multinomial tolerance param

2016-09-27 Thread Alex Beloi
-Discussion [mailto:numpy-discussion-boun...@scipy.org] On Behalf Of Stephan Hoyer Sent: Monday, September 26, 2016 11:59 AM To: Discussion of Numerical Python Subject: Re: [Numpy-discussion] PR 8053 np.random.multinomial tolerance param I would actually be just as happy to relax the tolerance here to

Re: [Numpy-discussion] PR 8053 np.random.multinomial tolerance param

2016-09-26 Thread Stephan Hoyer
I would actually be just as happy to relax the tolerance here to 1e-8 always. I doubt this would catch any fewer bugs than the current default. In contrast, adding new parameters adds cognitive overload for everyone encountering the function. Also, for your use case note that tensorflow has it's o

[Numpy-discussion] PR 8053 np.random.multinomial tolerance param

2016-09-26 Thread Alex Beloi
Hello, Pull Request: https://github.com/numpy/numpy/pull/8053 I would like to expose a tolerance parameter for the function numpy.random.multinomial. The function `multinomial(n, pvals, size=None)` correctly raises exception when `sum(pvals) > 1 + 1e-12` as these values should sum to 1.