Re: [Numpy-discussion] Proposal: add `force=` or `copy=` kwarg to `__array__` interface

2020-04-28 Thread Sebastian Berg
On Tue, 2020-04-28 at 11:51 +0200, Ralf Gommers wrote: > > So arguably, there is no type-safety concern due to `.detach()`. > > I'm not sure what the question is here; no one mentioned type-safety. > The > PyTorch maintainers have already said they're fine with adding a > force > keyword. But

[Numpy-discussion] NumPy Community Meeting Wednesday

2020-04-28 Thread Sebastian Berg
Hi all, There will be a NumPy Community meeting Wednesday April 29th at 1pm Pacific Time (20:00 UTC). Everyone is invited and encouraged to join in and edit the work-in-progress meeting topics and notes: https://hackmd.io/76o-IxCjQX2mOXO_wwkcpg?both Best wishes Sebastian

Re: [Numpy-discussion] Proposal: add `force=` or `copy=` kwarg to `__array__` interface

2020-04-28 Thread Sebastian Berg
On Tue, 2020-04-28 at 09:58 -0500, Sebastian Berg wrote: > On Tue, 2020-04-28 at 11:51 +0200, Ralf Gommers wrote: > > > > So arguably, there is no type-safety concern due to `.detach()`. > > > > I'm not sure what the question is here; no one mentioned type- > > safety. > > The > > PyTorch

Re: [Numpy-discussion] Proposal: add `force=` or `copy=` kwarg to `__array__` interface

2020-04-28 Thread Ralf Gommers
On Mon, Apr 27, 2020 at 12:10 AM Sebastian Berg wrote: > On Sat, 2020-04-25 at 10:52 -0700, Stephan Hoyer wrote: > > On Sat, Apr 25, 2020 at 10:40 AM Ralf Gommers > > > > wrote: > > > > > > > > On Fri, Apr 24, 2020 at 12:35 PM Eric Wieser < > > > wieser.eric+nu...@gmail.com> > > > wrote: > > >

Re: [Numpy-discussion] Proposal: add `force=` or `copy=` kwarg to `__array__` interface

2020-04-28 Thread Hameer Abbasi
Hi! Yes, I would advocate for a `force=` kwarg but personally I don't think it's explicit enough, but probably as explicit as can be given NumPy's API. Personally, I'd also raise a warning within PyData/Sparse and I hope it's in big bold letters in the docs in NumPy to be careful with this.