[Numpy-discussion] 1.19.x branch

2020-04-29 Thread Charles R Harris
Hi All, I thinking of making the 1.19.x branch in about two weeks. If there are PRs that you feel need to be in that release please let me know. Chuck ___ NumPy-Discussion mailing list NumPy-Discussion@python.org

Re: [Numpy-discussion] Proposal: add `force=` or `copy=` kwarg to `__array__` interface

2020-04-29 Thread Sebastian Berg
On Wed, 2020-04-29 at 05:26 -0500, Juan Nunez-Iglesias wrote: > Hi everyone, and thank you Ralf for carrying the flag in my absence. > =D > > Sebastian, the *primary* motivation behind avoiding detach() in > PyTorch is listed in original post of the PyTorch issue: > > > People not very familiar

Re: [Numpy-discussion] Proposal: add `force=` or `copy=` kwarg to `__array__` interface

2020-04-29 Thread Ralf Gommers
On Tue, Apr 28, 2020 at 5:03 PM Sebastian Berg wrote: > On Tue, 2020-04-28 at 11:51 +0200, Ralf Gommers wrote: > > > > So arguably, there is no type-safety concern due to `.detach()`. > > > > I'm not sure what the question is here; no one mentioned type-safety. > > The > > PyTorch maintainers

Re: [Numpy-discussion] Proposal: add `force=` or `copy=` kwarg to `__array__` interface

2020-04-29 Thread Ralf Gommers
On Wed, Apr 29, 2020 at 12:27 PM Juan Nunez-Iglesias wrote: > > > Ralf, you said you don't want warnings — even for sparse arrays? That was > an area of concern for you on the PyTorch discussion side. > Providing a boolean keyword argument and then raising a warning every time anyone uses that

Re: [Numpy-discussion] Proposal: add `force=` or `copy=` kwarg to `__array__` interface

2020-04-29 Thread Juan Nunez-Iglesias
Hi everyone, and thank you Ralf for carrying the flag in my absence. =D Sebastian, the *primary* motivation behind avoiding detach() in PyTorch is listed in original post of the PyTorch issue: > People not very familiar with `requires_grad` and cpu/gpu Tensors might go > back and forth with