Re: [Numpy-discussion] __array_function related regression for 1.17.0rc1

2019-07-05 Thread Ralf Gommers
On Tue, Jul 2, 2019 at 1:15 PM Ralf Gommers wrote: > > > On Tue, Jul 2, 2019 at 8:38 AM Stephan Hoyer wrote: > >> On Tue, Jul 2, 2019 at 8:16 AM Ralf Gommers >> wrote: >> >>> >>> >>> On Tue, Jul 2, 2019 at 1:45 AM Juan Nunez-Iglesias >>> wrote: >>> On Tue, 2 Jul 2019, at 4:34 PM, Stephan

Re: [Numpy-discussion] __array_function related regression for 1.17.0rc1

2019-07-02 Thread Ralf Gommers
On Tue, Jul 2, 2019 at 8:38 AM Stephan Hoyer wrote: > On Tue, Jul 2, 2019 at 8:16 AM Ralf Gommers > wrote: > >> >> >> On Tue, Jul 2, 2019 at 1:45 AM Juan Nunez-Iglesias >> wrote: >> >>> On Tue, 2 Jul 2019, at 4:34 PM, Stephan Hoyer wrote: >>> >>> This is addressed in the NEP, see bullet 1 under

Re: [Numpy-discussion] __array_function related regression for 1.17.0rc1

2019-07-02 Thread Stephan Hoyer
On Tue, Jul 2, 2019 at 8:16 AM Ralf Gommers wrote: > > > On Tue, Jul 2, 2019 at 1:45 AM Juan Nunez-Iglesias > wrote: > >> On Tue, 2 Jul 2019, at 4:34 PM, Stephan Hoyer wrote: >> >> This is addressed in the NEP, see bullet 1 under "Partial implementation >> of NumPy's API": >> >> http://www.numpy

Re: [Numpy-discussion] __array_function related regression for 1.17.0rc1

2019-07-02 Thread Stephan Hoyer
On Tue, Jul 2, 2019 at 1:46 AM Juan Nunez-Iglesias wrote: > I'm also wondering where the list of functions that must be implemented > can be found, so that libraries like dask and CuPy can be sure that they > have a complete implementation, and further typeerrors won't be raised with > their arra

Re: [Numpy-discussion] __array_function related regression for 1.17.0rc1

2019-07-02 Thread Ralf Gommers
On Tue, Jul 2, 2019 at 1:45 AM Juan Nunez-Iglesias wrote: > On Tue, 2 Jul 2019, at 4:34 PM, Stephan Hoyer wrote: > > This is addressed in the NEP, see bullet 1 under "Partial implementation > of NumPy's API": > > http://www.numpy.org/neps/nep-0018-array-function-protocol.html#partial-implementati

Re: [Numpy-discussion] __array_function related regression for 1.17.0rc1

2019-07-02 Thread Juan Nunez-Iglesias
On Tue, 2 Jul 2019, at 4:34 PM, Stephan Hoyer wrote: > This is addressed in the NEP, see bullet 1 under "Partial implementation of > NumPy's API": > http://www.numpy.org/neps/nep-0018-array-function-protocol.html#partial-implementation-of-numpy-s-api > > My concern is that fallback coercion behav

Re: [Numpy-discussion] __array_function related regression for 1.17.0rc1

2019-07-01 Thread Stephan Hoyer
> > Your suggestion on the issue to switch from typeerror to warning is, imho, >> much better, as long as the warning contains a link to an issue/webpage >> explaining what needs to happen. It's only because I've been vaguely aware >> of the `__array_function__` discussions that I was able to diagn

Re: [Numpy-discussion] __array_function related regression for 1.17.0rc1

2019-06-30 Thread Ralf Gommers
On Mon, Jul 1, 2019 at 7:37 AM Juan Nunez-Iglesias wrote: > > > On Mon, 1 Jul 2019, at 2:34 PM, Ralf Gommers wrote: > > This issue is not very surprising - __array_function__ is going to have a > fair bit of backwards compat impact for people who were relying on feeding > all sorts of stuff into

Re: [Numpy-discussion] __array_function related regression for 1.17.0rc1

2019-06-30 Thread Juan Nunez-Iglesias
On Mon, 1 Jul 2019, at 2:34 PM, Ralf Gommers wrote: > This issue is not very surprising - __array_function__ is going to have a > fair bit of backwards compat impact for people who were relying on feeding > all sorts of stuff into numpy functions that previously got converted with > asarray. A