Re: [Numpy-discussion] how to name "contagious" keyword in np.ma.convolve

2016-10-19 Thread Pierre Haessig
Le 19/10/2016 à 01:18, Allan Haldane a écrit : > Based on feedback so far, I think "propagate_mask" sounds like the best > word to use. Let's go with that. > > As for whether it should default to "True" or "False", the arguments I > see are: > > * False, because that is the way most functions

Re: [Numpy-discussion] how to name "contagious" keyword in np.ma.convolve

2016-10-18 Thread Stephan Hoyer
On Tue, Oct 18, 2016 at 4:18 PM, Allan Haldane wrote: > As for whether it should default to "True" or "False", the arguments I > see are: > > * False, because that is the way most functions like `np.ma.sum` >already work, as well as matlab and octave's similar

Re: [Numpy-discussion] how to name "contagious" keyword in np.ma.convolve

2016-10-18 Thread Allan Haldane
On 10/17/2016 01:01 PM, Pierre Haessig wrote: > Le 16/10/2016 à 11:52, Hanno Klemm a écrit : >> When I have similar situations, I usually interpolate between the valid >> values. I assume there are a lot of use cases for convolutions but I have >> difficulties imagining that ignoring a missing

Re: [Numpy-discussion] how to name "contagious" keyword in np.ma.convolve

2016-10-18 Thread Allan Haldane
On 10/16/2016 05:52 AM, Hanno Klemm wrote: > > >> On 16 Oct 2016, at 03:21, Allan Haldane wrote: >> >>> On 10/14/2016 07:49 PM, Juan Nunez-Iglesias wrote: >>> +1 for propagate_mask. That is the only proposal that immediately makes >>> sense to me. "contagious" may be

Re: [Numpy-discussion] how to name "contagious" keyword in np.ma.convolve

2016-10-18 Thread Allan Haldane
On 10/17/2016 01:01 PM, Pierre Haessig wrote: > Hi, > > > Le 16/10/2016 à 11:52, Hanno Klemm a écrit : >> When I have similar situations, I usually interpolate between the valid >> values. I assume there are a lot of use cases for convolutions but I have >> difficulties imagining that ignoring

Re: [Numpy-discussion] how to name "contagious" keyword in np.ma.convolve

2016-10-18 Thread josef . pktd
On Tue, Oct 18, 2016 at 1:30 PM, wrote: > On Tue, Oct 18, 2016 at 1:25 PM, wrote: >> On Mon, Oct 17, 2016 at 1:01 PM, Pierre Haessig >> wrote: >>> Hi, >>> >>> >>> Le 16/10/2016 à 11:52, Hanno Klemm a écrit : When I

Re: [Numpy-discussion] how to name "contagious" keyword in np.ma.convolve

2016-10-18 Thread josef . pktd
On Tue, Oct 18, 2016 at 1:25 PM, wrote: > On Mon, Oct 17, 2016 at 1:01 PM, Pierre Haessig > wrote: >> Hi, >> >> >> Le 16/10/2016 à 11:52, Hanno Klemm a écrit : >>> When I have similar situations, I usually interpolate between the valid >>>

Re: [Numpy-discussion] how to name "contagious" keyword in np.ma.convolve

2016-10-18 Thread josef . pktd
On Mon, Oct 17, 2016 at 1:01 PM, Pierre Haessig wrote: > Hi, > > > Le 16/10/2016 à 11:52, Hanno Klemm a écrit : >> When I have similar situations, I usually interpolate between the valid >> values. I assume there are a lot of use cases for convolutions but I have >>

Re: [Numpy-discussion] how to name "contagious" keyword in np.ma.convolve

2016-10-17 Thread Pierre Haessig
Hi, Le 16/10/2016 à 11:52, Hanno Klemm a écrit : > When I have similar situations, I usually interpolate between the valid > values. I assume there are a lot of use cases for convolutions but I have > difficulties imagining that ignoring a missing value and, for the purpose of > the

Re: [Numpy-discussion] how to name "contagious" keyword in np.ma.convolve

2016-10-16 Thread Hanno Klemm
> On 16 Oct 2016, at 03:21, Allan Haldane wrote: > >> On 10/14/2016 07:49 PM, Juan Nunez-Iglesias wrote: >> +1 for propagate_mask. That is the only proposal that immediately makes >> sense to me. "contagious" may be cute but I think approximately 0% of >> users would

Re: [Numpy-discussion] how to name "contagious" keyword in np.ma.convolve

2016-10-15 Thread Allan Haldane
On 10/14/2016 07:49 PM, Juan Nunez-Iglesias wrote: +1 for propagate_mask. That is the only proposal that immediately makes sense to me. "contagious" may be cute but I think approximately 0% of users would guess its purpose on first use. Can you elaborate on what happens with the masks exactly?

Re: [Numpy-discussion] how to name "contagious" keyword in np.ma.convolve

2016-10-14 Thread Juan Nunez-Iglesias
+1 for propagate_mask. That is the only proposal that immediately makes sense to me. "contagious" may be cute but I think approximately 0% of users would guess its purpose on first use. Can you elaborate on what happens with the masks exactly? I didn't quite get why propagate_mask=False was

Re: [Numpy-discussion] how to name "contagious" keyword in np.ma.convolve

2016-10-14 Thread Allan Haldane
I think the possibilities that have been mentioned so far (here or in the PR) are: contagious contagious_mask propagate propagate_mask propagated `propogate_mask=False` seemed to imply that the mask would never be set, so Eric also suggested propagate_mask='any' or propagate_mask='all' I would

Re: [Numpy-discussion] how to name "contagious" keyword in np.ma.convolve

2016-10-14 Thread Benjamin Root
Why not "propagated"? On Fri, Oct 14, 2016 at 1:08 PM, Sebastian Berg wrote: > On Fr, 2016-10-14 at 13:00 -0400, Allan Haldane wrote: > > Hi all, > > > > Eric Wieser has a PR which defines new functions np.ma.correlate and > > np.ma.convolve: > > > >

Re: [Numpy-discussion] how to name "contagious" keyword in np.ma.convolve

2016-10-14 Thread Sebastian Berg
On Fr, 2016-10-14 at 13:00 -0400, Allan Haldane wrote: > Hi all, > > Eric Wieser has a PR which defines new functions np.ma.correlate and > np.ma.convolve: > > https://github.com/numpy/numpy/pull/7922 > > We're deciding how to name the keyword arg which determines whether > masked elements are