[Nunit-core] [Merge] lp:~charlie.poole/nunit-3.0/nunitlite into lp:nunit-3.0 updated

2009-09-17 Thread Charlie Poole
The proposal to merge lp:~charlie.poole/nunit-3.0/nunitlite into lp:nunit-3.0 has been updated. Status: Needs review => Approved -- https://code.launchpad.net/~charlie.poole/nunit-3.0/nunitlite/+merge/11814 Your team NUnit Developers is subscribed to branch lp:nunit-3.0. ___

Re: [Nunit-core] [Merge] lp:~charlie.poole/nunit-3.0/nunitlite into lp:nunit-3.0

2009-09-17 Thread Andreas Schlapsi
Review: Approve The problem appears also in trunk. We should fix this there. > I should mention that the path tests are intended to work on > both Windows and Linux, so it's probably worthwhile figuring > out why they don't work. Surprise is bad. Assuming the same > problem already exists in the t

Re: [Nunit-core] [Merge] lp:~charlie.poole/nunit-3.0/nunitlite into lp:nunit-3.0

2009-09-17 Thread Charlie Poole
I should mention that the path tests are intended to work on both Windows and Linux, so it's probably worthwhile figuring out why they don't work. Surprise is bad. Assuming the same problem already exists in the trunk, I'd like to get the trunk updated and then deal with this issue. Charlie > -

Re: [Nunit-core] [Merge] lp:~charlie.poole/nunit-3.0/nunitlite into lp:nunit-3.0

2009-09-17 Thread Charlie Poole
I've been hoping to get the merge done before moving on to Linux. Is this a new issue? That is, are these errors that trunk does not have? If I'm not creating new errors, my tendency is to go ahead and do the merge. Charlie > -Original Message- > From: boun...@canonical.com [mailto:boun.

Re: [Nunit-core] [Merge] lp:~charlie.poole/nunit-3.0/nunitlite into lp:nunit-3.0

2009-09-17 Thread Andreas Schlapsi
Review: Needs Fixing Running the tests on OpenSUSE (Mono 2.0) results in 16 failures: * 13 in the test fixtures SamePathTest_Windows and SamePathOrUnderTest_Windows * 3 in SamePathOrUnderTest_Linux: SucceedsWithGoodValues with following test data: - \folder1\file.tmp - \folder1\folder

Re: [Nunit-core] [Merge] lp:~charlie.poole/nunit-3.0/nunitlite into lp:nunit-3.0

2009-09-16 Thread Charlie Poole
I fixed this. It was a case of too aggressive entries in the .bzrignore file. Charlie > -Original Message- > From: boun...@canonical.com [mailto:boun...@canonical.com] On > Behalf Of Andreas Schlapsi > Sent: Tuesday, September 15, 2009 4:34 PM > To: Charlie Poole > Subject: Re: [Merge]

Re: [Nunit-core] [Merge] lp:~charlie.poole/nunit-3.0/nunitlite into lp:nunit-3.0

2009-09-16 Thread Andreas Schlapsi
Review: Needs Fixing The solution for VS2008 references projects (nunitlite_CF.tests, NUnitLiteTests) which cannot be found after branching. The project for the NUnitLite runner does not exist in the solution. -- https://code.launchpad.net/~charlie.poole/nunit-3.0/nunitlite/+merge/11814 Your tea

Re: [Nunit-core] [Merge] lp:~charlie.poole/nunit-3.0/nunitlite into lp:nunit-3.0

2009-09-16 Thread Charlie Poole
Strange! They were in the code I pushed. I'll try to figure out what happened. Charlie > -Original Message- > From: boun...@canonical.com [mailto:boun...@canonical.com] On > Behalf Of Andreas Schlapsi > Sent: Tuesday, September 15, 2009 4:34 PM > To: Charlie Poole > Subject: Re: [Merge]