[Nut-upsdev] [PATCH] Fix logic error in rhino driver

2011-10-14 Thread Thomas Jarosch
The if() statement always evaluated to true. Detected by cppcheck, not tested on real hardware. Signed-off-by: Thomas Jarosch thomas.jaro...@intra2net.com --- drivers/rhino.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/rhino.c b/drivers/rhino.c index

Re: [Nut-upsdev] [PATCH] Fix logic error in rhino driver

2011-10-14 Thread Stuart D Gathman
On 10/14/2011 06:10 PM, Regid Ichira wrote: The if() statement always evaluated to true. Detected by cppcheck, not tested on real hardware. - if( ( BattVoltage 129 ) || ( BattVoltage 144 ) ) + if( ( BattVoltage 129 ) ( BattVoltage 144 ) ) I think the current, ||, logic is