Re: [Nut-upsdev] [PATCH 1/3] Skip non-feature HID reports

2018-02-18 Thread Charles Lepple
On Feb 16, 2018, at 6:55 AM, Russell King wrote: > > Hence, libusb_get_report() always requests the report ID as a feature > report, and never uses the report type that was stored. > My apologies. I saw the HIDData_t pointer (with its report type field) getting passed down to HIDGetItemData(),

Re: [Nut-upsdev] [PATCH 1/3] Skip non-feature HID reports

2018-02-16 Thread Russell King
Hi Charles, Sorry for the long email, I feel this deserves a fuller explanation. On Wed, Feb 14, 2018 at 10:30:18PM -0500, Charles Lepple wrote: > On Feb 3, 2018, at 7:19 PM, Russell King wrote: > > > > Input and Output reports are used for interrupt endpoints rather than > > control endpoints.

Re: [Nut-upsdev] [PATCH 1/3] Skip non-feature HID reports

2018-02-14 Thread Charles Lepple
On Feb 3, 2018, at 7:19 PM, Russell King wrote: > > Input and Output reports are used for interrupt endpoints rather than > control endpoints. HIDGetItemData() only ever requests feature > report IDs, and requesting non-feature report IDs as feature IDs may > lead to undesirable results and