[
https://issues.apache.org/jira/browse/NUTCH-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12505598
]
Andrzej Bialecki commented on NUTCH-485:
-
Whitespace changes should be committed as a separate patch, if
[
https://issues.apache.org/jira/browse/NUTCH-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12505456
]
Doğacan Güney commented on NUTCH-485:
-
If no one has any objections, I want to commit this one.
However, I have
[
https://issues.apache.org/jira/browse/NUTCH-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12505502
]
Chris A. Mattmann commented on NUTCH-485:
-
Doğacan, +1.
As for your question, IMO, these type of minor
[
https://issues.apache.org/jira/browse/NUTCH-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12501914
]
Gal Nitzan commented on NUTCH-485:
--
Could one of the commiters, review this patch and maybe submit it please?
The
[
https://issues.apache.org/jira/browse/NUTCH-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12495350
]
Doğacan Güney commented on NUTCH-485:
-
You probably should not add put(String/Text key, Parse parse) methods to
[
https://issues.apache.org/jira/browse/NUTCH-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12495410
]
Doğacan Güney commented on NUTCH-485:
-
I have two more minor nits:
1) ParseResult.isSuccess returns true only if
[
https://issues.apache.org/jira/browse/NUTCH-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12495319
]
Andrzej Bialecki commented on NUTCH-485:
-
I think a more natural change would be this:
ParseResult
