Re: [Nutch-cvs] svn commit: r516888 - /lucene/nutch/trunk/bin/nutch
Andrzej Bialecki wrote:
Sami Siren wrote:
How the code ended up in this place on Linux? The $cygwin condition
should have prevented that, because it evaluates to true only on Cygwin,
where this utility is required to translate the paths.
You also changed the if syntax - before it was using the /bin/test
utility to evaluate the expression, now it uses a shell built-in - I'm
not sure if these two follow the same evaluation rules on all supported
platforms ... Please revert it to the earlier syntax.
revert it so it desn't work on linux, are you sure?
I'll make a patch and check that it works on Linux too - apparently it
was me who botched the AND syntax in my previous commit... ;)
The effect of this problem was not purely cosmetic. I just realized it
disables the native libs because JAVA_LIBRARY_PATH does not get set. If
I change the if to
if [ test $cygwin -a X${JAVA_LIBRARY_PATH} != X ]; then
JAVA_LIBRARY_PATH=`cygpath -p -w $JAVA_LIBRARY_PATH`
fi
it works, ok for me.
--
Sami SIren
Re: [Nutch-cvs] svn commit: r516888 - /lucene/nutch/trunk/bin/nutch
I change the if to
if [ test $cygwin -a X${JAVA_LIBRARY_PATH} != X ]; then
JAVA_LIBRARY_PATH=`cygpath -p -w $JAVA_LIBRARY_PATH`
fi
it works, ok for me.
eh, forget that part :)
--
Sami Siren
Re: [Nutch-cvs] svn commit: r516888 - /lucene/nutch/trunk/bin/nutch
Sami Siren wrote: How the code ended up in this place on Linux? The $cygwin condition should have prevented that, because it evaluates to true only on Cygwin, where this utility is required to translate the paths. You also changed the if syntax - before it was using the /bin/test utility to evaluate the expression, now it uses a shell built-in - I'm not sure if these two follow the same evaluation rules on all supported platforms ... Please revert it to the earlier syntax. revert it so it desn't work on linux, are you sure? I'll make a patch and check that it works on Linux too - apparently it was me who botched the AND syntax in my previous commit... ;) -- Best regards, Andrzej Bialecki ___. ___ ___ ___ _ _ __ [__ || __|__/|__||\/| Information Retrieval, Semantic Web ___|||__|| \| || | Embedded Unix, System Integration http://www.sigram.com Contact: info at sigram dot com
Re: [Nutch-cvs] svn commit: r516888 - /lucene/nutch/trunk/bin/nutch
[EMAIL PROTECTED] wrote:
Author: siren
Date: Sun Mar 11 04:12:23 2007
New Revision: 516888
URL: http://svn.apache.org/viewvc?view=revrev=516888
Log:
fix bin/nutch: line 152: cygpath: command not found on linux (FC5), hope i am
not breaking it for some other env
Modified:
lucene/nutch/trunk/bin/nutch
Modified: lucene/nutch/trunk/bin/nutch
URL:
http://svn.apache.org/viewvc/lucene/nutch/trunk/bin/nutch?view=diffrev=516888r1=516887r2=516888
==
--- lucene/nutch/trunk/bin/nutch (original)
+++ lucene/nutch/trunk/bin/nutch Sun Mar 11 04:12:23 2007
@@ -148,7 +148,7 @@
fi
fi
-if [ $cygwin -a X${JAVA_LIBRARY_PATH} != X ]; then
+if $cygwin -a X${JAVA_LIBRARY_PATH} != X; then
JAVA_LIBRARY_PATH=`cygpath -p -w $JAVA_LIBRARY_PATH`
fi
Again, this should have been discussed first.
How the code ended up in this place on Linux? The $cygwin condition
should have prevented that, because it evaluates to true only on Cygwin,
where this utility is required to translate the paths.
You also changed the if syntax - before it was using the /bin/test
utility to evaluate the expression, now it uses a shell built-in - I'm
not sure if these two follow the same evaluation rules on all supported
platforms ... Please revert it to the earlier syntax.
--
Best regards,
Andrzej Bialecki
___. ___ ___ ___ _ _ __
[__ || __|__/|__||\/| Information Retrieval, Semantic Web
___|||__|| \| || | Embedded Unix, System Integration
http://www.sigram.com Contact: info at sigram dot com
Re: [Nutch-cvs] svn commit: r516888 - /lucene/nutch/trunk/bin/nutch
How the code ended up in this place on Linux? The $cygwin condition should have prevented that, because it evaluates to true only on Cygwin, where this utility is required to translate the paths. You also changed the if syntax - before it was using the /bin/test utility to evaluate the expression, now it uses a shell built-in - I'm not sure if these two follow the same evaluation rules on all supported platforms ... Please revert it to the earlier syntax. revert it so it desn't work on linux, are you sure? -- Sami Siren
Re: [Nutch-cvs] svn commit: r516888 - /lucene/nutch/trunk/bin/nutch
Andrzej Bialecki wrote:
[EMAIL PROTECTED] wrote:
Author: siren
Date: Sun Mar 11 04:12:23 2007
New Revision: 516888
URL: http://svn.apache.org/viewvc?view=revrev=516888
Log:
fix bin/nutch: line 152: cygpath: command not found on linux (FC5),
hope i am not breaking it for some other env
Modified:
lucene/nutch/trunk/bin/nutch
Modified: lucene/nutch/trunk/bin/nutch
URL:
http://svn.apache.org/viewvc/lucene/nutch/trunk/bin/nutch?view=diffrev=516888r1=516887r2=516888
==
--- lucene/nutch/trunk/bin/nutch (original)
+++ lucene/nutch/trunk/bin/nutch Sun Mar 11 04:12:23 2007
@@ -148,7 +148,7 @@
fi
fi
-if [ $cygwin -a X${JAVA_LIBRARY_PATH} != X ]; then
+if $cygwin -a X${JAVA_LIBRARY_PATH} != X; then
JAVA_LIBRARY_PATH=`cygpath -p -w $JAVA_LIBRARY_PATH`
fi
Again, this should have been discussed first.
I reverted it and reopened NUTCH-432.
--
Sami Siren
