vdimm_bus_unregister(vpmem->nvdimm_bus);
Thank you for adding me.
The patch seems correct to me. Will test this as well.
Acked-by: Pankaj Gupta
Thanks,
Pankaj
+ virtio_reset_device(vdev);
> nvdimm_bus_unregister(vpmem->nvdimm_bus);
> out_vq:
> vdev->config->del_vqs(vdev);
IIRC Similar fix was submitted by msft in the past while proposing support for
PCI BAR with virtio pmem and I tested it. Feel free to add.
Acked-by: Pankaj Gupta
//marc.info/?l=linux-kernel=157446316409937=2
>
> Pankaj Gupta (2):
> virtio-pmem: Async virtio-pmem flush
> pmem: enable pmem_submit_bio for asynchronous flush
>
> drivers/nvdimm/nd_virtio.c | 72
> drivers/nvdimm/pmem.c| 17
From: Pankaj Gupta
Return from "pmem_submit_bio" when asynchronous flush is in
process in other context.
Signed-off-by: Pankaj Gupta
---
drivers/nvdimm/pmem.c | 17 -
1 file changed, 12 insertions(+), 5 deletions(-)
diff --git a/drivers/nvdimm/pmem.c b/drivers/nvd
From: Pankaj Gupta
Implement asynchronous flush for virtio pmem using work queue
to solve the preflush ordering issue. Also, coalesce the flush
requests when a flush is already in process.
Signed-off-by: Pankaj Gupta
---
drivers/nvdimm/nd_virtio.c | 72
From: Pankaj Gupta
Jeff reported preflush order issue with the existing implementation
of virtio pmem preflush. Dan suggested[1] to implement asynchronous flush
for virtio pmem using work queue as done in md/RAID. This patch series
intends to solve the preflush ordering issue and also makes
> > On a side question: Do you guys have any or plan for Windows guest
> > implementation
> > for virtio-pmem?
>
> Unfortunately, my team doesn't currently have any plans to add a Windows
> virtio-pmem implementation. My team is primarily focused on virtualization
> in client environments, which
> Update virtio-pmem to allow for the pmem region to be specified in either
> guest absolute terms or as a PCI BAR-relative address. This is required
> to support virtio-pmem in Hyper-V, since Hyper-V only allows PCI devices
> to operate on PCI memory ranges defined via BARs.
>
> Virtio-pmem will
ster(vpmem->nvdimm_bus);
> out_vq:
> vdev->config->del_vqs(vdev);
> --
> 2.32.0
Looks good to me, independent to the first patch.
Reviewed-by: Pankaj Gupta
