Re: [PATCH 03/27] iomap: mark the iomap argument to iomap_sector const

On Mon, Jul 19, 2021 at 09:08:20AM -0700, Darrick J. Wong wrote: > IMHO, constifiying functions is a good way to signal to /programmers/ > that they're not intended to touch the arguments, so Yes, that is the point here. Basically the iomap and iter should be pretty much const, and we almost get

Re: [PATCH 03/27] iomap: mark the iomap argument to iomap_sector const

On 19.07.21 г. 19:08, Darrick J. Wong wrote: > On Mon, Jul 19, 2021 at 12:34:56PM +0200, Christoph Hellwig wrote: >> Signed-off-by: Christoph Hellwig > > /me wonders, does this have any significant effect on the generated > code?

Re: [PATCH 03/27] iomap: mark the iomap argument to iomap_sector const

On Mon, Jul 19, 2021 at 12:34:56PM +0200, Christoph Hellwig wrote: > Signed-off-by: Christoph Hellwig /me wonders, does this have any significant effect on the generated code? It's probably a good idea to feed the optimizer as much usage info as we can, though I would imagine that for such a

[PATCH 03/27] iomap: mark the iomap argument to iomap_sector const

Signed-off-by: Christoph Hellwig --- include/linux/iomap.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/include/linux/iomap.h b/include/linux/iomap.h index 093519d91cc9cc..f9c36df6a3061b 100644 --- a/include/linux/iomap.h +++ b/include/linux/iomap.h @@ -91,8 +91,7 @@