Re: [PATCH 08/27] iomap: add the new iomap_iter model

2021-07-26 Thread Christoph Hellwig
On Tue, Jul 20, 2021 at 07:48:38AM +1000, Dave Chinner wrote: > We should avoid namespace conflicts where function names shadow > object types. iomap_iterate() is fine as the function name - there's > no need for abbreviation here because it's not an overly long name. > This will makes it clearly

Re: [PATCH 08/27] iomap: add the new iomap_iter model

2021-07-26 Thread Christoph Hellwig
On Mon, Jul 19, 2021 at 09:56:00AM -0700, Darrick J. Wong wrote: > Linus previously complained to me about filesystem code (especially > iomap since it was "newer") (ab)using loff_t variables to store the > lengths of byte ranges. It was "loff_t length;" (or so willy > recollects) that tripped

Re: [PATCH 08/27] iomap: add the new iomap_iter model

2021-07-19 Thread Dave Chinner
On Mon, Jul 19, 2021 at 12:35:01PM +0200, Christoph Hellwig wrote: > The iomap_iter struct provides a convenient way to package up and > maintain all the arguments to the various mapping and operation > functions. It is operated on using the iomap_iter() function that > is called in loop until

Re: [PATCH 08/27] iomap: add the new iomap_iter model

2021-07-19 Thread Darrick J. Wong
On Mon, Jul 19, 2021 at 12:35:01PM +0200, Christoph Hellwig wrote: > The iomap_iter struct provides a convenient way to package up and > maintain all the arguments to the various mapping and operation > functions. It is operated on using the iomap_iter() function that > is called in loop until

[PATCH 08/27] iomap: add the new iomap_iter model

2021-07-19 Thread Christoph Hellwig
The iomap_iter struct provides a convenient way to package up and maintain all the arguments to the various mapping and operation functions. It is operated on using the iomap_iter() function that is called in loop until the whole range has been processed. Compared to the existing iomap_apply()