BUILD FAILURE: Jackrabbit Oak - Build # 2812 - Still Failing

2020-07-07 Thread Apache Jenkins Server
The Apache Jenkins build system has built Jackrabbit Oak (build #2812) Status: Still Failing Check console output at https://builds.apache.org/job/Jackrabbit%20Oak/2812/ to view the results. Changes: [fortino] OAK-9119: support order by clause in oak-search-elastic Test results: All tests

BUILD FAILURE: Jackrabbit Oak - Build # 2811 - Still Failing

2020-07-07 Thread Apache Jenkins Server
The Apache Jenkins build system has built Jackrabbit Oak (build #2811) Status: Still Failing Check console output at https://builds.apache.org/job/Jackrabbit%20Oak/2811/ to view the results. Changes: [mkataria] OAK-9126: TestFramework: create tests for both lucene and elastic Test results:

Re: [Proposal] Feature toggles

2020-07-07 Thread Julian Sedding
Hi Marcel, I think the API is elegant. Short of running "feature" code in a closure, a "try with resource" block encourages developers to clearly delimit the block of code that is subject to the feature toggle, hopefully resulting in readable code. I'm not sure about the aspect of the

Re: [Proposal] Feature toggles

2020-07-07 Thread Roy Teeuwen
Hey Marcel, As I also mentioned in the JIRA ticket. What is the reasoning to put this in Oak code, and not directly in Felix? I see no clear connection with Oak and you even use a lot of OSGi concepts Greets, Roy > On 7 Jul 2020, at 10:45, Julian Sedding wrote: > > Hi Marcel, > > I think

Re: [Proposal] Feature toggles

2020-07-07 Thread Marcel Reutegger
Hi, I wanted to keep dependencies to a minimum and provide flexibility how features are actually toggled. The proposal only depends on the already existing Oak concept of a Whiteboard. In most cases this indeed means a feature toggle is registered as an OSGi service. Regards Marcel On

Re: [Proposal] Feature toggles

2020-07-07 Thread Marcel Reutegger
Hi, Thanks for the feedback Julian. On 07.07.20, 10:45, "Julian Sedding" wrote: > I'm not sure about the aspect of the implementation, that FeatureToggle > is Closeable and probably often short-lived. Given that the > FeatureToggleAdapter is registered with the whiteboard, and thus likely >