[jira] [Created] (OAK-7319) Remove redundant JavaDoc link to Java 7 API

2018-03-07 Thread Julian Reschke (JIRA)
Julian Reschke created OAK-7319: --- Summary: Remove redundant JavaDoc link to Java 7 API Key: OAK-7319 URL: https://issues.apache.org/jira/browse/OAK-7319 Project: Jackrabbit Oak Issue Type:

[jira] [Commented] (OAK-5506) reject item names with unpaired surrogates early

2018-03-07 Thread JIRA
[ https://issues.apache.org/jira/browse/OAK-5506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16389774#comment-16389774 ] Michael Dürig commented on OAK-5506: [~reschke], I just noticed that we are also using

[jira] [Resolved] (OAK-7317) SegmentParser#parseBlob does not long ids of external blobs

2018-03-07 Thread JIRA
[ https://issues.apache.org/jira/browse/OAK-7317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Dürig resolved OAK-7317. Resolution: Fixed Fix Version/s: 1.10 1.9.0 Fixed at.

[jira] [Comment Edited] (OAK-7299) RDB*Store: update postgresql JDBC driver reference to 42.2.1

2018-03-07 Thread Julian Reschke (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16382164#comment-16382164 ] Julian Reschke edited comment on OAK-7299 at 3/7/18 4:06 PM: - trunk:

[jira] [Updated] (OAK-7299) RDB*Store: update postgresql JDBC driver reference to 42.2.1

2018-03-07 Thread Julian Reschke (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-7299: Fix Version/s: 1.8.3 > RDB*Store: update postgresql JDBC driver reference to 42.2.1 >

[jira] [Updated] (OAK-7299) RDB*Store: update postgresql JDBC driver reference to 42.2.1

2018-03-07 Thread Julian Reschke (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-7299: Labels: candidate_oak_1_6 (was: candidate_oak_1_8) > RDB*Store: update postgresql JDBC driver

[jira] [Commented] (OAK-7317) SegmentParser#parseBlob does not long ids of external blobs

2018-03-07 Thread JIRA
[ https://issues.apache.org/jira/browse/OAK-7317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16389733#comment-16389733 ] Michael Dürig commented on OAK-7317: Ignored test case at http://svn.apache.org/viewvc?rev=1826123=rev

[jira] [Assigned] (OAK-7317) SegmentParser#parseBlob does not long ids of external blobs

2018-03-07 Thread JIRA
[ https://issues.apache.org/jira/browse/OAK-7317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Dürig reassigned OAK-7317: -- Assignee: Michael Dürig > SegmentParser#parseBlob does not long ids of external blobs >

[jira] [Created] (OAK-7318) Add documentation for function indexes

2018-03-07 Thread Tom Blackford (JIRA)
Tom Blackford created OAK-7318: -- Summary: Add documentation for function indexes Key: OAK-7318 URL: https://issues.apache.org/jira/browse/OAK-7318 Project: Jackrabbit Oak Issue Type:

[jira] [Updated] (OAK-7317) SegmentParser#parseBlob does not long ids of external blobs

2018-03-07 Thread JIRA
[ https://issues.apache.org/jira/browse/OAK-7317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Dürig updated OAK-7317: --- Labels: technical_debt tooling (was: technical_debt) > SegmentParser#parseBlob does not long ids of

[jira] [Created] (OAK-7317) SegmentParser#parseBlob does not long ids of external blobs

2018-03-07 Thread JIRA
Michael Dürig created OAK-7317: -- Summary: SegmentParser#parseBlob does not long ids of external blobs Key: OAK-7317 URL: https://issues.apache.org/jira/browse/OAK-7317 Project: Jackrabbit Oak

[jira] [Comment Edited] (OAK-7314) RDB*Store: use SDMAXREV column in RevisionGC query

2018-03-07 Thread Julian Reschke (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16389533#comment-16389533 ] Julian Reschke edited comment on OAK-7314 at 3/7/18 2:34 PM: - trunk:

[jira] [Updated] (OAK-7314) RDB*Store: use SDMAXREV column in RevisionGC query

2018-03-07 Thread Julian Reschke (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-7314: Fix Version/s: 1.8.3 > RDB*Store: use SDMAXREV column in RevisionGC query >

[jira] [Updated] (OAK-7314) RDB*Store: use SDMAXREV column in RevisionGC query

2018-03-07 Thread Julian Reschke (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-7314: Labels: (was: candidate_oak_1_8) > RDB*Store: use SDMAXREV column in RevisionGC query >

[jira] [Commented] (OAK-7316) Greedy ClusterNodeInfo

2018-03-07 Thread Marcel Reutegger (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16389617#comment-16389617 ] Marcel Reutegger commented on OAK-7316: --- Proposed changes are: * If there is no existing unused

[jira] [Resolved] (OAK-7225) Replace AtomicCounter Supplier

2018-03-07 Thread Davide Giannella (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Davide Giannella resolved OAK-7225. --- Resolution: Fixed Fix Version/s: 1.10 1.9.0 in trunk:

[jira] [Resolved] (OAK-7311) Test failure: OSGiIT

2018-03-07 Thread Andrei Dulceanu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulceanu resolved OAK-7311. -- Resolution: Fixed Fixed at r1826091. > Test failure: OSGiIT > > >

[jira] [Comment Edited] (OAK-7204) RDB*Store: update postgresql JDBC driver reference to 42.2.0

2018-03-07 Thread Julian Reschke (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339406#comment-16339406 ] Julian Reschke edited comment on OAK-7204 at 3/7/18 1:19 PM: - trunk:

[jira] [Commented] (OAK-7314) RDB*Store: use SDMAXREV column in RevisionGC query

2018-03-07 Thread Julian Reschke (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16389533#comment-16389533 ] Julian Reschke commented on OAK-7314: - trunk: [r1826096|http://svn.apache.org/r1826096] > RDB*Store:

[jira] [Updated] (OAK-7204) RDB*Store: update postgresql JDBC driver reference to 42.2.0

2018-03-07 Thread Julian Reschke (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-7204: Fix Version/s: 1.8.3 > RDB*Store: update postgresql JDBC driver reference to 42.2.0 >

[jira] [Updated] (OAK-7204) RDB*Store: update postgresql JDBC driver reference to 42.2.0

2018-03-07 Thread Julian Reschke (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-7204: Labels: candidate_oak_1_6 (was: candidate_oak_1_8) > RDB*Store: update postgresql JDBC driver

[jira] [Resolved] (OAK-7314) RDB*Store: use SDMAXREV column in RevisionGC query

2018-03-07 Thread Julian Reschke (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke resolved OAK-7314. - Resolution: Fixed Fix Version/s: 1.10 1.9.0 > RDB*Store: use SDMAXREV

[jira] [Commented] (OAK-7311) Test failure: OSGiIT

2018-03-07 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16389502#comment-16389502 ] Hudson commented on OAK-7311: - Previously failing build now is OK. Passed run: [Jackrabbit Oak

[jira] [Created] (OAK-7316) Greedy ClusterNodeInfo

2018-03-07 Thread Marcel Reutegger (JIRA)
Marcel Reutegger created OAK-7316: - Summary: Greedy ClusterNodeInfo Key: OAK-7316 URL: https://issues.apache.org/jira/browse/OAK-7316 Project: Jackrabbit Oak Issue Type: Improvement

[jira] [Commented] (OAK-7311) Test failure: OSGiIT

2018-03-07 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16389415#comment-16389415 ] Hudson commented on OAK-7311: - Build is still failing. Failed run: [Jackrabbit Oak

[jira] [Updated] (OAK-7315) Remove redundant JavaDoc link to Java 7 API

2018-03-07 Thread Marcel Reutegger (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcel Reutegger updated OAK-7315: -- Affects Version/s: 1.8.3 Merged into 1.8 branch: http://svn.apache.org/r1826093 > Remove

[jira] [Commented] (OAK-7259) Improve SegmentNodeStoreStats to include number of commits per thread and threads currently waiting on the semaphore

2018-03-07 Thread Andrei Dulceanu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16389342#comment-16389342 ] Andrei Dulceanu commented on OAK-7259: -- Added missing dependencies in {{oak-it-osgi}} at r1825996 and

[jira] [Resolved] (OAK-7306) MongoDocumentStore: use transient DocumentStoreException type where appropriate

2018-03-07 Thread Marcel Reutegger (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcel Reutegger resolved OAK-7306. --- Resolution: Fixed Changed in trunk: http://svn.apache.org/r1826092 > MongoDocumentStore: use

[jira] [Commented] (OAK-7311) Test failure: OSGiIT

2018-03-07 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16389335#comment-16389335 ] Hudson commented on OAK-7311: - Build is still failing. Failed run: [Jackrabbit Oak

[jira] [Resolved] (OAK-7315) Remove redundant JavaDoc link to Java 7 API

2018-03-07 Thread Marcel Reutegger (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcel Reutegger resolved OAK-7315. --- Resolution: Fixed Fix Version/s: 1.9.0 Done in trunk: http://svn.apache.org/r1826090 >

[jira] [Updated] (OAK-7315) Remove redundant JavaDoc link to Java 7 API

2018-03-07 Thread Marcel Reutegger (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcel Reutegger updated OAK-7315: -- Summary: Remove redundant JavaDoc link to Java 7 API (was: Link JavaDoc to Java 8) > Remove

[jira] [Commented] (OAK-7315) Link JavaDoc to Java 8

2018-03-07 Thread Marcel Reutegger (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16389329#comment-16389329 ] Marcel Reutegger commented on OAK-7315: --- Turns out the generated JavaDoc actually links to Java 8 even

[jira] [Commented] (OAK-7307) RDBDocumentStore: use transient DocumentStoreException type where appropriate

2018-03-07 Thread Julian Reschke (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16389310#comment-16389310 ] Julian Reschke commented on OAK-7307: - Potentially for

[jira] [Resolved] (OAK-7310) Empty package-info.java causes unnecessary rebuild

2018-03-07 Thread Marcel Reutegger (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcel Reutegger resolved OAK-7310. --- Resolution: Fixed Reverted previous commit: http://svn.apache.org/r1826087 Added the compiler

[jira] [Updated] (OAK-7314) RDB*Store: use SDMAXREV column in RevisionGC query

2018-03-07 Thread Julian Reschke (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-7314: Attachment: OAK-7314.diff > RDB*Store: use SDMAXREV column in RevisionGC query >

[jira] [Updated] (OAK-7314) RDB*Store: use SDMAXREV column in RevisionGC query

2018-03-07 Thread Julian Reschke (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-7314: Description: (oversight when working on OAK-6965, which introduced the column into the DB schema, but

[jira] [Updated] (OAK-7315) Link JavaDoc to Java 8

2018-03-07 Thread Marcel Reutegger (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcel Reutegger updated OAK-7315: -- Affects Version/s: 1.8.0 > Link JavaDoc to Java 8 > -- > >

[jira] [Updated] (OAK-7315) Link JavaDoc to Java 8

2018-03-07 Thread Marcel Reutegger (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcel Reutegger updated OAK-7315: -- Description: Oak trunk and 1.8 branch require Java 8 and their JavaDoc should therefore link to

[jira] [Reopened] (OAK-7306) MongoDocumentStore: use transient DocumentStoreException type where appropriate

2018-03-07 Thread Marcel Reutegger (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcel Reutegger reopened OAK-7306: --- Interrupted operations may also surface as {{WriteConcernException}} (in addition to

[jira] [Created] (OAK-7315) Link JavaDoc to Java 8

2018-03-07 Thread Marcel Reutegger (JIRA)
Marcel Reutegger created OAK-7315: - Summary: Link JavaDoc to Java 8 Key: OAK-7315 URL: https://issues.apache.org/jira/browse/OAK-7315 Project: Jackrabbit Oak Issue Type: Task

[jira] [Updated] (OAK-7310) Empty package-info.java causes unnecessary rebuild

2018-03-07 Thread Marcel Reutegger (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcel Reutegger updated OAK-7310: -- Component/s: (was: rdbmk) parent Summary: Empty package-info.java

[jira] [Reopened] (OAK-7310) Empty package-info.java in o.a.j.o.plugins.document.rdb causes unnecessary rebuild

2018-03-07 Thread Marcel Reutegger (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcel Reutegger reopened OAK-7310: --- Agreed, it's better to use it consistently. > Empty package-info.java in

[jira] [Commented] (OAK-7307) RDBDocumentStore: use transient DocumentStoreException type where appropriate

2018-03-07 Thread Marcel Reutegger (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16389254#comment-16389254 ] Marcel Reutegger commented on OAK-7307: --- [~reschke], are there even cases in RDBDocumentStore when the

[jira] [Updated] (OAK-7286) DocumentNodeStoreBranch handling of non-recoverable DocumentStoreExceptions

2018-03-07 Thread Marcel Reutegger (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcel Reutegger updated OAK-7286: -- Fix Version/s: (was: 1.9.0) > DocumentNodeStoreBranch handling of non-recoverable

[jira] [Commented] (OAK-7310) Empty package-info.java in o.a.j.o.plugins.document.rdb causes unnecessary rebuild

2018-03-07 Thread Julian Reschke (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16389250#comment-16389250 ] Julian Reschke commented on OAK-7310: - Hm, shouldn't we do that for all subprojects? > Empty

[jira] [Resolved] (OAK-7308) Retry commit on transient DocumentStoreException

2018-03-07 Thread Marcel Reutegger (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcel Reutegger resolved OAK-7308. --- Resolution: Fixed Fix Version/s: 1.9.0 Done in trunk: http://svn.apache.org/r1826086 >

[jira] [Resolved] (OAK-7310) Empty package-info.java in o.a.j.o.plugins.document.rdb causes unnecessary rebuild

2018-03-07 Thread Marcel Reutegger (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcel Reutegger resolved OAK-7310. --- Resolution: Fixed Fix Version/s: 1.10 1.9.0 Added

[jira] [Updated] (OAK-7310) Empty package-info.java in o.a.j.o.plugins.document.rdb causes unnecessary rebuild

2018-03-07 Thread Marcel Reutegger (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcel Reutegger updated OAK-7310: -- Description: The file is used as JavaDoc package overview documentation but doesn't not contain

[jira] [Updated] (OAK-7314) RDB*Store: use SDMAXREV column in RevisionGC query

2018-03-07 Thread Julian Reschke (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-7314: Labels: candidate_oak_1_8 (was: ) > RDB*Store: use SDMAXREV column in RevisionGC query >

[jira] [Updated] (OAK-7314) RDB*Store: use SDMAXREV column in RevisionGC query

2018-03-07 Thread Julian Reschke (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-7314: Description: (oversight when working on OAK-6965 > RDB*Store: use SDMAXREV column in RevisionGC query

[jira] [Updated] (OAK-7314) RDB*Store: use SDMAXREV column in RevisionGC query

2018-03-07 Thread Julian Reschke (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-7314: Description: (oversight when working on OAK-6965) (was: (oversight when working on OAK-6965) >

[jira] [Created] (OAK-7314) RDB*Store: use SDMAXREV column in RevisionGC query

2018-03-07 Thread Julian Reschke (JIRA)
Julian Reschke created OAK-7314: --- Summary: RDB*Store: use SDMAXREV column in RevisionGC query Key: OAK-7314 URL: https://issues.apache.org/jira/browse/OAK-7314 Project: Jackrabbit Oak Issue

[jira] [Reopened] (OAK-7310) Empty package-info.java in o.a.j.o.plugins.document.rdb

2018-03-07 Thread Marcel Reutegger (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcel Reutegger reopened OAK-7310: --- Assignee: Marcel Reutegger (was: Julian Reschke) I'm re-opening this issue and change the

[jira] [Commented] (OAK-7310) Empty package-info.java in o.a.j.o.plugins.document.rdb

2018-03-07 Thread Marcel Reutegger (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16389227#comment-16389227 ] Marcel Reutegger commented on OAK-7310: --- bq. Maybe because the plugin detects the missing class file

[jira] [Comment Edited] (OAK-7313) RDB*Store: add DEBUG level logging for filters in RDBVersionGCSupport

2018-03-07 Thread Julian Reschke (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16389045#comment-16389045 ] Julian Reschke edited comment on OAK-7313 at 3/7/18 8:09 AM: - trunk:

[jira] [Updated] (OAK-7313) RDB*Store: add DEBUG level logging for filters in RDBVersionGCSupport

2018-03-07 Thread Julian Reschke (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-7313: Fix Version/s: 1.8.3 > RDB*Store: add DEBUG level logging for filters in RDBVersionGCSupport >

[jira] [Updated] (OAK-7313) RDB*Store: add DEBUG level logging for filters in RDBVersionGCSupport

2018-03-07 Thread Julian Reschke (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-7313: Labels: (was: candidate_oak_1_8) > RDB*Store: add DEBUG level logging for filters in