[jira] [Commented] (OAK-7817) oak-doc-railroad-macro should be built in default reactor built

2018-11-01 Thread Tobias Bocanegra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16672362#comment-16672362 ] Tobias Bocanegra commented on OAK-7817: --- it depends a bit if you just want a mirror or an independent

[jira] [Commented] (OAK-6144) ExternalIdentity should have a method indicating if an identity is actually active

2017-05-30 Thread Tobias Bocanegra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-6144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16029525#comment-16029525 ] Tobias Bocanegra commented on OAK-6144: --- bq. I tried that, but after adding the @ProviderType

[jira] [Commented] (OAK-6144) ExternalIdentity should have a method indicating if an identity is actually active

2017-05-10 Thread Tobias Bocanegra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-6144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16005884#comment-16005884 ] Tobias Bocanegra commented on OAK-6144: --- +1 LGTM, but I think you need to increase the package version

[jira] [Commented] (OAK-6102) LdapIdentityProvider#getIdentity(ExternalIdentityRef) and LdapIdentityProvider#getUser(String) should behave consistently.

2017-04-25 Thread Tobias Bocanegra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-6102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15982922#comment-15982922 ] Tobias Bocanegra commented on OAK-6102: --- or {{ExternalIdentity.isActive()}}. >

[jira] [Commented] (OAK-6102) LdapIdentityProvider#getIdentity(ExternalIdentityRef) and LdapIdentityProvider#getUser(String) should behave consistently.

2017-04-21 Thread Tobias Bocanegra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-6102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978984#comment-15978984 ] Tobias Bocanegra commented on OAK-6102: --- I don't argue that the listOrphanedUsers() is not buggy, but

[jira] [Commented] (OAK-6102) LdapIdentityProvider#getIdentity(ExternalIdentityRef) and LdapIdentityProvider#getUser(String) should behave consistently.

2017-04-20 Thread Tobias Bocanegra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-6102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15976258#comment-15976258 ] Tobias Bocanegra commented on OAK-6102: --- bq. ... are you saying that this isn't a bug but working as

[jira] [Comment Edited] (OAK-6102) LdapIdentityProvider#getIdentity(ExternalIdentityRef) and LdapIdentityProvider#getUser(String) should behave consistently.

2017-04-19 Thread Tobias Bocanegra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-6102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15975870#comment-15975870 ] Tobias Bocanegra edited comment on OAK-6102 at 4/20/17 1:12 AM: the extra

[jira] [Commented] (OAK-6102) LdapIdentityProvider#getIdentity(ExternalIdentityRef) and LdapIdentityProvider#getUser(String) should behave consistently.

2017-04-19 Thread Tobias Bocanegra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-6102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15975870#comment-15975870 ] Tobias Bocanegra commented on OAK-6102: --- the extra filter is used in {{listUsers()}} {{listGroups()}}

[jira] [Commented] (OAK-5229) Using Node.setPrimaryType() should fail if non-matching childnodes

2017-02-21 Thread Tobias Bocanegra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15875922#comment-15875922 ] Tobias Bocanegra commented on OAK-5229: --- but isn't this a backward incompatible change? especially,

[jira] [Commented] (OAK-5229) Using Node.setPrimaryType() should fail if non-matching childnodes

2017-02-20 Thread Tobias Bocanegra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15875130#comment-15875130 ] Tobias Bocanegra commented on OAK-5229: --- uh... I don't think this is a good behavior for

[jira] [Commented] (OAK-5229) Using Node.setPrimaryType() should fail if non-matching childnodes

2017-02-14 Thread Tobias Bocanegra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15866973#comment-15866973 ] Tobias Bocanegra commented on OAK-5229: --- I agree, so the following happens: - if an item (property or

[jira] [Commented] (OAK-5229) Using Node.setPrimaryType() should fail if non-matching childnodes

2017-02-13 Thread Tobias Bocanegra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15864719#comment-15864719 ] Tobias Bocanegra commented on OAK-5229: --- bq. E.g. removing a mix:referenceable on a nt:unstructured

[jira] [Commented] (OAK-5229) Using Node.setPrimaryType() should fail if non-matching childnodes

2017-02-12 Thread Tobias Bocanegra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15863061#comment-15863061 ] Tobias Bocanegra commented on OAK-5229: --- bq. an alternative to 'cleanup' was also: abort the

[jira] (OAK-5229) Using Node.setPrimaryType() should fail if non-matching childnodes

2017-01-31 Thread Tobias Bocanegra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15847241#comment-15847241 ] Tobias Bocanegra commented on OAK-5229: --- bq. bq. I think the method should fail immediately, and not

[jira] [Commented] (OAK-5229) Using Node.setPrimaryType() should fail if non-matching childnodes

2017-01-26 Thread Tobias Bocanegra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1583#comment-1583 ] Tobias Bocanegra commented on OAK-5229: --- bq. I had to tweak the provided test to log out the admin

[jira] [Commented] (OAK-5229) Using Node.setPrimaryType() should fail if non-matching childnodes

2017-01-26 Thread Tobias Bocanegra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15839996#comment-15839996 ] Tobias Bocanegra commented on OAK-5229: --- I think the method should fail immediately, and not only

[jira] [Commented] (OAK-5210) Ability to resolve principal name from ExternalIdentityRef without IDP roundtrip

2017-01-15 Thread Tobias Bocanegra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15823337#comment-15823337 ] Tobias Bocanegra commented on OAK-5210: --- +1 patch looks good to me. > Ability to resolve principal

[jira] [Commented] (OAK-5229) Using Node.setPrimaryType() should fail if non-matching childnodes

2017-01-11 Thread Tobias Bocanegra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15818305#comment-15818305 ] Tobias Bocanegra commented on OAK-5229: --- another easy way to cause havoc: {noformat} curl -u

[jira] [Comment Edited] (OAK-5229) Using Node.setPrimaryType() should fail if non-matching childnodes

2017-01-11 Thread Tobias Bocanegra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15818068#comment-15818068 ] Tobias Bocanegra edited comment on OAK-5229 at 1/11/17 11:33 AM: - The

[jira] [Commented] (OAK-5229) Using Node.setPrimaryType() should fail if non-matching childnodes

2017-01-11 Thread Tobias Bocanegra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15818068#comment-15818068 ] Tobias Bocanegra commented on OAK-5229: --- The problem is, that you can change the nodetype in such a

[jira] [Updated] (OAK-5229) Using Node.setPrimaryType() should fail if non-matching childnodes

2016-12-18 Thread Tobias Bocanegra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tobias Bocanegra updated OAK-5229: -- Fix Version/s: 1.5.16 > Using Node.setPrimaryType() should fail if non-matching childnodes >

[jira] [Created] (OAK-5249) DefaultAuthorizableActionProvider should use @Modified to react to config changes

2016-12-08 Thread Tobias Bocanegra (JIRA)
Tobias Bocanegra created OAK-5249: - Summary: DefaultAuthorizableActionProvider should use @Modified to react to config changes Key: OAK-5249 URL: https://issues.apache.org/jira/browse/OAK-5249

[jira] [Updated] (OAK-5229) Using Node.setPrimaryType() should fail if non-matching childnodes

2016-12-06 Thread Tobias Bocanegra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tobias Bocanegra updated OAK-5229: -- Description: 1. Assume the following: {noformat} /testNode [nt:unstructured]

[jira] [Commented] (OAK-5229) Using Node.setPrimaryType() should fail if non-matching childnodes

2016-12-06 Thread Tobias Bocanegra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15727424#comment-15727424 ] Tobias Bocanegra commented on OAK-5229: --- btw: the javadoc states: {noformat} * @throws

[jira] [Commented] (OAK-5229) Using Node.setPrimaryType() should fail if non-matching childnodes

2016-12-06 Thread Tobias Bocanegra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15727414#comment-15727414 ] Tobias Bocanegra commented on OAK-5229: --- added "ignored" test in r1773002:

[jira] [Updated] (OAK-5229) Using Node.setPrimaryType() should fail if non-matching childnodes

2016-12-06 Thread Tobias Bocanegra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tobias Bocanegra updated OAK-5229: -- Priority: Critical (was: Major) > Using Node.setPrimaryType() should fail if non-matching

[jira] [Commented] (OAK-5229) Using Node.setPrimaryType() should fail if non-matching childnodes

2016-12-06 Thread Tobias Bocanegra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15727400#comment-15727400 ] Tobias Bocanegra commented on OAK-5229: --- {code} @Test public void setPrimaryTypeFails() throws

[jira] [Created] (OAK-5229) Using Node.setPrimaryType() should fail if non-matching childnodes

2016-12-06 Thread Tobias Bocanegra (JIRA)
Tobias Bocanegra created OAK-5229: - Summary: Using Node.setPrimaryType() should fail if non-matching childnodes Key: OAK-5229 URL: https://issues.apache.org/jira/browse/OAK-5229 Project: Jackrabbit

[jira] [Commented] (OAK-4857) Support space chars common in CJK inside node names

2016-10-26 Thread Tobias Bocanegra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15610169#comment-15610169 ] Tobias Bocanegra commented on OAK-4857: --- going back to the original problem, if we would just allow

[jira] [Commented] (OAK-4857) Support space chars common in CJK inside node names

2016-09-29 Thread Tobias Bocanegra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15532244#comment-15532244 ] Tobias Bocanegra commented on OAK-4857: --- I think the easiest is to allow all spec compliant

[jira] [Commented] (OAK-4857) Support space chars common in CJK inside node names

2016-09-28 Thread Tobias Bocanegra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15529074#comment-15529074 ] Tobias Bocanegra commented on OAK-4857: --- I frankly don't understand why we should limit the range of

[jira] [Commented] (OAK-4857) Support space chars common in CJK inside node names

2016-09-28 Thread Tobias Bocanegra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15528875#comment-15528875 ] Tobias Bocanegra commented on OAK-4857: --- use case is storing files in JCR and retain thir filename.

[jira] [Commented] (OAK-4857) Support space chars common in CJK inside node names

2016-09-27 Thread Tobias Bocanegra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15528123#comment-15528123 ] Tobias Bocanegra commented on OAK-4857: --- +1 for allowing all 'Z' spaces. the current restriction is a

[jira] [Commented] (OAK-4825) Support disabling of users instead of removal in DefaultSyncHandler

2016-09-19 Thread Tobias Bocanegra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15505286#comment-15505286 ] Tobias Bocanegra commented on OAK-4825: --- I like the idea: {noformat} /** * Controls the behavior for

[jira] [Commented] (OAK-3508) External login module should reduce LDAP lookups for pre-authenticated users

2016-06-08 Thread Tobias Bocanegra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15321473#comment-15321473 ] Tobias Bocanegra commented on OAK-3508: --- also fixed in 1.2: r1747456 [~anchela] I also wanted to

[jira] [Updated] (OAK-3508) External login module should reduce LDAP lookups for pre-authenticated users

2016-06-08 Thread Tobias Bocanegra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tobias Bocanegra updated OAK-3508: -- Fix Version/s: 1.2.16 > External login module should reduce LDAP lookups for pre-authenticated

[jira] [Commented] (OAK-4087) Replace Sync of configured AutoMembership by Dynamic Principal Generation

2016-05-31 Thread Tobias Bocanegra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15308756#comment-15308756 ] Tobias Bocanegra commented on OAK-4087: --- +1 looks good to me. thanks > Replace Sync of configured

[jira] [Commented] (OAK-4379) Batch mode for SyncMBeanImpl

2016-05-19 Thread Tobias Bocanegra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15291665#comment-15291665 ] Tobias Bocanegra commented on OAK-4379: --- good idea. maybe the batch size can be specified? > Batch

[jira] [Commented] (OAK-4101) Consider separate external (group) principal management

2016-05-11 Thread Tobias Bocanegra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1528#comment-1528 ] Tobias Bocanegra commented on OAK-4101: --- as far as I can tell, this is ok. I created a temporary pull

[jira] [Commented] (OAK-4363) SyncMBeanImpl: result lacks 'uid' if error messages has been created from ExternalIdentityRef

2016-05-11 Thread Tobias Bocanegra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15280484#comment-15280484 ] Tobias Bocanegra commented on OAK-4363: --- I can't remember. maybe an oversight. > SyncMBeanImpl:

[jira] [Comment Edited] (OAK-4268) Clarify API contract for SyncResult.getIdentity

2016-04-27 Thread Tobias Bocanegra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15260834#comment-15260834 ] Tobias Bocanegra edited comment on OAK-4268 at 4/27/16 8:02 PM: I think

[jira] [Commented] (OAK-4268) Clarify API contract for SyncResult.getIdentity

2016-04-27 Thread Tobias Bocanegra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15260834#comment-15260834 ] Tobias Bocanegra commented on OAK-4268: --- I think there was not much though put into when the identity

[jira] [Resolved] (OAK-1410) Allow automatic propagation of oak-whiteboard when adding security manager

2016-04-25 Thread Tobias Bocanegra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-1410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tobias Bocanegra resolved OAK-1410. --- Resolution: Won't Fix > Allow automatic propagation of oak-whiteboard when adding security

[jira] [Resolved] (OAK-4048) [regression] SyncHandler.listIdentities() returns all users, not only external ones

2016-04-25 Thread Tobias Bocanegra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tobias Bocanegra resolved OAK-4048. --- Resolution: Fixed Fix Version/s: 1.6 fixed in r1740879 > [regression]

[jira] [Updated] (OAK-4268) Clarify API contract for SyncResult.getIdentity

2016-04-25 Thread Tobias Bocanegra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tobias Bocanegra updated OAK-4268: -- Assignee: angela (was: Tobias Bocanegra) > Clarify API contract for SyncResult.getIdentity >

[jira] [Commented] (OAK-4268) Clarify API contract for SyncResult.getIdentity

2016-04-21 Thread Tobias Bocanegra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15252261#comment-15252261 ] Tobias Bocanegra commented on OAK-4268: --- I would change it to NONULL: {noformat} /** * The

[jira] [Commented] (OAK-3626) Provide bind credentials callback

2016-04-21 Thread Tobias Bocanegra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15252229#comment-15252229 ] Tobias Bocanegra commented on OAK-3626: --- The idea was to decouple the problem of providing the bind

[jira] [Commented] (OAK-4222) Cleanup ExternalLoginModuleTest

2016-04-20 Thread Tobias Bocanegra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15250362#comment-15250362 ] Tobias Bocanegra commented on OAK-4222: --- ...but I would keep the {{options.clear()}} in the final

[jira] [Commented] (OAK-4222) Cleanup ExternalLoginModuleTest

2016-04-20 Thread Tobias Bocanegra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15250346#comment-15250346 ] Tobias Bocanegra commented on OAK-4222: --- +1 to remove the {{options}}. probably copy-past leftover.

[jira] [Commented] (OAK-4224) DefaultSyncContext.sync(ExternalIdentity) should verify IDP

2016-04-20 Thread Tobias Bocanegra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15250293#comment-15250293 ] Tobias Bocanegra commented on OAK-4224: --- I think we should keep the identity in the sync result the

[jira] [Comment Edited] (OAK-4048) [regression] SyncHandler.listIdentities() returns all users, not only external ones

2016-04-18 Thread Tobias Bocanegra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15246285#comment-15246285 ] Tobias Bocanegra edited comment on OAK-4048 at 4/18/16 6:39 PM: You are

[jira] [Commented] (OAK-4048) [regression] SyncHandler.listIdentities() returns all users, not only external ones

2016-04-18 Thread Tobias Bocanegra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15246285#comment-15246285 ] Tobias Bocanegra commented on OAK-4048: --- You are right. There was a change in logic in

[jira] [Commented] (OAK-4119) Improvements Take 1

2016-03-19 Thread Tobias Bocanegra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15198499#comment-15198499 ] Tobias Bocanegra commented on OAK-4119: --- the patch is too complex to understand if it's correct. if

[jira] [Commented] (OAK-4087) Replace Sync of configured AutoMembership by Dynamic Principal Generation

2016-03-03 Thread Tobias Bocanegra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15178339#comment-15178339 ] Tobias Bocanegra commented on OAK-4087: --- I think that is a very good idea. I don't know why we didn't

[jira] [Commented] (OAK-3933) potential improvements to membership management

2016-03-01 Thread Tobias Bocanegra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15174855#comment-15174855 ] Tobias Bocanegra commented on OAK-3933: --- wouldn't it make sense to have a generic

[jira] [Comment Edited] (OAK-3886) Delegate supported Credentials types to ExternalIdentityProvider

2016-02-16 Thread Tobias Bocanegra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15148951#comment-15148951 ] Tobias Bocanegra edited comment on OAK-3886 at 2/16/16 5:30 PM: Thanks! (a

[jira] [Commented] (OAK-3886) Delegate supported Credentials types to ExternalIdentityProvider

2016-02-16 Thread Tobias Bocanegra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15148951#comment-15148951 ] Tobias Bocanegra commented on OAK-3886: --- Thanks! (a git pull request would be easier to comment on..)

[jira] [Created] (OAK-3930) Sysview import of single valued mv property creates sv property

2016-01-26 Thread Tobias Bocanegra (JIRA)
Tobias Bocanegra created OAK-3930: - Summary: Sysview import of single valued mv property creates sv property Key: OAK-3930 URL: https://issues.apache.org/jira/browse/OAK-3930 Project: Jackrabbit Oak

[jira] [Updated] (OAK-3930) Sysview import of single valued mv property creates sv property

2016-01-26 Thread Tobias Bocanegra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tobias Bocanegra updated OAK-3930: -- Description: See test in filevault [0]. it imports a multivalue property that only has 1 value,

[jira] [Commented] (OAK-3842) Adjust package export declarations

2016-01-11 Thread Tobias Bocanegra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15092248#comment-15092248 ] Tobias Bocanegra commented on OAK-3842: --- yes, remove the export. thanks. > Adjust package export

[jira] [Commented] (OAK-3275) DefaultSyncConfig: User membership expiration time not working under some circumstances

2015-12-16 Thread Tobias Bocanegra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15060588#comment-15060588 ] Tobias Bocanegra commented on OAK-3275: --- +1 LGTM > DefaultSyncConfig: User membership expiration time

[jira] [Commented] (OAK-3519) Some improvement to SyncMBeanImpl

2015-12-16 Thread Tobias Bocanegra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15061004#comment-15061004 ] Tobias Bocanegra commented on OAK-3519: --- +1 LGTM but I would make the {{SyncRuntimeException}}

[jira] [Commented] (OAK-3275) DefaultSyncConfig: User membership expiration time not working under some circumstances

2015-12-15 Thread Tobias Bocanegra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15058436#comment-15058436 ] Tobias Bocanegra commented on OAK-3275: --- I don't know if we really should remove this and not better

[jira] [Commented] (OAK-3721) Reduce code duplication in MembershipProvider

2015-12-08 Thread Tobias Bocanegra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15047249#comment-15047249 ] Tobias Bocanegra commented on OAK-3721: --- in general ok. but I don't like the access of the protected

[jira] [Updated] (OAK-3508) External login module should reduce LDAP lookups for pre-authenticated users

2015-11-24 Thread Tobias Bocanegra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tobias Bocanegra updated OAK-3508: -- Fix Version/s: 1.0.23 > External login module should reduce LDAP lookups for pre-authenticated

[jira] [Commented] (OAK-2948) Expose DefaultSyncHandler

2015-11-19 Thread Tobias Bocanegra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-2948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15014123#comment-15014123 ] Tobias Bocanegra commented on OAK-2948: --- yeah, the {{DefaultSyncConfigImpl}} separates the

[jira] [Commented] (OAK-2948) Expose DefaultSyncHandler

2015-11-18 Thread Tobias Bocanegra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-2948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15011568#comment-15011568 ] Tobias Bocanegra commented on OAK-2948: --- no, the class is public:

[jira] [Commented] (OAK-3522) DefaultSyncContext exposes internal path-utility method

2015-11-12 Thread Tobias Bocanegra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15002713#comment-15002713 ] Tobias Bocanegra commented on OAK-3522: --- +1 thanks! > DefaultSyncContext exposes internal

[jira] [Created] (OAK-3626) Provide bind credentials callback

2015-11-12 Thread Tobias Bocanegra (JIRA)
Tobias Bocanegra created OAK-3626: - Summary: Provide bind credentials callback Key: OAK-3626 URL: https://issues.apache.org/jira/browse/OAK-3626 Project: Jackrabbit Oak Issue Type:

[jira] [Commented] (OAK-3523) DefaultSyncContext catches ClassCastException

2015-10-19 Thread Tobias Bocanegra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14963649#comment-14963649 ] Tobias Bocanegra commented on OAK-3523: --- also I think that {{Group grp =

[jira] [Commented] (OAK-3523) DefaultSyncContext catches ClassCastException

2015-10-16 Thread Tobias Bocanegra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14961320#comment-14961320 ] Tobias Bocanegra commented on OAK-3523: --- I disagree with the patch. it is less performant...i'll have

[jira] [Assigned] (OAK-3523) DefaultSyncContext catches ClassCastException

2015-10-16 Thread Tobias Bocanegra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tobias Bocanegra reassigned OAK-3523: - Assignee: Tobias Bocanegra (was: angela) > DefaultSyncContext catches ClassCastException

[jira] [Commented] (OAK-3518) Consistently add annotations to DefaultSync* classes

2015-10-14 Thread Tobias Bocanegra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14957450#comment-14957450 ] Tobias Bocanegra commented on OAK-3518: --- looks good > Consistently add annotations to DefaultSync*

[jira] [Commented] (OAK-3508) External login module should reduce LDAP lookups for pre-authenticated users

2015-10-13 Thread Tobias Bocanegra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14955049#comment-14955049 ] Tobias Bocanegra commented on OAK-3508: --- no quite. our SSO module only sets the shared credentials, it

[jira] [Comment Edited] (OAK-3508) External login module should reduce LDAP lookups for pre-authenticated users

2015-10-13 Thread Tobias Bocanegra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14955083#comment-14955083 ] Tobias Bocanegra edited comment on OAK-3508 at 10/13/15 3:14 PM: - So

[jira] [Commented] (OAK-3508) External login module should reduce LDAP lookups for pre-authenticated users

2015-10-13 Thread Tobias Bocanegra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14955083#comment-14955083 ] Tobias Bocanegra commented on OAK-3508: --- So basically this issue is about to reduce LDAP lookups for

[jira] [Commented] (OAK-3498) DN can't be used as the group name in the external auth handler

2015-10-13 Thread Tobias Bocanegra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14955155#comment-14955155 ] Tobias Bocanegra commented on OAK-3498: --- Those are 2 issues. one is using the DN as name/id attribute,

[jira] [Resolved] (OAK-3508) External login module should reduce LDAP lookups for pre-authenticated users

2015-10-13 Thread Tobias Bocanegra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tobias Bocanegra resolved OAK-3508. --- Resolution: Fixed Fix Version/s: 1.4 fixed in trunk: r1708540 > External login module

[jira] [Commented] (OAK-3508) External login module should reduce LDAP lookups for pre-authenticated users

2015-10-13 Thread Tobias Bocanegra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14956062#comment-14956062 ] Tobias Bocanegra commented on OAK-3508: --- fixed in 1.0: r1708541 > External login module should reduce

[jira] [Updated] (OAK-3508) External login module should reduce LDAP lookups for pre-authenticated users

2015-10-12 Thread Tobias Bocanegra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tobias Bocanegra updated OAK-3508: -- Affects Version/s: 1.4 1.2 1.0.22 > External login

[jira] [Updated] (OAK-3508) External login module should reduce LDAP lookups for pre-authenticated users

2015-10-12 Thread Tobias Bocanegra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tobias Bocanegra updated OAK-3508: -- Component/s: auth-external > External login module should reduce LDAP lookups for

[jira] [Assigned] (OAK-3508) External login module should reduce LDAP lookups for pre-authenticated users

2015-10-12 Thread Tobias Bocanegra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tobias Bocanegra reassigned OAK-3508: - Assignee: Tobias Bocanegra > External login module should reduce LDAP lookups for

[jira] [Created] (OAK-3508) External login module should reduce LDAP lookups for pre-authenticated users

2015-10-12 Thread Tobias Bocanegra (JIRA)
Tobias Bocanegra created OAK-3508: - Summary: External login module should reduce LDAP lookups for pre-authenticated users Key: OAK-3508 URL: https://issues.apache.org/jira/browse/OAK-3508 Project:

[jira] [Updated] (OAK-3396) NPE during syncAllExternalUsers in LdapIdentityProvider.createUser

2015-10-02 Thread Tobias Bocanegra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tobias Bocanegra updated OAK-3396: -- Fix Version/s: 1.2.7 1.3.8 > NPE during syncAllExternalUsers in

[jira] [Commented] (OAK-3396) NPE during syncAllExternalUsers in LdapIdentityProvider.createUser

2015-10-02 Thread Tobias Bocanegra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14941513#comment-14941513 ] Tobias Bocanegra commented on OAK-3396: --- fixed in trunk: r1706457 > NPE during syncAllExternalUsers

[jira] [Commented] (OAK-3311) Potential NPE in syncAllExternalUsers() aborts the process

2015-10-02 Thread Tobias Bocanegra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14941508#comment-14941508 ] Tobias Bocanegra commented on OAK-3311: --- fixed in trunk: r1706459 > Potential NPE in

[jira] [Commented] (OAK-3311) Potential NPE in syncAllExternalUsers() aborts the process

2015-10-02 Thread Tobias Bocanegra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14941476#comment-14941476 ] Tobias Bocanegra commented on OAK-3311: --- bq. missing test-case verifying that the issue is actually

[jira] [Updated] (OAK-3311) Potential NPE in syncAllExternalUsers() aborts the process

2015-10-02 Thread Tobias Bocanegra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tobias Bocanegra updated OAK-3311: -- Fix Version/s: 1.2.7 1.3.9 > Potential NPE in syncAllExternalUsers() aborts

[jira] [Resolved] (OAK-3311) Potential NPE in syncAllExternalUsers() aborts the process

2015-10-02 Thread Tobias Bocanegra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tobias Bocanegra resolved OAK-3311. --- Resolution: Fixed > Potential NPE in syncAllExternalUsers() aborts the process >

[jira] [Commented] (OAK-3396) NPE during syncAllExternalUsers in LdapIdentityProvider.createUser

2015-10-02 Thread Tobias Bocanegra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14941610#comment-14941610 ] Tobias Bocanegra commented on OAK-3396: --- fixed in 1.0: r1706476 > NPE during syncAllExternalUsers in

[jira] [Resolved] (OAK-3396) NPE during syncAllExternalUsers in LdapIdentityProvider.createUser

2015-10-02 Thread Tobias Bocanegra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tobias Bocanegra resolved OAK-3396. --- Resolution: Fixed > NPE during syncAllExternalUsers in LdapIdentityProvider.createUser >

[jira] [Commented] (OAK-3311) Potential NPE in syncAllExternalUsers() aborts the process

2015-10-02 Thread Tobias Bocanegra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14941611#comment-14941611 ] Tobias Bocanegra commented on OAK-3311: --- fixed in 1.0: r1706478 > Potential NPE in

[jira] [Commented] (OAK-3311) Potential NPE in syncAllExternalUsers() aborts the process

2015-10-02 Thread Tobias Bocanegra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14941556#comment-14941556 ] Tobias Bocanegra commented on OAK-3311: --- fixed in 1.2: r1706465 > Potential NPE in

[jira] [Commented] (OAK-3396) NPE during syncAllExternalUsers in LdapIdentityProvider.createUser

2015-10-02 Thread Tobias Bocanegra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14941555#comment-14941555 ] Tobias Bocanegra commented on OAK-3396: --- fixed in 1.2: r1706463 > NPE during syncAllExternalUsers in

[jira] [Updated] (OAK-2948) Expose DefaultSyncHandler

2015-09-30 Thread Tobias Bocanegra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-2948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tobias Bocanegra updated OAK-2948: -- Fix Version/s: 1.2.7 > Expose DefaultSyncHandler > - > >

[jira] [Updated] (OAK-2948) Expose DefaultSyncHandler

2015-09-30 Thread Tobias Bocanegra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-2948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tobias Bocanegra updated OAK-2948: -- Fix Version/s: 1.0.22 > Expose DefaultSyncHandler > - > >

[jira] [Commented] (OAK-3396) NPE during syncAllExternalUsers in LdapIdentityProvider.createUser

2015-09-16 Thread Tobias Bocanegra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14768956#comment-14768956 ] Tobias Bocanegra commented on OAK-3396: --- [~egli] we could import the users and groups normally, but

[jira] [Commented] (OAK-3396) NPE during syncAllExternalUsers in LdapIdentityProvider.createUser

2015-09-15 Thread Tobias Bocanegra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14745601#comment-14745601 ] Tobias Bocanegra commented on OAK-3396: --- [~egli] thanks. can you also create a test case? > NPE

[jira] [Assigned] (OAK-3396) NPE during syncAllExternalUsers in LdapIdentityProvider.createUser

2015-09-15 Thread Tobias Bocanegra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tobias Bocanegra reassigned OAK-3396: - Assignee: Tobias Bocanegra > NPE during syncAllExternalUsers in

[jira] [Created] (OAK-3351) Add ability to prioritise restriction to where it matches

2015-09-04 Thread Tobias Bocanegra (JIRA)
Tobias Bocanegra created OAK-3351: - Summary: Add ability to prioritise restriction to where it matches Key: OAK-3351 URL: https://issues.apache.org/jira/browse/OAK-3351 Project: Jackrabbit Oak

  1   2   3   4   5   >