[
https://issues.apache.org/jira/browse/OAK-3201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14906236#comment-14906236
]
Francesco Mari commented on OAK-3201:
-
Backported to 1.0 in r1705037.
> Use static references in
[
https://issues.apache.org/jira/browse/OAK-3201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14906023#comment-14906023
]
Francesco Mari commented on OAK-3201:
-
Backported to 1.2 in r1705014.
> Use static references in
[
https://issues.apache.org/jira/browse/OAK-3201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14805138#comment-14805138
]
Francesco Mari commented on OAK-3201:
-
Committed in trunk in r1703758.
> Use static references in
[
https://issues.apache.org/jira/browse/OAK-3201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14791725#comment-14791725
]
Chetan Mehrotra commented on OAK-3201:
--
bq. This may work the first time, but it doesn't work if
[
https://issues.apache.org/jira/browse/OAK-3201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14791662#comment-14791662
]
Chetan Mehrotra commented on OAK-3201:
--
Looks better!. Some more comments
* Setting immediate to true -
[
https://issues.apache.org/jira/browse/OAK-3201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14791710#comment-14791710
]
Francesco Mari commented on OAK-3201:
-
bq. Setting immediate to true - That should not be required per
[
https://issues.apache.org/jira/browse/OAK-3201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14791761#comment-14791761
]
Francesco Mari commented on OAK-3201:
-
bq. Yup but I do not see how that is related to current proposed
[
https://issues.apache.org/jira/browse/OAK-3201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14744985#comment-14744985
]
Francesco Mari commented on OAK-3201:
-
I'm pretty satisfied with the result, I'm going to commit this
[
https://issues.apache.org/jira/browse/OAK-3201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14745023#comment-14745023
]
Chetan Mehrotra commented on OAK-3201:
--
Missed reviewing it due to other issues. Some quick comments
*
[
https://issues.apache.org/jira/browse/OAK-3201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14745497#comment-14745497
]
Francesco Mari commented on OAK-3201:
-
I'm also wondering if explicit synchronization could be removed
[
https://issues.apache.org/jira/browse/OAK-3201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14740568#comment-14740568
]
Chetan Mehrotra commented on OAK-3201:
--
Approach look fine now.
bq. I found very difficult to retrofit
[
https://issues.apache.org/jira/browse/OAK-3201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14736394#comment-14736394
]
Chetan Mehrotra commented on OAK-3201:
--
bq. Not true. They can still do it, but they have to register a
[
https://issues.apache.org/jira/browse/OAK-3201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14736477#comment-14736477
]
Francesco Mari commented on OAK-3201:
-
Every deployment using the current version of
[
https://issues.apache.org/jira/browse/OAK-3201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14736349#comment-14736349
]
Francesco Mari commented on OAK-3201:
-
bq. If we go with your fix then customer making use of those
[
https://issues.apache.org/jira/browse/OAK-3201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14736341#comment-14736341
]
Chetan Mehrotra commented on OAK-3201:
--
I would not be comfortable with this fix. We cannot remove
[
https://issues.apache.org/jira/browse/OAK-3201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14736335#comment-14736335
]
Francesco Mari commented on OAK-3201:
-
[~chetanm], continuing the offline conversation we had yesterday,
[
https://issues.apache.org/jira/browse/OAK-3201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14736579#comment-14736579
]
Chetan Mehrotra commented on OAK-3201:
--
bq. Every deployment using the current version of
[
https://issues.apache.org/jira/browse/OAK-3201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14736730#comment-14736730
]
Dominik Süß commented on OAK-3201:
--
[~frm], [~chetanm] - Sling hit a simliar issue when introducing the
[
https://issues.apache.org/jira/browse/OAK-3201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14736789#comment-14736789
]
Francesco Mari commented on OAK-3201:
-
[~dsuess], thanks for the pointer. I will try to rework my
[
https://issues.apache.org/jira/browse/OAK-3201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14734718#comment-14734718
]
Francesco Mari commented on OAK-3201:
-
[~chetanm], I'm aware of the change of behaviour. I decided to
[
https://issues.apache.org/jira/browse/OAK-3201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14734670#comment-14734670
]
Chetan Mehrotra commented on OAK-3201:
--
[~frm] Can you provide some details on what is the intended
[
https://issues.apache.org/jira/browse/OAK-3201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14734543#comment-14734543
]
Marcel Reutegger commented on OAK-3201:
---
With the most recent patch, the oak-pojosr tests run fine on
[
https://issues.apache.org/jira/browse/OAK-3201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14734953#comment-14734953
]
Chetan Mehrotra commented on OAK-3201:
--
bq. Personally, I think that cardinality.minimum is a
[
https://issues.apache.org/jira/browse/OAK-3201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14733561#comment-14733561
]
Chetan Mehrotra commented on OAK-3201:
--
[~frm] I looked into the test failure and it appears to be
[
https://issues.apache.org/jira/browse/OAK-3201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14733618#comment-14733618
]
Julian Reschke commented on OAK-3201:
-
It fails for me as well, and I just wasted hours to find the
[
https://issues.apache.org/jira/browse/OAK-3201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14733509#comment-14733509
]
Francesco Mari commented on OAK-3201:
-
bq. Please set a fix version when you resolve an issue.
Sorry, I
[
https://issues.apache.org/jira/browse/OAK-3201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14733563#comment-14733563
]
Chetan Mehrotra commented on OAK-3201:
--
Missed on reading your first comment
bq. This changes the
[
https://issues.apache.org/jira/browse/OAK-3201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14733666#comment-14733666
]
Francesco Mari commented on OAK-3201:
-
bq. I still think whatever approach we take we should avoid get
[
https://issues.apache.org/jira/browse/OAK-3201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14731031#comment-14731031
]
Francesco Mari commented on OAK-3201:
-
[~anchela], I agree with you with the idea that services like
[
https://issues.apache.org/jira/browse/OAK-3201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14695383#comment-14695383
]
angela commented on OAK-3201:
-
i can't tell you what would be suited from an OSGi point of view.
[
https://issues.apache.org/jira/browse/OAK-3201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14693699#comment-14693699
]
Francesco Mari commented on OAK-3201:
-
I'm not sure if [^OAK-3201-01.patch] solves the
31 matches
Mail list logo
