[jira] [Commented] (OAK-4153) segment's compareAgainstBaseState wont call childNodeDeleted when deleting last and adding n nodes

[ https://issues.apache.org/jira/browse/OAK-4153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15432737#comment-15432737 ] Davide Giannella commented on OAK-4153: --- [~egli] bq. would have been better to open a separate ticket

[jira] [Commented] (OAK-4153) segment's compareAgainstBaseState wont call childNodeDeleted when deleting last and adding n nodes

[ https://issues.apache.org/jira/browse/OAK-4153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15430543#comment-15430543 ] Stefan Egli commented on OAK-4153: -- [~edivad], I see what you mean, however is that really necessary as it

[jira] [Commented] (OAK-4153) segment's compareAgainstBaseState wont call childNodeDeleted when deleting last and adding n nodes

[ https://issues.apache.org/jira/browse/OAK-4153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15428307#comment-15428307 ] Davide Giannella commented on OAK-4153: --- quick note about versions. It has been re-opened which means

[jira] [Commented] (OAK-4153) segment's compareAgainstBaseState wont call childNodeDeleted when deleting last and adding n nodes

[ https://issues.apache.org/jira/browse/OAK-4153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15420998#comment-15420998 ] Francesco Mari commented on OAK-4153: - Sounds like a good idea. > segment's compareAgainstBaseState

[jira] [Commented] (OAK-4153) segment's compareAgainstBaseState wont call childNodeDeleted when deleting last and adding n nodes

[ https://issues.apache.org/jira/browse/OAK-4153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15420955#comment-15420955 ] Michael Dürig commented on OAK-4153: +1 > segment's compareAgainstBaseState wont call childNodeDeleted

[jira] [Commented] (OAK-4153) segment's compareAgainstBaseState wont call childNodeDeleted when deleting last and adding n nodes

[ https://issues.apache.org/jira/browse/OAK-4153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15420950#comment-15420950 ] Stefan Egli commented on OAK-4153: -- Given this now had more test coverage in 1.5.x, what about backporting

[jira] [Commented] (OAK-4153) segment's compareAgainstBaseState wont call childNodeDeleted when deleting last and adding n nodes

[ https://issues.apache.org/jira/browse/OAK-4153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15420949#comment-15420949 ] Stefan Egli commented on OAK-4153: -- Given this now had more test coverage in 1.5.x, what about backporting

[jira] [Commented] (OAK-4153) segment's compareAgainstBaseState wont call childNodeDeleted when deleting last and adding n nodes

[ https://issues.apache.org/jira/browse/OAK-4153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15221512#comment-15221512 ] Stefan Egli commented on OAK-4153: -- [~mduerig] ok, thx for reviewing, applied [^OAK-4153-3.patch] to trunk

[jira] [Commented] (OAK-4153) segment's compareAgainstBaseState wont call childNodeDeleted when deleting last and adding n nodes

[ https://issues.apache.org/jira/browse/OAK-4153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15221502#comment-15221502 ] Michael Dürig commented on OAK-4153: bq. that 'else' is never hit Right, I had the same impression.

[jira] [Commented] (OAK-4153) segment's compareAgainstBaseState wont call childNodeDeleted when deleting last and adding n nodes

[ https://issues.apache.org/jira/browse/OAK-4153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15221413#comment-15221413 ] Michael Dürig commented on OAK-4153: Good find anyway, and +1 for back porting as this has the potential