[
https://issues.apache.org/jira/browse/OAK-5046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15643722#comment-15643722
]
Alex Parvulescu commented on OAK-5046:
--
patch looks ok. one thing missing is the deprecation warning
[
https://issues.apache.org/jira/browse/OAK-5046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15633311#comment-15633311
]
Alex Parvulescu commented on OAK-5046:
--
I think you might have completely ignored my remark about being
[
https://issues.apache.org/jira/browse/OAK-5046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15633012#comment-15633012
]
Alex Parvulescu commented on OAK-5046:
--
right, let's look at the entire picture now. if I'm running an
[
https://issues.apache.org/jira/browse/OAK-5046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15632966#comment-15632966
]
Andrei Dulceanu commented on OAK-5046:
--
bq Also, How does the current code deal with disabling the
[
https://issues.apache.org/jira/browse/OAK-5046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15632945#comment-15632945
]
Alex Parvulescu commented on OAK-5046:
--
bq. I have one question though: does it make sense to have
[
https://issues.apache.org/jira/browse/OAK-5046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15632859#comment-15632859
]
Andrei Dulceanu commented on OAK-5046:
--
Created OAK-5058 to track this.
> Remove the old estimation
[
https://issues.apache.org/jira/browse/OAK-5046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15632404#comment-15632404
]
Alex Parvulescu commented on OAK-5046:
--
bq. we want to get rid of everything involving the old
[
https://issues.apache.org/jira/browse/OAK-5046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15632193#comment-15632193
]
Andrei Dulceanu commented on OAK-5046:
--
That's exactly what I was thinking, but my wording might have
[
https://issues.apache.org/jira/browse/OAK-5046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15632189#comment-15632189
]
Michael Dürig commented on OAK-5046:
I think it should be the other way around as we should avoid
[
https://issues.apache.org/jira/browse/OAK-5046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15632169#comment-15632169
]
Andrei Dulceanu commented on OAK-5046:
--
I know it sounds complicated, but would it be an option to have
[
https://issues.apache.org/jira/browse/OAK-5046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15632158#comment-15632158
]
Michael Dürig commented on OAK-5046:
My reasoning for using an absolute threshold instead of a relative
[
https://issues.apache.org/jira/browse/OAK-5046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15632142#comment-15632142
]
Michael Dürig commented on OAK-5046:
+1 to the idea to decouple whether estimation should run at all
[
https://issues.apache.org/jira/browse/OAK-5046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15632132#comment-15632132
]
Andrei Dulceanu commented on OAK-5046:
--
After carefully reading the code and all its implications, I
[
https://issues.apache.org/jira/browse/OAK-5046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15629467#comment-15629467
]
Alex Parvulescu commented on OAK-5046:
--
The provided patch has 2 problems:
* first setting the
[
https://issues.apache.org/jira/browse/OAK-5046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15628495#comment-15628495
]
Michael Dürig commented on OAK-5046:
Fine with me. Although I'd prefer to remove the old code unless we
[
https://issues.apache.org/jira/browse/OAK-5046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15628487#comment-15628487
]
Andrei Dulceanu commented on OAK-5046:
--
Per [~alexparvulescu]'s suggestion, currently the focus is only
16 matches
Mail list logo
