[jira] [Commented] (OAK-553) Add NameMapper#getValidOakName that never returns null

2013-01-16 Thread Jukka Zitting (JIRA)
[ https://issues.apache.org/jira/browse/OAK-553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13554950#comment-13554950 ] Jukka Zitting commented on OAK-553: --- bq. mapper.getJcrName(mapper.getOakName(name)); I

[jira] [Commented] (OAK-553) Add NameMapper#getValidOakName that never returns null

2013-01-16 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/OAK-553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13554958#comment-13554958 ] Thomas Mueller commented on OAK-553: catching and re-throwing instead of null checking

[jira] [Commented] (OAK-553) Add NameMapper#getValidOakName that never returns null

2013-01-16 Thread angela (JIRA)
[ https://issues.apache.org/jira/browse/OAK-553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13555022#comment-13555022 ] angela commented on OAK-553: in the security code that is located in oak-core i don't have access

[jira] [Commented] (OAK-553) Add NameMapper#getValidOakName that never returns null

2013-01-16 Thread Jukka Zitting (JIRA)
[ https://issues.apache.org/jira/browse/OAK-553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13555029#comment-13555029 ] Jukka Zitting commented on OAK-553: --- bq. there is quite a lot of code that doesn't check

[jira] [Commented] (OAK-553) Add NameMapper#getValidOakName that never returns null

2013-01-16 Thread angela (JIRA)
[ https://issues.apache.org/jira/browse/OAK-553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13555066#comment-13555066 ] angela commented on OAK-553: regarding NameMapper.normalizeJcrName(name): i would prefer to

[jira] [Commented] (OAK-553) Add NameMapper#getValidOakName that never returns null

2013-01-15 Thread JIRA
[ https://issues.apache.org/jira/browse/OAK-553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13553674#comment-13553674 ] Michael Dürig commented on OAK-553: --- bq. we keep adding methods that convert a jcrName into

[jira] [Commented] (OAK-553) Add NameMapper#getValidOakName that never returns null

2013-01-15 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/OAK-553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13553891#comment-13553891 ] Thomas Mueller commented on OAK-553: A relatively common pattern seems to be: