[jira] [Commented] (OAK-560) MongoMK.commit() not atomic

2013-01-28 Thread Mete Atamel (JIRA)
[ https://issues.apache.org/jira/browse/OAK-560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13564366#comment-13564366 ] Mete Atamel commented on OAK-560: - Yes, this is a valid approach and could work but it will c

[jira] [Commented] (OAK-560) MongoMK.commit() not atomic

2013-01-28 Thread Marcel Reutegger (JIRA)
[ https://issues.apache.org/jira/browse/OAK-560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13564351#comment-13564351 ] Marcel Reutegger commented on OAK-560: -- Here's an alternative approach I'm considering:

[jira] [Commented] (OAK-560) MongoMK.commit() not atomic

2013-01-17 Thread Marcel Reutegger (JIRA)
[ https://issues.apache.org/jira/browse/OAK-560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13556324#comment-13556324 ] Marcel Reutegger commented on OAK-560: -- In addition, CommitCommandNew.prepareCommit() do

[jira] [Commented] (OAK-560) MongoMK.commit() not atomic

2013-01-17 Thread Marcel Reutegger (JIRA)
[ https://issues.apache.org/jira/browse/OAK-560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13556319#comment-13556319 ] Marcel Reutegger commented on OAK-560: -- The problem is a combination of two things: * h

[jira] [Commented] (OAK-560) MongoMK.commit() not atomic

2013-01-17 Thread Mete Atamel (JIRA)
[ https://issues.apache.org/jira/browse/OAK-560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13556269#comment-13556269 ] Mete Atamel commented on OAK-560: - Yeah something is not right, either how head revision is f

[jira] [Commented] (OAK-560) MongoMK.commit() not atomic

2013-01-17 Thread Marcel Reutegger (JIRA)
[ https://issues.apache.org/jira/browse/OAK-560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13556199#comment-13556199 ] Marcel Reutegger commented on OAK-560: -- You are right, I didn't consider the branch comm

[jira] [Commented] (OAK-560) MongoMK.commit() not atomic

2013-01-17 Thread Mete Atamel (JIRA)
[ https://issues.apache.org/jira/browse/OAK-560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13556164#comment-13556164 ] Mete Atamel commented on OAK-560: - Ignore my previous comment, it doesn't solve the problem e

[jira] [Commented] (OAK-560) MongoMK.commit() not atomic

2013-01-17 Thread Marcel Reutegger (JIRA)
[ https://issues.apache.org/jira/browse/OAK-560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13556157#comment-13556157 ] Marcel Reutegger commented on OAK-560: -- bq. base revision commit can be invalid How is

[jira] [Commented] (OAK-560) MongoMK.commit() not atomic

2013-01-17 Thread Mete Atamel (JIRA)
[ https://issues.apache.org/jira/browse/OAK-560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13556144#comment-13556144 ] Mete Atamel commented on OAK-560: - Hmm, not sure, maybe. But now I think the problem might be

[jira] [Commented] (OAK-560) MongoMK.commit() not atomic

2013-01-17 Thread Marcel Reutegger (JIRA)
[ https://issues.apache.org/jira/browse/OAK-560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13556082#comment-13556082 ] Marcel Reutegger commented on OAK-560: -- Hmm, that looks a bit strange. I'd rather have n

[jira] [Commented] (OAK-560) MongoMK.commit() not atomic

2013-01-17 Thread Mete Atamel (JIRA)
[ https://issues.apache.org/jira/browse/OAK-560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13556063#comment-13556063 ] Mete Atamel commented on OAK-560: - I think the problem is how the branch id is retrieved from

[jira] [Commented] (OAK-560) MongoMK.commit() not atomic

2013-01-16 Thread Mete Atamel (JIRA)
[ https://issues.apache.org/jira/browse/OAK-560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13555175#comment-13555175 ] Mete Atamel commented on OAK-560: - Interesting. Can we start with 'failed = true' when we sav