[jira] [Commented] (OAK-5600) Test coverage for CheckCommand

2017-02-24 Thread Andrei Dulceanu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15882783#comment-15882783 ] Andrei Dulceanu commented on OAK-5600: -- bq. how does the consistency checker behave if no filter paths

[jira] [Commented] (OAK-5600) Test coverage for CheckCommand

2017-02-24 Thread JIRA
[ https://issues.apache.org/jira/browse/OAK-5600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15882769#comment-15882769 ] Michael Dürig commented on OAK-5600: Test case looks good. Thinking about edge cases: how does the

[jira] [Commented] (OAK-5600) Test coverage for CheckCommand

2017-02-22 Thread Andrei Dulceanu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15878033#comment-15878033 ] Andrei Dulceanu commented on OAK-5600: -- Committed the latest patch at r1784012. [~mduerig], thanks for

[jira] [Commented] (OAK-5600) Test coverage for CheckCommand

2017-02-22 Thread JIRA
[ https://issues.apache.org/jira/browse/OAK-5600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15878002#comment-15878002 ] Michael Dürig commented on OAK-5600: Good stuff, I like the patch. What I like least is the

[jira] [Commented] (OAK-5600) Test coverage for CheckCommand

2017-02-13 Thread Andrei Dulceanu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15863615#comment-15863615 ] Andrei Dulceanu commented on OAK-5600: -- Committed the partial patch at r1782761. [~frm], thanks for

[jira] [Commented] (OAK-5600) Test coverage for CheckCommand

2017-02-13 Thread Francesco Mari (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15863579#comment-15863579 ] Francesco Mari commented on OAK-5600: - [~dulceanu], I like this solution way more. Thanks for taking the

[jira] [Commented] (OAK-5600) Test coverage for CheckCommand

2017-02-13 Thread JIRA
[ https://issues.apache.org/jira/browse/OAK-5600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15863327#comment-15863327 ] Michael Dürig commented on OAK-5600: bq. BTW, how does one get a broken repository in a reproducible

[jira] [Commented] (OAK-5600) Test coverage for CheckCommand

2017-02-10 Thread Francesco Mari (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15861206#comment-15861206 ] Francesco Mari commented on OAK-5600: - At the end of {{CheckValidRepositoryTest#testCorrectParams}} you