[jira] [Commented] (OAK-8948) PathUtils. unifyInExcludes throws NPE when 'exclude' is null

2020-03-13 Thread rafiya sirin (Jira)
[ https://issues.apache.org/jira/browse/OAK-8948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17058735#comment-17058735 ] rafiya sirin commented on OAK-8948: --- [~mreutegg] , looks good.  > PathUtils. unifyInExcludes throws NPE

[jira] [Commented] (OAK-8948) PathUtils. unifyInExcludes throws NPE when 'exclude' is null

2020-03-13 Thread Marcel Reutegger (Jira)
[ https://issues.apache.org/jira/browse/OAK-8948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17058733#comment-17058733 ] Marcel Reutegger commented on OAK-8948: --- Thanks for the test. I still prefer an exception on an

[jira] [Commented] (OAK-8948) PathUtils. unifyInExcludes throws NPE when 'exclude' is null

2020-03-13 Thread rafiya sirin (Jira)
[ https://issues.apache.org/jira/browse/OAK-8948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17058692#comment-17058692 ] rafiya sirin commented on OAK-8948: --- [~mreutegg] for your question as to what path was passed, i have

[jira] [Commented] (OAK-8948) PathUtils. unifyInExcludes throws NPE when 'exclude' is null

2020-03-13 Thread rafiya sirin (Jira)
[ https://issues.apache.org/jira/browse/OAK-8948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17058690#comment-17058690 ] rafiya sirin commented on OAK-8948: --- [~mreutegg] I received comments on similar lines, and updated the PR

[jira] [Commented] (OAK-8948) PathUtils. unifyInExcludes throws NPE when 'exclude' is null

2020-03-13 Thread Marcel Reutegger (Jira)
[ https://issues.apache.org/jira/browse/OAK-8948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17058608#comment-17058608 ] Marcel Reutegger commented on OAK-8948: --- I suggest to fix it like this: [^OAK-8948.patch]. This means

[jira] [Commented] (OAK-8948) PathUtils. unifyInExcludes throws NPE when 'exclude' is null

2020-03-13 Thread Marcel Reutegger (Jira)
[ https://issues.apache.org/jira/browse/OAK-8948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17058599#comment-17058599 ] Marcel Reutegger commented on OAK-8948: --- Apologies, I was confused by line numbers because I was

[jira] [Commented] (OAK-8948) PathUtils. unifyInExcludes throws NPE when 'exclude' is null

2020-03-13 Thread rafiya sirin (Jira)
[ https://issues.apache.org/jira/browse/OAK-8948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17058524#comment-17058524 ] rafiya sirin commented on OAK-8948: --- the issue that i face is with excludePaths, in if

[jira] [Commented] (OAK-8948) PathUtils. unifyInExcludes throws NPE when 'exclude' is null

2020-03-13 Thread Marcel Reutegger (Jira)
[ https://issues.apache.org/jira/browse/OAK-8948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17058516#comment-17058516 ] Marcel Reutegger commented on OAK-8948: --- The method {{ObservationManagerImpl.addEventListener()}}

[jira] [Commented] (OAK-8948) PathUtils. unifyInExcludes throws NPE when 'exclude' is null

2020-03-12 Thread rafiya sirin (Jira)
[ https://issues.apache.org/jira/browse/OAK-8948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17058249#comment-17058249 ] rafiya sirin commented on OAK-8948: --- Will a logger (warn level) also be required/recommended in

[jira] [Commented] (OAK-8948) PathUtils. unifyInExcludes throws NPE when 'exclude' is null

2020-03-11 Thread rafiya sirin (Jira)
[ https://issues.apache.org/jira/browse/OAK-8948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17057239#comment-17057239 ] rafiya sirin commented on OAK-8948: --- PR  : [https://github.com/apache/jackrabbit-oak/pull/196] >