[jira] [Commented] (OAK-10304) log registration of invalid namespace names

2023-06-20 Thread Julian Reschke (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-10304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17735402#comment-17735402
 ] 

Julian Reschke commented on OAK-10304:
--

I've done some experimentation.

One issue is that regular registration of namespaces upon repo startup goes 
through the same calls; so it's not trivial to distinguish between *initial* 
registration of an invalid namespace (that we would want to log), or regular 
startup of a repo that already has one.

These calls go through jcr-commons (CND reader), and that uses the javax.jcr 
interface, so extending the API to distinguish the cases is not an option.

We *could* check for invalid namespace names, and only then inspect the call 
stack. It's a bit hacky, but might work.

Thoughts? 

cc [~mreutegg] and [~angela]?

> log registration of invalid namespace names
> ---
>
> Key: OAK-10304
> URL: https://issues.apache.org/jira/browse/OAK-10304
> Project: Jackrabbit Oak
>  Issue Type: Task
>  Components: core, jcr
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Major
> Fix For: 1.54.0
>
>
> Example:
> {noformat}
> diff --git 
> a/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/RepositoryTest.java 
> b/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/RepositoryTest.java
> index f113e4e0d2..7178a36f7f 100644
> --- a/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/RepositoryTest.java
> +++ b/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/RepositoryTest.java
> @@ -1996,6 +1996,24 @@ public class RepositoryTest extends 
> AbstractRepositoryTest {
>  assertFalse(asList(nsReg.getURIs()).contains("file:///foo"));
>  }
> +@Test
> +public void testNamespaceNames() throws RepositoryException {
> +NamespaceRegistry nsReg =
> +getAdminSession().getWorkspace().getNamespaceRegistry();
> +
> +// valid
> +nsReg.registerNamespace("foo", "https://example.com;);
> +nsReg.unregisterNamespace("foo");
> +
> +// invalid
> +try {
> +nsReg.registerNamespace("foo", "example.com");
> +fail("should not register invalid namespace name");
> +} finally {
> +nsReg.unregisterNamespace("foo");
> +}
> +}
> {noformat}
> Note that name of nodes using invalid namespaces do have a valid "expanded 
> form" variant 
> (https://developer.adobe.com/experience-manager/reference-materials/spec/jcr/2.0/3_Repository_Model.html#3.2.5.1%20Expanded%20Form).
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OAK-10307) oak-shaded-guava leaks original guava as transitive dependency

2023-06-20 Thread Julian Reschke (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-10307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17735366#comment-17735366
 ] 

Julian Reschke commented on OAK-10307:
--

trunk: 
[ca1f444a04|https://github.com/apache/jackrabbit-oak/commit/ca1f444a049c74ed2b9e869e33683fdd72750186]
 
[7a0b459dc4|https://github.com/apache/jackrabbit-oak/commit/7a0b459dc46ef649d45bad003c120df67e337e5a]
 
[91d10c9f71|https://github.com/apache/jackrabbit-oak/commit/91d10c9f7133d3fee5b9a8738c651d4620a2a361]
 
[8dc7950337|https://github.com/apache/jackrabbit-oak/commit/8dc79503376890a0d9ed5e7a602a6e380e2a0113]
 
[a02cbb9d0b|https://github.com/apache/jackrabbit-oak/commit/a02cbb9d0b221260d240f2f81571b1d10db60502]
 
[1d6581bb10|https://github.com/apache/jackrabbit-oak/commit/1d6581bb10b5d23f639b52da57eb41013b000d2f]


> oak-shaded-guava leaks original guava as transitive dependency
> --
>
> Key: OAK-10307
> URL: https://issues.apache.org/jira/browse/OAK-10307
> Project: Jackrabbit Oak
>  Issue Type: Technical task
>  Components: shaded-guava
>Reporter: Marcel Reutegger
>Assignee: Julian Reschke
>Priority: Major
> Fix For: 1.54.0
>
>
> oak-shaded-guava currently declares a compile dependency on original guava. 
> This means modules using oak-shaded-guava will transitively get original 
> guava and mistakingly use classes from there.
> {noformat}
> $ mvn dependency:tree -pl :oak-shaded-guava
> [INFO] Scanning for projects...
> [INFO]
> [INFO] ---< org.apache.jackrabbit:oak-shaded-guava 
> >---
> [INFO] Building Jackrabbit Guava Wrapper 1.53-SNAPSHOT
> [INFO]   from pom.xml
> [INFO] ---[ bundle 
> ]---
> [INFO]
> [INFO] --- dependency:3.4.0:tree (default-cli) @ oak-shaded-guava ---
> [INFO] org.apache.jackrabbit:oak-shaded-guava:bundle:1.53-SNAPSHOT
> [INFO] +- com.google.guava:guava:jar:32.0.1-jre:compile
> [INFO] |  +- com.google.guava:failureaccess:jar:1.0.1:compile
> [INFO] |  +- 
> com.google.guava:listenablefuture:jar:.0-empty-to-avoid-conflict-with-guava:compile
> [INFO] |  +- com.google.code.findbugs:jsr305:jar:3.0.2:compile
> [INFO] |  +- org.checkerframework:checker-qual:jar:3.33.0:compile
> [INFO] |  +- com.google.errorprone:error_prone_annotations:jar:2.18.0:compile
> [INFO] |  \- com.google.j2objc:j2objc-annotations:jar:2.8:compile
> [INFO] +- org.osgi:org.osgi.annotation:jar:6.0.0:provided
> [INFO] \- org.jetbrains:annotations:jar:18.0.0:provided
> {noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] (OAK-10307) oak-shaded-guava leaks original guava as transitive dependency

2023-06-20 Thread Julian Reschke (Jira)


[ https://issues.apache.org/jira/browse/OAK-10307 ]


Julian Reschke deleted comment on OAK-10307:
--

was (Author: reschke):
trunk: 
[7a0b459dc4|https://github.com/apache/jackrabbit-oak/commit/7a0b459dc46ef649d45bad003c120df67e337e5a]
 
[91d10c9f71|https://github.com/apache/jackrabbit-oak/commit/91d10c9f7133d3fee5b9a8738c651d4620a2a361]
 
[8dc7950337|https://github.com/apache/jackrabbit-oak/commit/8dc79503376890a0d9ed5e7a602a6e380e2a0113]
 
[a02cbb9d0b|https://github.com/apache/jackrabbit-oak/commit/a02cbb9d0b221260d240f2f81571b1d10db60502]
 
[1d6581bb10|https://github.com/apache/jackrabbit-oak/commit/1d6581bb10b5d23f639b52da57eb41013b000d2f]


> oak-shaded-guava leaks original guava as transitive dependency
> --
>
> Key: OAK-10307
> URL: https://issues.apache.org/jira/browse/OAK-10307
> Project: Jackrabbit Oak
>  Issue Type: Technical task
>  Components: shaded-guava
>Reporter: Marcel Reutegger
>Assignee: Julian Reschke
>Priority: Major
> Fix For: 1.54.0
>
>
> oak-shaded-guava currently declares a compile dependency on original guava. 
> This means modules using oak-shaded-guava will transitively get original 
> guava and mistakingly use classes from there.
> {noformat}
> $ mvn dependency:tree -pl :oak-shaded-guava
> [INFO] Scanning for projects...
> [INFO]
> [INFO] ---< org.apache.jackrabbit:oak-shaded-guava 
> >---
> [INFO] Building Jackrabbit Guava Wrapper 1.53-SNAPSHOT
> [INFO]   from pom.xml
> [INFO] ---[ bundle 
> ]---
> [INFO]
> [INFO] --- dependency:3.4.0:tree (default-cli) @ oak-shaded-guava ---
> [INFO] org.apache.jackrabbit:oak-shaded-guava:bundle:1.53-SNAPSHOT
> [INFO] +- com.google.guava:guava:jar:32.0.1-jre:compile
> [INFO] |  +- com.google.guava:failureaccess:jar:1.0.1:compile
> [INFO] |  +- 
> com.google.guava:listenablefuture:jar:.0-empty-to-avoid-conflict-with-guava:compile
> [INFO] |  +- com.google.code.findbugs:jsr305:jar:3.0.2:compile
> [INFO] |  +- org.checkerframework:checker-qual:jar:3.33.0:compile
> [INFO] |  +- com.google.errorprone:error_prone_annotations:jar:2.18.0:compile
> [INFO] |  \- com.google.j2objc:j2objc-annotations:jar:2.8:compile
> [INFO] +- org.osgi:org.osgi.annotation:jar:6.0.0:provided
> [INFO] \- org.jetbrains:annotations:jar:18.0.0:provided
> {noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Resolved] (OAK-10307) oak-shaded-guava leaks original guava as transitive dependency

2023-06-20 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-10307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke resolved OAK-10307.
--
Resolution: Fixed

> oak-shaded-guava leaks original guava as transitive dependency
> --
>
> Key: OAK-10307
> URL: https://issues.apache.org/jira/browse/OAK-10307
> Project: Jackrabbit Oak
>  Issue Type: Technical task
>  Components: shaded-guava
>Reporter: Marcel Reutegger
>Assignee: Julian Reschke
>Priority: Major
> Fix For: 1.54.0
>
>
> oak-shaded-guava currently declares a compile dependency on original guava. 
> This means modules using oak-shaded-guava will transitively get original 
> guava and mistakingly use classes from there.
> {noformat}
> $ mvn dependency:tree -pl :oak-shaded-guava
> [INFO] Scanning for projects...
> [INFO]
> [INFO] ---< org.apache.jackrabbit:oak-shaded-guava 
> >---
> [INFO] Building Jackrabbit Guava Wrapper 1.53-SNAPSHOT
> [INFO]   from pom.xml
> [INFO] ---[ bundle 
> ]---
> [INFO]
> [INFO] --- dependency:3.4.0:tree (default-cli) @ oak-shaded-guava ---
> [INFO] org.apache.jackrabbit:oak-shaded-guava:bundle:1.53-SNAPSHOT
> [INFO] +- com.google.guava:guava:jar:32.0.1-jre:compile
> [INFO] |  +- com.google.guava:failureaccess:jar:1.0.1:compile
> [INFO] |  +- 
> com.google.guava:listenablefuture:jar:.0-empty-to-avoid-conflict-with-guava:compile
> [INFO] |  +- com.google.code.findbugs:jsr305:jar:3.0.2:compile
> [INFO] |  +- org.checkerframework:checker-qual:jar:3.33.0:compile
> [INFO] |  +- com.google.errorprone:error_prone_annotations:jar:2.18.0:compile
> [INFO] |  \- com.google.j2objc:j2objc-annotations:jar:2.8:compile
> [INFO] +- org.osgi:org.osgi.annotation:jar:6.0.0:provided
> [INFO] \- org.jetbrains:annotations:jar:18.0.0:provided
> {noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Comment Edited] (OAK-10307) oak-shaded-guava leaks original guava as transitive dependency

2023-06-20 Thread Julian Reschke (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-10307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17735356#comment-17735356
 ] 

Julian Reschke edited comment on OAK-10307 at 6/20/23 4:32 PM:
---

Re-opening, as oak-core still uses classic Guava now fails to build when not 
built from the reactor pom.


was (Author: reschke):
Re-opening, as those sub projects that still use classic Guava now fail to 
build when not built from the reactor pom.

> oak-shaded-guava leaks original guava as transitive dependency
> --
>
> Key: OAK-10307
> URL: https://issues.apache.org/jira/browse/OAK-10307
> Project: Jackrabbit Oak
>  Issue Type: Technical task
>  Components: shaded-guava
>Reporter: Marcel Reutegger
>Assignee: Julian Reschke
>Priority: Major
> Fix For: 1.54.0
>
>
> oak-shaded-guava currently declares a compile dependency on original guava. 
> This means modules using oak-shaded-guava will transitively get original 
> guava and mistakingly use classes from there.
> {noformat}
> $ mvn dependency:tree -pl :oak-shaded-guava
> [INFO] Scanning for projects...
> [INFO]
> [INFO] ---< org.apache.jackrabbit:oak-shaded-guava 
> >---
> [INFO] Building Jackrabbit Guava Wrapper 1.53-SNAPSHOT
> [INFO]   from pom.xml
> [INFO] ---[ bundle 
> ]---
> [INFO]
> [INFO] --- dependency:3.4.0:tree (default-cli) @ oak-shaded-guava ---
> [INFO] org.apache.jackrabbit:oak-shaded-guava:bundle:1.53-SNAPSHOT
> [INFO] +- com.google.guava:guava:jar:32.0.1-jre:compile
> [INFO] |  +- com.google.guava:failureaccess:jar:1.0.1:compile
> [INFO] |  +- 
> com.google.guava:listenablefuture:jar:.0-empty-to-avoid-conflict-with-guava:compile
> [INFO] |  +- com.google.code.findbugs:jsr305:jar:3.0.2:compile
> [INFO] |  +- org.checkerframework:checker-qual:jar:3.33.0:compile
> [INFO] |  +- com.google.errorprone:error_prone_annotations:jar:2.18.0:compile
> [INFO] |  \- com.google.j2objc:j2objc-annotations:jar:2.8:compile
> [INFO] +- org.osgi:org.osgi.annotation:jar:6.0.0:provided
> [INFO] \- org.jetbrains:annotations:jar:18.0.0:provided
> {noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Reopened] (OAK-10307) oak-shaded-guava leaks original guava as transitive dependency

2023-06-20 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-10307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke reopened OAK-10307:
--

Re-opening, as those sub projects that still use classic Guava now fail to 
build when not built from the reactor pom.

> oak-shaded-guava leaks original guava as transitive dependency
> --
>
> Key: OAK-10307
> URL: https://issues.apache.org/jira/browse/OAK-10307
> Project: Jackrabbit Oak
>  Issue Type: Technical task
>  Components: shaded-guava
>Reporter: Marcel Reutegger
>Assignee: Julian Reschke
>Priority: Major
> Fix For: 1.54.0
>
>
> oak-shaded-guava currently declares a compile dependency on original guava. 
> This means modules using oak-shaded-guava will transitively get original 
> guava and mistakingly use classes from there.
> {noformat}
> $ mvn dependency:tree -pl :oak-shaded-guava
> [INFO] Scanning for projects...
> [INFO]
> [INFO] ---< org.apache.jackrabbit:oak-shaded-guava 
> >---
> [INFO] Building Jackrabbit Guava Wrapper 1.53-SNAPSHOT
> [INFO]   from pom.xml
> [INFO] ---[ bundle 
> ]---
> [INFO]
> [INFO] --- dependency:3.4.0:tree (default-cli) @ oak-shaded-guava ---
> [INFO] org.apache.jackrabbit:oak-shaded-guava:bundle:1.53-SNAPSHOT
> [INFO] +- com.google.guava:guava:jar:32.0.1-jre:compile
> [INFO] |  +- com.google.guava:failureaccess:jar:1.0.1:compile
> [INFO] |  +- 
> com.google.guava:listenablefuture:jar:.0-empty-to-avoid-conflict-with-guava:compile
> [INFO] |  +- com.google.code.findbugs:jsr305:jar:3.0.2:compile
> [INFO] |  +- org.checkerframework:checker-qual:jar:3.33.0:compile
> [INFO] |  +- com.google.errorprone:error_prone_annotations:jar:2.18.0:compile
> [INFO] |  \- com.google.j2objc:j2objc-annotations:jar:2.8:compile
> [INFO] +- org.osgi:org.osgi.annotation:jar:6.0.0:provided
> [INFO] \- org.jetbrains:annotations:jar:18.0.0:provided
> {noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OAK-5782) Test failure: persistentCache.BroadcastTest.broadcastTCP

2023-06-20 Thread Marcel Reutegger (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-5782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17735347#comment-17735347
 ] 

Marcel Reutegger commented on OAK-5782:
---

PR to ignore the test: https://github.com/apache/jackrabbit-oak/pull/997

> Test failure: persistentCache.BroadcastTest.broadcastTCP 
> -
>
> Key: OAK-5782
> URL: https://issues.apache.org/jira/browse/OAK-5782
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: cache, continuous integration, core
>Affects Versions: 1.6.0
>Reporter: Hudson
>Assignee: Marcel Reutegger
>Priority: Major
>  Labels: test-failure, ubuntu
>
> Jenkins CI failure: 
> https://builds.apache.org/job/Apache%20Jackrabbit%20Oak%20matrix/
> The build Apache Jackrabbit Oak matrix/Ubuntu Slaves=ubuntu,jdk=JDK 1.8 
> (latest),nsfixtures=SEGMENT_TAR,profile=unittesting #1447 has failed.
> First failed run: [Apache Jackrabbit Oak matrix/Ubuntu Slaves=ubuntu,jdk=JDK 
> 1.8 (latest),nsfixtures=SEGMENT_TAR,profile=unittesting 
> #1447|https://builds.apache.org/job/Apache%20Jackrabbit%20Oak%20matrix/Ubuntu%20Slaves=ubuntu,jdk=JDK%201.8%20(latest),nsfixtures=SEGMENT_TAR,profile=unittesting/1447/]
>  [console 
> log|https://builds.apache.org/job/Apache%20Jackrabbit%20Oak%20matrix/Ubuntu%20Slaves=ubuntu,jdk=JDK%201.8%20(latest),nsfixtures=SEGMENT_TAR,profile=unittesting/1447/console]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Reopened] (OAK-5782) Test failure: persistentCache.BroadcastTest.broadcastTCP

2023-06-20 Thread Marcel Reutegger (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-5782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Marcel Reutegger reopened OAK-5782:
---
  Assignee: Marcel Reutegger  (was: Thomas Mueller)

Still fails occasionally.
{noformat}
[ERROR] 
broadcastTCP(org.apache.jackrabbit.oak.plugins.document.persistentCache.BroadcastTest)
  Time elapsed: 10.125 s  <<< FAILURE! java.lang.AssertionError: expected null, 
but was:
at org.junit.Assert.fail(Assert.java:89)
at org.junit.Assert.failNotNull(Assert.java:756)
at org.junit.Assert.assertNull(Assert.java:738)
at org.junit.Assert.assertNull(Assert.java:748)
at 
org.apache.jackrabbit.oak.plugins.document.persistentCache.BroadcastTest.broadcastTry(BroadcastTest.java:223)
at 
org.apache.jackrabbit.oak.plugins.document.persistentCache.BroadcastTest.broadcast(BroadcastTest.java:196)
at 
org.apache.jackrabbit.oak.plugins.document.persistentCache.BroadcastTest.broadcastTCP(BroadcastTest.java:147)
{noformat}

> Test failure: persistentCache.BroadcastTest.broadcastTCP 
> -
>
> Key: OAK-5782
> URL: https://issues.apache.org/jira/browse/OAK-5782
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: cache, continuous integration, core
>Affects Versions: 1.6.0
>Reporter: Hudson
>Assignee: Marcel Reutegger
>Priority: Major
>  Labels: test-failure, ubuntu
>
> Jenkins CI failure: 
> https://builds.apache.org/job/Apache%20Jackrabbit%20Oak%20matrix/
> The build Apache Jackrabbit Oak matrix/Ubuntu Slaves=ubuntu,jdk=JDK 1.8 
> (latest),nsfixtures=SEGMENT_TAR,profile=unittesting #1447 has failed.
> First failed run: [Apache Jackrabbit Oak matrix/Ubuntu Slaves=ubuntu,jdk=JDK 
> 1.8 (latest),nsfixtures=SEGMENT_TAR,profile=unittesting 
> #1447|https://builds.apache.org/job/Apache%20Jackrabbit%20Oak%20matrix/Ubuntu%20Slaves=ubuntu,jdk=JDK%201.8%20(latest),nsfixtures=SEGMENT_TAR,profile=unittesting/1447/]
>  [console 
> log|https://builds.apache.org/job/Apache%20Jackrabbit%20Oak%20matrix/Ubuntu%20Slaves=ubuntu,jdk=JDK%201.8%20(latest),nsfixtures=SEGMENT_TAR,profile=unittesting/1447/console]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OAK-10315) Counter for DocumentStore check

2023-06-20 Thread Marcel Reutegger (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-10315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17735336#comment-17735336
 ] 

Marcel Reutegger commented on OAK-10315:


Proposed implementation: https://github.com/apache/jackrabbit-oak/pull/996

> Counter for DocumentStore check
> ---
>
> Key: OAK-10315
> URL: https://issues.apache.org/jira/browse/OAK-10315
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: run
>Reporter: Marcel Reutegger
>Assignee: Marcel Reutegger
>Priority: Minor
>
> Introduce a counter option for the documentstore-check command in oak-run. 
> The option should enable a processor that counts the number of documents and 
> nodes that exist. The ratio is useful to determine how many documents are 
> considered garbage.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (OAK-10315) Counter for DocumentStore check

2023-06-20 Thread Marcel Reutegger (Jira)
Marcel Reutegger created OAK-10315:
--

 Summary: Counter for DocumentStore check
 Key: OAK-10315
 URL: https://issues.apache.org/jira/browse/OAK-10315
 Project: Jackrabbit Oak
  Issue Type: Improvement
  Components: run
Reporter: Marcel Reutegger
Assignee: Marcel Reutegger


Introduce a counter option for the documentstore-check command in oak-run. The 
option should enable a processor that counts the number of documents and nodes 
that exist. The ratio is useful to determine how many documents are considered 
garbage.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (OAK-10279) oak-webapp project webdav

2023-06-20 Thread balamir kodak (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-10279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

balamir kodak updated OAK-10279:

Issue Type: Bug  (was: Wish)

> oak-webapp project webdav
> -
>
> Key: OAK-10279
> URL: https://issues.apache.org/jira/browse/OAK-10279
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: webapp
>Affects Versions: 1.50.0
> Environment: Windows 10 Pro
>Reporter: balamir kodak
>Priority: Major
>
> I tested webdav feature in oak-webapp project through LibreOffice Writer 
> 7.5.2.2 on Windows 10 environment . I could open document but when i trried 
> to save i get a "412 Precondition Failed" response. As a result, the document 
> was both locked and not updated.
> When i checked the req-response headers i saw that  Libre Office send 
> opequetoken as uppaercase in if request header.
> When I convert ".equals" calls to ".equalsIgnoreCase" in the following 
> methods ; 
> org.apache.jackrabbit.webdav.header.IfHeader.match(String value)
> org.apache.jackrabbit.webdav.jcr.lock.JcrActiveLock.isLockedByToken(String 
> lockToken)
> org.apache.jackrabbit.webdav.simple.DavResourceImpl.isLocked(DavResource res)
> The document was successfully updated and I didn't have any lock problems.
> Is it a bug or enhancement, How should I proceed here. Should i persist my 
> changes on code,  or do someething else ? 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OAK-10288) mvn test for oak-commons fails in top level directory, but not in project directory

2023-06-20 Thread Julian Reschke (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-10288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17735230#comment-17735230
 ] 

Julian Reschke commented on OAK-10288:
--

So the difference is that "mvn test" in the subproject pulls the shaded-guava 
jar from the local M2 repo, while when run from the reactor pom, it adds 
"oak-shaded-guava/target/classes" to the class path. And that folder does not 
contain any class files. (Why?)

> mvn test for oak-commons fails in top level directory, but not in project 
> directory
> ---
>
> Key: OAK-10288
> URL: https://issues.apache.org/jira/browse/OAK-10288
> Project: Jackrabbit Oak
>  Issue Type: Test
>  Components: commons
>Reporter: Manfred Baedke
>Priority: Minor
>
> While
> {code:java}
> mvn clean install{code}
> is running fine,
> {code:java}
> mvn test{code}
> is failing due to
> {code:java}
> java.lang.ClassNotFoundException: 
> org.apache.jackrabbit.guava.common.collect.Sets{code}
> , but only when run in the top level directory. It will succeed when run in 
> the oak-commons project directory.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OAK-10288) mvn test for oak-commons fails in top level directory, but not in project directory

2023-06-20 Thread Julian Reschke (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-10288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17735213#comment-17735213
 ] 

Julian Reschke commented on OAK-10288:
--

So, the transitive dependency is fixed, but the problem stays. "git bisect" 
finds that it exists since we switched oak-commons to shaded-guava (OAK-10179).

This may actually be not specific to oak-commons; it just happens to be early 
in the build order.

> mvn test for oak-commons fails in top level directory, but not in project 
> directory
> ---
>
> Key: OAK-10288
> URL: https://issues.apache.org/jira/browse/OAK-10288
> Project: Jackrabbit Oak
>  Issue Type: Test
>  Components: commons
>Reporter: Manfred Baedke
>Priority: Minor
>
> While
> {code:java}
> mvn clean install{code}
> is running fine,
> {code:java}
> mvn test{code}
> is failing due to
> {code:java}
> java.lang.ClassNotFoundException: 
> org.apache.jackrabbit.guava.common.collect.Sets{code}
> , but only when run in the top level directory. It will succeed when run in 
> the oak-commons project directory.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)