[jira] [Commented] (OAK-1126) Same node and property name support
[ https://issues.apache.org/jira/browse/OAK-1126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13822380#comment-13822380 ] Marcel Reutegger commented on OAK-1126: --- Reverted the fix in http://svn.apache.org/r1541892 Same node and property name support --- Key: OAK-1126 URL: https://issues.apache.org/jira/browse/OAK-1126 Project: Jackrabbit Oak Issue Type: Sub-task Components: core, doc, jcr Reporter: Tobias Bocanegra Assignee: Tobias Bocanegra Fix For: 0.11 Attachments: 0001-OAK-1126-Same-node-and-property-name-support.patch, 0002-OAK-1126-Same-node-and-property-name-support.patch, OAK-1126.patch Original Estimate: 24h Remaining Estimate: 24h The initial MK abstraction mandated that the nodes and properties share the same namespace (http://wiki.apache.org/jackrabbit/RepositoryMicroKernel#Data%20Model). This is a regression from Jackrabbit 2.x, which supports same name nodes and properties (SNNP). OTOH, the NodeStores can easily support SNNP and with proper escaping, the MKs can also support it. We should try to keep the support for SNNP in order to keep backward compatibility for existing content, and also keep the support for importing XML documents with same attribute and element names. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (OAK-1126) Same node and property name support
[
https://issues.apache.org/jira/browse/OAK-1126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13815496#comment-13815496
]
Tobias Bocanegra commented on OAK-1126:
---
I suggest to go with a compromise:
# let the persistence layer determine if SNNP is supported or not
# don't add any SNNP related checks in the Oak layer and assume it's supported.
advantages:
* the MK API can stay the same
* no unnecessary checks in the Oak layer to check for colliding SNNP
* Oak is backward compatible to JR2.x with persistence implementations that
support SNNP
disadvantages:
* we need to introduce a capabilities interface to the persistence layer
* Oak clients need to be aware that depending on the persistence used, the
repository could behave differently, and need to check the respective
repository descriptor (which they should anyways :-)
changes:
* the value of the {{option.node.and.property.with.same.name.supported}}
descriptor needs to be provided by the persistence layer
* disable SNNP support in the MKs
* enable SNNP support in the NodeStores
Same node and property name support
---
Key: OAK-1126
URL: https://issues.apache.org/jira/browse/OAK-1126
Project: Jackrabbit Oak
Issue Type: Sub-task
Components: core, doc, jcr
Reporter: Tobias Bocanegra
Attachments: 0001-OAK-1126-Same-node-and-property-name-support.patch,
0002-OAK-1126-Same-node-and-property-name-support.patch, OAK-1126.patch
The initial MK abstraction mandated that the nodes and properties share the
same namespace
(http://wiki.apache.org/jackrabbit/RepositoryMicroKernel#Data%20Model). This
is a regression from Jackrabbit 2.x, which supports same name nodes and
properties (SNNP).
OTOH, the NodeStores can easily support SNNP and with proper escaping, the
MKs can also support it.
We should try to keep the support for SNNP in order to keep backward
compatibility for existing content, and also keep the support for importing
XML documents with same attribute and element names.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (OAK-1126) Same node and property name support
[ https://issues.apache.org/jira/browse/OAK-1126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13813766#comment-13813766 ] Stefan Guggisberg commented on OAK-1126: bq. AFAICT the only change to the JSOP format would be to adjust the addNode syntax to use the :children mechanism for child nodes. that's what i meant by json_diff format changes. it's IMO a drastic change since it makes importing arbitrary JSON impossible (or at least very awkward). Same node and property name support --- Key: OAK-1126 URL: https://issues.apache.org/jira/browse/OAK-1126 Project: Jackrabbit Oak Issue Type: Sub-task Components: core, doc, jcr Reporter: Tobias Bocanegra Attachments: 0001-OAK-1126-Same-node-and-property-name-support.patch, 0002-OAK-1126-Same-node-and-property-name-support.patch, OAK-1126.patch The initial MK abstraction mandated that the nodes and properties share the same namespace (http://wiki.apache.org/jackrabbit/RepositoryMicroKernel#Data%20Model). This is a regression from Jackrabbit 2.x, which supports same name nodes and properties (SNNP). OTOH, the NodeStores can easily support SNNP and with proper escaping, the MKs can also support it. We should try to keep the support for SNNP in order to keep backward compatibility for existing content, and also keep the support for importing XML documents with same attribute and element names. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (OAK-1126) Same node and property name support
[ https://issues.apache.org/jira/browse/OAK-1126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13813781#comment-13813781 ] Thomas Mueller commented on OAK-1126: - it makes importing arbitrary JSON impossible Hm, we already have quite a few limitations, for example array may only contain values of the same type, (and not objects). Same node and property name support --- Key: OAK-1126 URL: https://issues.apache.org/jira/browse/OAK-1126 Project: Jackrabbit Oak Issue Type: Sub-task Components: core, doc, jcr Reporter: Tobias Bocanegra Attachments: 0001-OAK-1126-Same-node-and-property-name-support.patch, 0002-OAK-1126-Same-node-and-property-name-support.patch, OAK-1126.patch The initial MK abstraction mandated that the nodes and properties share the same namespace (http://wiki.apache.org/jackrabbit/RepositoryMicroKernel#Data%20Model). This is a regression from Jackrabbit 2.x, which supports same name nodes and properties (SNNP). OTOH, the NodeStores can easily support SNNP and with proper escaping, the MKs can also support it. We should try to keep the support for SNNP in order to keep backward compatibility for existing content, and also keep the support for importing XML documents with same attribute and element names. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (OAK-1126) Same node and property name support
[ https://issues.apache.org/jira/browse/OAK-1126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13813785#comment-13813785 ] Michael Dürig commented on OAK-1126: bq. since it makes importing arbitrary JSON impossible (or at least very awkward). This was never a use case. From the beginning on oak-core was deemed to be the only client to the MicroKernel ever. Same node and property name support --- Key: OAK-1126 URL: https://issues.apache.org/jira/browse/OAK-1126 Project: Jackrabbit Oak Issue Type: Sub-task Components: core, doc, jcr Reporter: Tobias Bocanegra Attachments: 0001-OAK-1126-Same-node-and-property-name-support.patch, 0002-OAK-1126-Same-node-and-property-name-support.patch, OAK-1126.patch The initial MK abstraction mandated that the nodes and properties share the same namespace (http://wiki.apache.org/jackrabbit/RepositoryMicroKernel#Data%20Model). This is a regression from Jackrabbit 2.x, which supports same name nodes and properties (SNNP). OTOH, the NodeStores can easily support SNNP and with proper escaping, the MKs can also support it. We should try to keep the support for SNNP in order to keep backward compatibility for existing content, and also keep the support for importing XML documents with same attribute and element names. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (OAK-1126) Same node and property name support
[ https://issues.apache.org/jira/browse/OAK-1126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13813798#comment-13813798 ] Stefan Guggisberg commented on OAK-1126: bq. This was never a use case. From the beginning on oak-core was deemed to be the only client to the MicroKernel ever. i beg to differ. the MicroKernel API was designed to be portable from scratch. therefore it's obvious that it's possible to implement and use it in different languages/stacks (e.g. c, nodejs, etc). Same node and property name support --- Key: OAK-1126 URL: https://issues.apache.org/jira/browse/OAK-1126 Project: Jackrabbit Oak Issue Type: Sub-task Components: core, doc, jcr Reporter: Tobias Bocanegra Attachments: 0001-OAK-1126-Same-node-and-property-name-support.patch, 0002-OAK-1126-Same-node-and-property-name-support.patch, OAK-1126.patch The initial MK abstraction mandated that the nodes and properties share the same namespace (http://wiki.apache.org/jackrabbit/RepositoryMicroKernel#Data%20Model). This is a regression from Jackrabbit 2.x, which supports same name nodes and properties (SNNP). OTOH, the NodeStores can easily support SNNP and with proper escaping, the MKs can also support it. We should try to keep the support for SNNP in order to keep backward compatibility for existing content, and also keep the support for importing XML documents with same attribute and element names. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (OAK-1126) Same node and property name support
[
https://issues.apache.org/jira/browse/OAK-1126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13813810#comment-13813810
]
angela commented on OAK-1126:
-
{quote}
This was never a use case. From the beginning on oak-core was deemed to be the
only client to the MicroKernel ever.
{quote}
i can confirm this; it was one of the fundamental design decisions and i was
always and officially promised that oak-core was the only way to access the
microkernel when i expressed concerns wrt security of the MK. if this has
changed in the mean time we should also reconsider on how to secure the MK.
Same node and property name support
---
Key: OAK-1126
URL: https://issues.apache.org/jira/browse/OAK-1126
Project: Jackrabbit Oak
Issue Type: Sub-task
Components: core, doc, jcr
Reporter: Tobias Bocanegra
Attachments: 0001-OAK-1126-Same-node-and-property-name-support.patch,
0002-OAK-1126-Same-node-and-property-name-support.patch, OAK-1126.patch
The initial MK abstraction mandated that the nodes and properties share the
same namespace
(http://wiki.apache.org/jackrabbit/RepositoryMicroKernel#Data%20Model). This
is a regression from Jackrabbit 2.x, which supports same name nodes and
properties (SNNP).
OTOH, the NodeStores can easily support SNNP and with proper escaping, the
MKs can also support it.
We should try to keep the support for SNNP in order to keep backward
compatibility for existing content, and also keep the support for importing
XML documents with same attribute and element names.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (OAK-1126) Same node and property name support
[ https://issues.apache.org/jira/browse/OAK-1126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13813970#comment-13813970 ] Geoffroy Schneck commented on OAK-1126: --- Example of one recent customer reaction : *We import packages from various instances. These packages might contain nodes, where both properties and subnodes use the same name.* I would also be worried about the effect on not supporting this anymore.. We have hundreds of customers imagining a ton of different content structure.. I wouldn't be surprised that adding this limitation will add problems to upgrade projects.. Same node and property name support --- Key: OAK-1126 URL: https://issues.apache.org/jira/browse/OAK-1126 Project: Jackrabbit Oak Issue Type: Sub-task Components: core, doc, jcr Reporter: Tobias Bocanegra Attachments: 0001-OAK-1126-Same-node-and-property-name-support.patch, 0002-OAK-1126-Same-node-and-property-name-support.patch, OAK-1126.patch The initial MK abstraction mandated that the nodes and properties share the same namespace (http://wiki.apache.org/jackrabbit/RepositoryMicroKernel#Data%20Model). This is a regression from Jackrabbit 2.x, which supports same name nodes and properties (SNNP). OTOH, the NodeStores can easily support SNNP and with proper escaping, the MKs can also support it. We should try to keep the support for SNNP in order to keep backward compatibility for existing content, and also keep the support for importing XML documents with same attribute and element names. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (OAK-1126) Same node and property name support
[ https://issues.apache.org/jira/browse/OAK-1126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13814069#comment-13814069 ] angela commented on OAK-1126: - [~gschneck] thanks for the hint. very helpful, indeed. Same node and property name support --- Key: OAK-1126 URL: https://issues.apache.org/jira/browse/OAK-1126 Project: Jackrabbit Oak Issue Type: Sub-task Components: core, doc, jcr Reporter: Tobias Bocanegra Attachments: 0001-OAK-1126-Same-node-and-property-name-support.patch, 0002-OAK-1126-Same-node-and-property-name-support.patch, OAK-1126.patch The initial MK abstraction mandated that the nodes and properties share the same namespace (http://wiki.apache.org/jackrabbit/RepositoryMicroKernel#Data%20Model). This is a regression from Jackrabbit 2.x, which supports same name nodes and properties (SNNP). OTOH, the NodeStores can easily support SNNP and with proper escaping, the MKs can also support it. We should try to keep the support for SNNP in order to keep backward compatibility for existing content, and also keep the support for importing XML documents with same attribute and element names. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (OAK-1126) Same node and property name support
[ https://issues.apache.org/jira/browse/OAK-1126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13812907#comment-13812907 ] Jukka Zitting commented on OAK-1126: +1 from me too. If we do apply the patch, we should also update relevant parts of the MicroKernel API and adjust the NodeStore documentation accordingly. Same node and property name support --- Key: OAK-1126 URL: https://issues.apache.org/jira/browse/OAK-1126 Project: Jackrabbit Oak Issue Type: Sub-task Components: core, doc, jcr Reporter: Tobias Bocanegra Attachments: OAK-1126.patch The initial MK abstraction mandated that the nodes and properties share the same namespace (http://wiki.apache.org/jackrabbit/RepositoryMicroKernel#Data%20Model). This is a regression from Jackrabbit 2.x, which supports same name nodes and properties (SNNP). OTOH, the NodeStores can easily support SNNP and with proper escaping, the MKs can also support it. We should try to keep the support for SNNP in order to keep backward compatibility for existing content, and also keep the support for importing XML documents with same attribute and element names. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (OAK-1126) Same node and property name support
[ https://issues.apache.org/jira/browse/OAK-1126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13812930#comment-13812930 ] Stefan Guggisberg commented on OAK-1126: bq. If we do apply the patch, we should also update relevant parts of the MicroKernel API and adjust the NodeStore documentation accordingly. -1 for changing the MicroKernel API until we have a clear picture of the full impact of such API changes. the change would e.g. also affect the commit method and the json_diff format. those changes, if we agree on them, need to be carefully documented. Same node and property name support --- Key: OAK-1126 URL: https://issues.apache.org/jira/browse/OAK-1126 Project: Jackrabbit Oak Issue Type: Sub-task Components: core, doc, jcr Reporter: Tobias Bocanegra Attachments: OAK-1126.patch The initial MK abstraction mandated that the nodes and properties share the same namespace (http://wiki.apache.org/jackrabbit/RepositoryMicroKernel#Data%20Model). This is a regression from Jackrabbit 2.x, which supports same name nodes and properties (SNNP). OTOH, the NodeStores can easily support SNNP and with proper escaping, the MKs can also support it. We should try to keep the support for SNNP in order to keep backward compatibility for existing content, and also keep the support for importing XML documents with same attribute and element names. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (OAK-1126) Same node and property name support
[ https://issues.apache.org/jira/browse/OAK-1126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13810184#comment-13810184 ] Stefan Guggisberg commented on OAK-1126: my main concern regarding SNNP is that it breaks the intuitive 1:1 JSON representation of repository content. artificial intermediary objects like e.g. :children are IMO non-intuitive and lead to awkward client code on the JSON consumer side. as discussed on the list: http://markmail.org/message/procpdcyctcibxdt Same node and property name support --- Key: OAK-1126 URL: https://issues.apache.org/jira/browse/OAK-1126 Project: Jackrabbit Oak Issue Type: Sub-task Components: core, doc, jcr Reporter: Tobias Bocanegra Attachments: OAK-1126.patch The initial MK abstraction mandated that the nodes and properties share the same namespace (http://wiki.apache.org/jackrabbit/RepositoryMicroKernel#Data%20Model). This is a regression from Jackrabbit 2.x, which supports same name nodes and properties (SNNP). OTOH, the NodeStores can easily support SNNP and with proper escaping, the MKs can also support it. We should try to keep the support for SNNP in order to keep backward compatibility for existing content, and also keep the support for importing XML documents with same attribute and element names. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (OAK-1126) Same node and property name support
[ https://issues.apache.org/jira/browse/OAK-1126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13809369#comment-13809369 ] angela commented on OAK-1126: - in case we decide to apply the patch we could drop this issue from the diff. Same node and property name support --- Key: OAK-1126 URL: https://issues.apache.org/jira/browse/OAK-1126 Project: Jackrabbit Oak Issue Type: Sub-task Components: core, doc, jcr Reporter: Tobias Bocanegra Attachments: OAK-1126.patch The initial MK abstraction mandated that the nodes and properties share the same namespace (http://wiki.apache.org/jackrabbit/RepositoryMicroKernel#Data%20Model). This is a regression from Jackrabbit 2.x, which supports same name nodes and properties (SNNP). OTOH, the NodeStores can easily support SNNP and with proper escaping, the MKs can also support it. We should try to keep the support for SNNP in order to keep backward compatibility for existing content, and also keep the support for importing XML documents with same attribute and element names. -- This message was sent by Atlassian JIRA (v6.1#6144)
