[
https://issues.apache.org/jira/browse/OAK-3001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15679339#comment-15679339
]
Julian Reschke commented on OAK-3001:
-
trunk: [r1770003|http://svn.apache.org/r1770003]
[
https://issues.apache.org/jira/browse/OAK-3001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15670778#comment-15670778
]
Vikas Saurabh commented on OAK-3001:
Done (OAK-5119).
> Simplify JournalGarbageCollector using a
[
https://issues.apache.org/jira/browse/OAK-3001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15670200#comment-15670200
]
Marcel Reutegger commented on OAK-3001:
---
That's better, yes.
> Simplify JournalGarbageCollector using
[
https://issues.apache.org/jira/browse/OAK-3001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15670192#comment-15670192
]
Vikas Saurabh commented on OAK-3001:
[~mreutegg], oh!, i meant if I need to update this code to utilize
[
https://issues.apache.org/jira/browse/OAK-3001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15670187#comment-15670187
]
Vikas Saurabh commented on OAK-3001:
[~mreutegg], I should've clarified my statement better. What I
[
https://issues.apache.org/jira/browse/OAK-3001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15670134#comment-15670134
]
Stefan Egli commented on OAK-3001:
--
bq. can you please review if I wavered off from what we planned to do?
[
https://issues.apache.org/jira/browse/OAK-3001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15670100#comment-15670100
]
Stefan Egli commented on OAK-3001:
--
bq. noticed OAK-3975 in related issues. I think we should revert that
[
https://issues.apache.org/jira/browse/OAK-3001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15669900#comment-15669900
]
Marcel Reutegger commented on OAK-3001:
---
bq. I didn't extend Condition class for this as afaics usage
[
https://issues.apache.org/jira/browse/OAK-3001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15669885#comment-15669885
]
Marcel Reutegger commented on OAK-3001:
---
AFAICS you didn't change any checks, you added more. The
[
https://issues.apache.org/jira/browse/OAK-3001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15669642#comment-15669642
]
Vikas Saurabh commented on OAK-3001:
[~mreutegg], travis build failed after my last commit
[
https://issues.apache.org/jira/browse/OAK-3001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15669636#comment-15669636
]
Vikas Saurabh commented on OAK-3001:
Travis build failed
[
https://issues.apache.org/jira/browse/OAK-3001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15669384#comment-15669384
]
Vikas Saurabh commented on OAK-3001:
[~egli], just noticed OAK-3975 in related issues. I think we should
[
https://issues.apache.org/jira/browse/OAK-3001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15669321#comment-15669321
]
Vikas Saurabh commented on OAK-3001:
Committed the patch on trunk at
[
https://issues.apache.org/jira/browse/OAK-3001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15669049#comment-15669049
]
Julian Reschke commented on OAK-3001:
-
I would say: go ahead, as long you have tests, and at least
[
https://issues.apache.org/jira/browse/OAK-3001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15667061#comment-15667061
]
Stefan Egli commented on OAK-3001:
--
sounds good to me
> Simplify JournalGarbageCollector using a dedicated
[
https://issues.apache.org/jira/browse/OAK-3001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15667045#comment-15667045
]
Vikas Saurabh commented on OAK-3001:
[~mreutegg], [~egli], {{JournalGarbageCollector#gc}} currently
[
https://issues.apache.org/jira/browse/OAK-3001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15633215#comment-15633215
]
Marcel Reutegger commented on OAK-3001:
---
No, not necessarily. I think we can also implement this
[
https://issues.apache.org/jira/browse/OAK-3001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15633201#comment-15633201
]
Stefan Egli commented on OAK-3001:
--
[~mreutegg], I've seen you moved OAK-3213 to 1.8 - that would imply
[
https://issues.apache.org/jira/browse/OAK-3001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15140957#comment-15140957
]
Stefan Egli commented on OAK-3001:
--
As discussed offline the decision is to not rush this into 1.4 unless
[
https://issues.apache.org/jira/browse/OAK-3001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15130249#comment-15130249
]
Julian Reschke commented on OAK-3001:
-
[~egli] would supporting a range for the indexed property fix
[
https://issues.apache.org/jira/browse/OAK-3001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15130264#comment-15130264
]
Chetan Mehrotra commented on OAK-3001:
--
We should aim for simply deleting from the backend without
[
https://issues.apache.org/jira/browse/OAK-3001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15130268#comment-15130268
]
Julian Reschke commented on OAK-3001:
-
+1 - let's do the simplest possible thing here to address the
[
https://issues.apache.org/jira/browse/OAK-3001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15130260#comment-15130260
]
Stefan Egli commented on OAK-3001:
--
bq. would supporting a range for the indexed property fix this problem?
[
https://issues.apache.org/jira/browse/OAK-3001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14733695#comment-14733695
]
Stefan Egli commented on OAK-3001:
--
OAK-3001 is blocked by OAK-3213
> Simplify JournalGarbageCollector
[
https://issues.apache.org/jira/browse/OAK-3001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14645579#comment-14645579
]
Julian Reschke commented on OAK-3001:
-
I recommend going back to the API discussion on
[
https://issues.apache.org/jira/browse/OAK-3001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14642871#comment-14642871
]
Stefan Egli commented on OAK-3001:
--
[~mreutegg], [~reschke], [~chetanm], how should we
[
https://issues.apache.org/jira/browse/OAK-3001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14609836#comment-14609836
]
Marcel Reutegger commented on OAK-3001:
---
I converted this issue from a sub-task of
[
https://issues.apache.org/jira/browse/OAK-3001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14595911#comment-14595911
]
Marcel Reutegger commented on OAK-3001:
---
I'm a bit worried about adding more complex
[
https://issues.apache.org/jira/browse/OAK-3001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14595891#comment-14595891
]
Stefan Egli commented on OAK-3001:
--
[~chetanm], [~mreutegg], wdyt?
Simplify
29 matches
Mail list logo
