[jira] [Commented] (OAK-4518) ConcurrentAddReferenceTest fails occasionally
[ https://issues.apache.org/jira/browse/OAK-4518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16262890#comment-16262890 ] Marcel Reutegger commented on OAK-4518: --- Merged into branches: - 1.4: http://svn.apache.org/r1816067 > ConcurrentAddReferenceTest fails occasionally > - > > Key: OAK-4518 > URL: https://issues.apache.org/jira/browse/OAK-4518 > Project: Jackrabbit Oak > Issue Type: Bug > Components: core, documentmk >Affects Versions: 1.4 >Reporter: Marcel Reutegger >Assignee: Marcel Reutegger >Priority: Minor > Labels: candidate_oak_1_0, candidate_oak_1_2 > Fix For: 1.5.6, 1.6.0, 1.4.19 > > Attachments: OAK-4518-test.patch > > > Occasional test failures have already been reported in OAK-1472, but it still > fails every now and > [then|https://travis-ci.org/apache/jackrabbit-oak/builds/140501786]. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OAK-4518) ConcurrentAddReferenceTest fails occasionally
[ https://issues.apache.org/jira/browse/OAK-4518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15356972#comment-15356972 ] Chetan Mehrotra commented on OAK-4518: -- bq. It would be best to remove this cache entirely. In contrast to other caches, this one is not revision based and hard to maintain. +1. This cache also has poor hit ratio in many of the setups I have seen. > ConcurrentAddReferenceTest fails occasionally > - > > Key: OAK-4518 > URL: https://issues.apache.org/jira/browse/OAK-4518 > Project: Jackrabbit Oak > Issue Type: Bug > Components: core, documentmk >Affects Versions: 1.4 >Reporter: Marcel Reutegger >Assignee: Marcel Reutegger >Priority: Minor > Fix For: 1.6 > > Attachments: OAK-4518-test.patch > > > Occasional test failures have already been reported in OAK-1472, but it still > fails every now and > [then|https://travis-ci.org/apache/jackrabbit-oak/builds/140501786]. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OAK-4518) ConcurrentAddReferenceTest fails occasionally
[
https://issues.apache.org/jira/browse/OAK-4518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15356913#comment-15356913
]
Marcel Reutegger commented on OAK-4518:
---
The problem is caused by the {{docChildrenCache}} in {{DocumentNodeStore}}. The
cache is populated by commits when they exit the commit queue (this is
serialized) and when child nodes are queried. Those two usages are not properly
synchronized and it may happen that a query puts stale data into the cache.
It would be best to remove this cache entirely. In contrast to other caches,
this one is not revision based and hard to maintain. Instead the
DocumentNodeStore must try to reduce queries for child nodes. There is already
an open issue for this: OAK-1322.
> ConcurrentAddReferenceTest fails occasionally
> -
>
> Key: OAK-4518
> URL: https://issues.apache.org/jira/browse/OAK-4518
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: core, documentmk
>Affects Versions: 1.4
>Reporter: Marcel Reutegger
>Assignee: Marcel Reutegger
>Priority: Minor
> Fix For: 1.6
>
> Attachments: OAK-4518-test.patch
>
>
> Occasional test failures have already been reported in OAK-1472, but it still
> fails every now and
> [then|https://travis-ci.org/apache/jackrabbit-oak/builds/140501786].
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OAK-4518) ConcurrentAddReferenceTest fails occasionally
[ https://issues.apache.org/jira/browse/OAK-4518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15355353#comment-15355353 ] Marcel Reutegger commented on OAK-4518: --- Added a test that fails more reliably (currently ignored): http://svn.apache.org/r1750656 > ConcurrentAddReferenceTest fails occasionally > - > > Key: OAK-4518 > URL: https://issues.apache.org/jira/browse/OAK-4518 > Project: Jackrabbit Oak > Issue Type: Bug > Components: core, documentmk >Affects Versions: 1.4 >Reporter: Marcel Reutegger >Assignee: Marcel Reutegger >Priority: Minor > Fix For: 1.6 > > Attachments: OAK-4518-test.patch > > > Occasional test failures have already been reported in OAK-1472, but it still > fails every now and > [then|https://travis-ci.org/apache/jackrabbit-oak/builds/140501786]. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OAK-4518) ConcurrentAddReferenceTest fails occasionally
[ https://issues.apache.org/jira/browse/OAK-4518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15354866#comment-15354866 ] Chetan Mehrotra commented on OAK-4518: -- Liked the use of bytecode manipulation to create timing scenarios! bq. Unfortunately byteman is LGPL and we can't include the test Thats bad > ConcurrentAddReferenceTest fails occasionally > - > > Key: OAK-4518 > URL: https://issues.apache.org/jira/browse/OAK-4518 > Project: Jackrabbit Oak > Issue Type: Bug > Components: core, documentmk >Affects Versions: 1.4 >Reporter: Marcel Reutegger >Assignee: Marcel Reutegger >Priority: Minor > Fix For: 1.6 > > Attachments: OAK-4518-test.patch > > > Occasional test failures have already been reported in OAK-1472, but it still > fails every now and > [then|https://travis-ci.org/apache/jackrabbit-oak/builds/140501786]. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
