[jira] [Commented] (OAK-4817) QueryEngineSettings without MBean

2016-10-14 Thread Thomas Mueller (JIRA) 

[ 
https://issues.apache.org/jira/browse/OAK-4817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15575111#comment-15575111
 ] 

Thomas Mueller commented on OAK-4817:
-

[~chetanm] makes sense, I have removed the wrap method. I didn't create a new 
patch, but instead committed the change. Please re-open if there is a problem.

http://svn.apache.org/r1764879 (trunk)




> QueryEngineSettings without MBean
> -
>
> Key: OAK-4817
> URL: https://issues.apache.org/jira/browse/OAK-4817
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: query
>Reporter: Thomas Mueller
>Assignee: Thomas Mueller
> Fix For: 1.6
>
> Attachments: OAK-4817.patch
>
>
> QueryEngineSettings is currently an MBean, and constructing a new instance is 
> expensive. This is seem in some oak-core security components. The MBean 
> functionality should be decoupled.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OAK-4817) QueryEngineSettings without MBean

2016-10-13 Thread Chetan Mehrotra (JIRA) 

[ 
https://issues.apache.org/jira/browse/OAK-4817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15571368#comment-15571368
 ] 

Chetan Mehrotra commented on OAK-4817:
--

Can you remove the wrap method from {{QueryEngineSettings}} as it adds 
reference to {{QueryEngineSettingsMBeanImpl}} which has dependency on JMX api 
and this is not allowed in Google App Engine env [1] and due to this I have to 
override this in 
[oakutils|https://github.com/chetanmeh/oakutils/blob/master/src/main/java/org/apache/jackrabbit/oak/query/QueryEngineSettings.java]
{noformat}
  */
+public QueryEngineSettingsMBeanImpl wrap() {
+return new QueryEngineSettingsMBeanImpl(this);
+}
{noformat}

[1] https://cloud.google.com/appengine/docs/java/jrewhitelist?csw=1

> QueryEngineSettings without MBean
> -
>
> Key: OAK-4817
> URL: https://issues.apache.org/jira/browse/OAK-4817
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: query
>Reporter: Thomas Mueller
>Assignee: Thomas Mueller
> Fix For: 1.6
>
> Attachments: OAK-4817.patch
>
>
> QueryEngineSettings is currently an MBean, and constructing a new instance is 
> expensive. This is seem in some oak-core security components. The MBean 
> functionality should be decoupled.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)