[jira] [Commented] (OAK-4930) External Principal Management: DynamicSyncContext makes redundant calls to IdentityProvider.getIdentity()
[ https://issues.apache.org/jira/browse/OAK-4930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16518124#comment-16518124 ] Julian Reschke commented on OAK-4930: - trunk: [r1774497|http://svn.apache.org/r1774497] [r1772228|http://svn.apache.org/r1772228] [r1772088|http://svn.apache.org/r1772088] [r1764885|http://svn.apache.org/r1764885] [r1764678|http://svn.apache.org/r1764678] 1.4: [r1774499|http://svn.apache.org/r1774499] [r1772235|http://svn.apache.org/r1772235] [r1764703|http://svn.apache.org/r1764703] [r1764700|http://svn.apache.org/r1764700] > External Principal Management: DynamicSyncContext makes redundant calls to > IdentityProvider.getIdentity() > -- > > Key: OAK-4930 > URL: https://issues.apache.org/jira/browse/OAK-4930 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: auth-external >Affects Versions: 1.2.20, 1.4.8, 1.5.12 >Reporter: Manfred Baedke >Assignee: Manfred Baedke >Priority: Major > Fix For: 1.4.9, 1.5.13, 1.6.0 > > > When recursively collecting principal names associated with the declared > group memberships of a given principal, the method > DynamicSyncContext.collectPrincipalNames() unnecessarily calls > IdentityProvider.getIdentity() for every declared group reference, though it > is only necessary when the actual depth of the remaining recursion is >1. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OAK-4930) External Principal Management: DynamicSyncContext makes redundant calls to IdentityProvider.getIdentity()
[ https://issues.apache.org/jira/browse/OAK-4930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15712262#comment-15712262 ] Manfred Baedke commented on OAK-4930: - Partially reverting [r1764678|http://svn.apache.org/r1764678]. Please see OAK-5200 for reasons. trunk: r1772228. > External Principal Management: DynamicSyncContext makes redundant calls to > IdentityProvider.getIdentity() > -- > > Key: OAK-4930 > URL: https://issues.apache.org/jira/browse/OAK-4930 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: auth-external >Affects Versions: 1.4.8, 1.2.20, 1.5.12 >Reporter: Manfred Baedke >Assignee: Manfred Baedke > Fix For: 1.6, 1.4.9, 1.5.13 > > > When recursively collecting principal names associated with the declared > group memberships of a given principal, the method > DynamicSyncContext.collectPrincipalNames() unnecessarily calls > IdentityProvider.getIdentity() for every declared group reference, though it > is only necessary when the actual depth of the remaining recursion is >1. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OAK-4930) External Principal Management: DynamicSyncContext makes redundant calls to IdentityProvider.getIdentity()
[ https://issues.apache.org/jira/browse/OAK-4930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15709728#comment-15709728 ] angela commented on OAK-4930: - [~baedke], i had a second look because the usage of id for principal name made me suspicious this improvement introduced a severe bug and needs to be reverted asap (see OAK_5200). > External Principal Management: DynamicSyncContext makes redundant calls to > IdentityProvider.getIdentity() > -- > > Key: OAK-4930 > URL: https://issues.apache.org/jira/browse/OAK-4930 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: auth-external >Affects Versions: 1.4.8, 1.2.20, 1.5.12 >Reporter: Manfred Baedke >Assignee: Manfred Baedke > Fix For: 1.6, 1.4.9, 1.5.13 > > > When recursively collecting principal names associated with the declared > group memberships of a given principal, the method > DynamicSyncContext.collectPrincipalNames() unnecessarily calls > IdentityProvider.getIdentity() for every declared group reference, though it > is only necessary when the actual depth of the remaining recursion is >1. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OAK-4930) External Principal Management: DynamicSyncContext makes redundant calls to IdentityProvider.getIdentity()
[ https://issues.apache.org/jira/browse/OAK-4930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15571993#comment-15571993 ] Manfred Baedke commented on OAK-4930: - Fixed in trunk: r1764678. > External Principal Management: DynamicSyncContext makes redundant calls to > IdentityProvider.getIdentity() > -- > > Key: OAK-4930 > URL: https://issues.apache.org/jira/browse/OAK-4930 > Project: Jackrabbit Oak > Issue Type: Bug > Components: auth-external >Affects Versions: 1.4.8, 1.2.20, 1.5.12 >Reporter: Manfred Baedke >Assignee: Manfred Baedke > > When recursively collecting principal names associated with the declared > group memberships of a given principal, the method > DynamicSyncContext.collectPrincipalNames() unnecessarily calls > IdentityProvider.getIdentity() for every declared group reference, though it > is only necessary when the actual depth of the remaining recursion is >1. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
